Michal Kubeček e44699d2c2 net: handle NAPI_GRO_FREE_STOLEN_HEAD case also in napi_frags_finish() ... Recently I started seeing warnings about pages with refcount -1. The problem was traced to packets being reused after their head was merged into a GRO packet by skb_gro_receive(). While bisecting the issue pointed to commit c21b48cc1b ("net: adjust skb->truesize in ___pskb_trim()") and I have never seen it on a kernel with it reverted, I believe the real problem appeared earlier when the option to merge head frag in GRO was implemented. Handling NAPI_GRO_FREE_STOLEN_HEAD state was only added to GRO_MERGED_FREE branch of napi_skb_finish() so that if the driver uses napi_gro_frags() and head is merged (which in my case happens after the skb_condense() call added by the commit mentioned above), the skb is reused including the head that has been merged. As a result, we release the page reference twice and eventually end up with negative page refcount. To fix the problem, handle NAPI_GRO_FREE_STOLEN_HEAD in napi_frags_finish() the same way it's done in napi_skb_finish(). Fixes: d7e8883cfc ("net: make GRO aware of skb->head_frag") Signed-off-by: Michal Kubecek <mkubecek@suse.cz> Signed-off-by: David S. Miller <davem@davemloft.net>		2017-06-29 15:54:13 -04:00
..
6lowpan	6lowpan: Don't set IFF_NO_QUEUE	2017-04-12 22:02:40 +02:00
9p	xen: fixes for 4.12 rc2	2017-05-19 15:06:48 -07:00
802	…
8021q	net: 8021q: Fix one possible panic caused by BUG_ON in free_netdev	2017-06-19 14:10:20 -04:00
appletalk	lib/vsprintf.c: remove %Z support	2017-02-27 18:43:47 -08:00
atm	neighbour: fix nlmsg_pid in notifications	2017-03-22 10:48:49 -07:00
ax25	net: Work around lockdep limitation in sockets that use sockets	2017-03-09 18:23:27 -08:00
batman-adv	Here are two batman-adv bugfixes:	2017-06-13 13:46:01 -04:00
bluetooth	net: Fix inconsistent teardown and release of private netdev state.	2017-06-07 15:53:24 -04:00
bpf	bpf: Align packet data properly in program testing framework.	2017-05-02 11:46:28 -04:00
bridge	net: Fix inconsistent teardown and release of private netdev state.	2017-06-07 15:53:24 -04:00
caif	caif: Add sockaddr length check before accessing sa_family in connect handler	2017-06-13 16:16:11 -04:00
can	can: af_can: namespace support: fix lockdep splat: properly initialize spin_lock	2017-06-09 11:39:23 +02:00
ceph	libceph: cleanup old messages according to reconnect seq	2017-05-24 18:10:51 +02:00
core	net: handle NAPI_GRO_FREE_STOLEN_HEAD case also in napi_frags_finish()	2017-06-29 15:54:13 -04:00
dcb	net: rtnetlink: plumb extended ack to doit function	2017-04-17 15:35:38 -04:00
dccp	Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net	2017-05-15 15:50:49 -07:00
decnet	decnet: always not take dst->__refcnt when inserting dst into hash table	2017-06-16 14:59:36 -04:00
dns_resolver	Merge branch 'WIP.sched-core-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip	2017-03-03 10:16:38 -08:00
dsa	net: dsa: Fix stale cpu_switch reference after unbind then bind	2017-06-04 22:55:17 -04:00
ethernet	Merge branch 'master' of git://git.kernel.org/pub/scm/linux/kernel/git/klassert/ipsec-next	2017-02-16 21:25:49 -05:00
hsr	hsr: fix incorrect warning	2017-06-12 15:21:20 -04:00
ieee802154	net: Fix inconsistent teardown and release of private netdev state.	2017-06-07 15:53:24 -04:00
ife	net: Introduce ife encapsulation module	2017-02-03 15:16:45 -05:00
ipv4	tcp: reset sk_rx_dst in tcp_disconnect()	2017-06-25 12:23:07 -04:00
ipv6	net: ipv6: reset daddr and dport in sk if connect() fails	2017-06-25 11:46:56 -04:00
ipx	ipx: call ipxitf_put() in ioctl error path	2017-05-02 15:34:53 -04:00
irda	net: Fix inconsistent teardown and release of private netdev state.	2017-06-07 15:53:24 -04:00
iucv	net: Work around lockdep limitation in sockets that use sockets	2017-03-09 18:23:27 -08:00
kcm	kcm: remove a useless copy_from_user()	2017-04-17 13:28:48 -04:00
key	xfrm: NULL dereference on allocation failure	2017-06-14 12:40:49 +02:00
l2tp	l2tp: cast l2tp traffic counter to unsigned	2017-06-10 16:14:27 -04:00
l3mdev	…
lapb	…
llc	net: llc: add lock_sock in llc_ui_bind to avoid a race condition	2017-05-26 14:20:29 -04:00
mac80211	Some fixes:	2017-06-13 13:34:13 -04:00
mac802154	net: Fix inconsistent teardown and release of private netdev state.	2017-06-07 15:53:24 -04:00
mpls	mpls: fix clearing of dead nh_flags on link up	2017-05-31 14:48:24 -04:00
ncsi	…
netfilter	netfilter: ctnetlink: fix incorrect nf_ct_put during hash resize	2017-05-24 11:26:01 +02:00
netlabel	netlink: pass extended ACK struct to parsing functions	2017-04-13 13:58:22 -04:00
netlink	netlink: don't send unknown nsid	2017-06-01 11:49:39 -04:00
netrom	net: Work around lockdep limitation in sockets that use sockets	2017-03-09 18:23:27 -08:00
nfc	NFC 4.12 pull request	2017-04-21 15:29:40 -04:00
openvswitch	net: Fix inconsistent teardown and release of private netdev state.	2017-06-07 15:53:24 -04:00
packet	net/packet: fix missing net_device reference release	2017-05-15 14:22:12 -04:00
phonet	net: Fix inconsistent teardown and release of private netdev state.	2017-06-07 15:53:24 -04:00
psample	net: Introduce psample, a new genetlink channel for packet sampling	2017-01-24 13:44:28 -05:00
qrtr	Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net	2017-04-21 20:23:53 -07:00
rds	Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next	2017-05-02 16:40:27 -07:00
rfkill	rfkill: remove rfkill-regulator	2017-01-24 11:07:35 +01:00
rose	net: Work around lockdep limitation in sockets that use sockets	2017-03-09 18:23:27 -08:00
rxrpc	rxrpc: Fix several cases where a padded len isn't checked in ticket decode	2017-06-15 14:23:44 -04:00
sched	net: sched: Fix one possible panic when no destroy callback	2017-06-29 12:55:12 -04:00
sctp	sctp: ensure ep is not destroyed before doing the dump	2017-06-19 15:13:43 -04:00
smc	net/smc: Add warning about remote memory exposure	2017-05-16 14:49:43 -04:00
strparser	strparser: destroy workqueue on module exit	2017-03-03 20:43:26 -08:00
sunrpc	SUNRPC: ensure correct error is reported by xs_tcp_setup_socket()	2017-05-31 12:26:44 -04:00
switchdev	netlink: pass extended ACK struct to parsing functions	2017-04-13 13:58:22 -04:00
tipc	net: tipc: Fix a sleep-in-atomic bug in tipc_msg_reverse	2017-06-10 18:20:38 -04:00
unix	af_unix: Add sockaddr length checks before accessing sa_family in bind and connect handlers	2017-06-09 10:10:24 -04:00
vmw_vsock	vsock: use new wait API for vsock_stream_sendmsg()	2017-05-22 14:39:36 -04:00
wimax	…
wireless	dev_ioctl: copy only the smaller struct iwreq for wext	2017-06-14 13:52:44 +02:00
x25	net: x25: fix one potential use-after-free issue	2017-05-18 10:05:40 -04:00
xfrm	xfrm: move xfrm_garbage_collect out of xfrm_policy_flush	2017-06-12 11:51:21 +02:00
Kconfig	bpf: make jited programs visible in traces	2017-02-17 13:40:05 -05:00
Makefile	bpf: introduce BPF_PROG_TEST_RUN command	2017-04-01 12:45:57 -07:00
compat.c	Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next	2017-02-22 10:15:09 -08:00
socket.c	l2tp: device MTU setup, tunnel socket needs a lock	2017-04-17 13:01:48 -04:00
sysctl_net.c	sysctl: Remove dead register_sysctl_root	2017-04-16 23:42:49 -05:00