Roman Gushchin 38ed310c22 firmware: xilinx: don't make a sleepable memory allocation from an atomic context ... The following issue was discovered using lockdep: [ 6.691371] BUG: sleeping function called from invalid context at include/linux/sched/mm.h:209 [ 6.694602] in_atomic(): 1, irqs_disabled(): 128, non_block: 0, pid: 1, name: swapper/0 [ 6.702431] 2 locks held by swapper/0/1: [ 6.706300] #0: ffffff8800f6f188 (&dev->mutex){....}-{3:3}, at: __device_driver_lock+0x4c/0x90 [ 6.714900] #1: ffffffc009a2abb8 (enable_lock){....}-{2:2}, at: clk_enable_lock+0x4c/0x140 [ 6.723156] irq event stamp: 304030 [ 6.726596] hardirqs last enabled at (304029): [<ffffffc008d17ee0>] _raw_spin_unlock_irqrestore+0xc0/0xd0 [ 6.736142] hardirqs last disabled at (304030): [<ffffffc00876bc5c>] clk_enable_lock+0xfc/0x140 [ 6.744742] softirqs last enabled at (303958): [<ffffffc0080904f0>] _stext+0x4f0/0x894 [ 6.752655] softirqs last disabled at (303951): [<ffffffc0080e53b8>] irq_exit+0x238/0x280 [ 6.760744] CPU: 1 PID: 1 Comm: swapper/0 Tainted: G U 5.15.36 #2 [ 6.768048] Hardware name: xlnx,zynqmp (DT) [ 6.772179] Call trace: [ 6.774584] dump_backtrace+0x0/0x300 [ 6.778197] show_stack+0x18/0x30 [ 6.781465] dump_stack_lvl+0xb8/0xec [ 6.785077] dump_stack+0x1c/0x38 [ 6.788345] ___might_sleep+0x1a8/0x2a0 [ 6.792129] __might_sleep+0x6c/0xd0 [ 6.795655] kmem_cache_alloc_trace+0x270/0x3d0 [ 6.800127] do_feature_check_call+0x100/0x220 [ 6.804513] zynqmp_pm_invoke_fn+0x8c/0xb0 [ 6.808555] zynqmp_pm_clock_getstate+0x90/0xe0 [ 6.813027] zynqmp_pll_is_enabled+0x8c/0x120 [ 6.817327] zynqmp_pll_enable+0x38/0xc0 [ 6.821197] clk_core_enable+0x144/0x400 [ 6.825067] clk_core_enable+0xd4/0x400 [ 6.828851] clk_core_enable+0xd4/0x400 [ 6.832635] clk_core_enable+0xd4/0x400 [ 6.836419] clk_core_enable+0xd4/0x400 [ 6.840203] clk_core_enable+0xd4/0x400 [ 6.843987] clk_core_enable+0xd4/0x400 [ 6.847771] clk_core_enable+0xd4/0x400 [ 6.851555] clk_core_enable_lock+0x24/0x50 [ 6.855683] clk_enable+0x24/0x40 [ 6.858952] fclk_probe+0x84/0xf0 [ 6.862220] platform_probe+0x8c/0x110 [ 6.865918] really_probe+0x110/0x5f0 [ 6.869530] __driver_probe_device+0xcc/0x210 [ 6.873830] driver_probe_device+0x64/0x140 [ 6.877958] __driver_attach+0x114/0x1f0 [ 6.881828] bus_for_each_dev+0xe8/0x160 [ 6.885698] driver_attach+0x34/0x50 [ 6.889224] bus_add_driver+0x228/0x300 [ 6.893008] driver_register+0xc0/0x1e0 [ 6.896792] __platform_driver_register+0x44/0x60 [ 6.901436] fclk_driver_init+0x1c/0x28 [ 6.905220] do_one_initcall+0x104/0x590 [ 6.909091] kernel_init_freeable+0x254/0x2bc [ 6.913390] kernel_init+0x24/0x130 [ 6.916831] ret_from_fork+0x10/0x20 Fix it by passing the GFP_ATOMIC gfp flag for the corresponding memory allocation. Fixes: acfdd18591 ("firmware: xilinx: Use hash-table for api feature check") Cc: stable <stable@kernel.org> Signed-off-by: Roman Gushchin <roman.gushchin@linux.dev> Cc: Amit Sunil Dhamne <amit.sunil.dhamne@xilinx.com> Cc: Michal Simek <michal.simek@xilinx.com> Cc: linux-arm-kernel@lists.infradead.org Cc: linux-kernel@vger.kernel.org Link: https://lore.kernel.org/r/20230308222602.123866-1-roman.gushchin@linux.dev Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>		2023-03-09 18:00:31 +01:00
..
arm_ffa	driver core: make struct bus_type.uevent() take a const *	2023-01-27 13:45:52 +01:00
arm_scmi	ARM: SoC drivers for 6.3	2023-02-27 10:04:49 -08:00
broadcom	firmware/nvram: bcm47xx: support init from IO memory	2022-11-09 10:27:10 -08:00
cirrus	firmware: cs_dsp: Switch to using namespaced exports	2022-11-25 14:36:56 +00:00
efi	A healthy mix of EFI contributions this time:	2023-02-23 14:41:48 -08:00
google	Char/Misc and other driver subsystem changes for 6.3-rc1	2023-02-24 12:47:33 -08:00
imx	firmware: imx: scu-pd: add missed USB_1_PHY pd	2022-10-24 10:05:27 +08:00
meson	firmware: meson_sm: stop using 0 as NULL pointer	2023-01-10 15:21:13 +01:00
psci	cpuidle: drivers: firmware: psci: Dont instrument suspend code	2023-01-31 15:01:45 +01:00
smccc	printk: stop including cache.h from printk.h	2022-05-13 07:20:07 -07:00
tegra	tegra: mark BPMP driver as little-endian only	2022-11-23 14:21:23 +01:00
xilinx	firmware: xilinx: don't make a sleepable memory allocation from an atomic context	2023-03-09 18:00:31 +01:00
Kconfig	sound updates for 5.19-rc1	2022-05-25 16:55:16 -07:00
Makefile	Follow-up tweaks for the EFI changes in v5.19	2022-06-03 13:39:30 -07:00
arm_scpi.c	firmware: arm_scpi: Ensure scpi_info is not assigned if the probe fails	2022-07-04 14:28:42 +01:00
arm_sdei.c	ACPI: APEI: explicit init of HEST and GHES in apci_init()	2022-03-03 20:24:22 +01:00
dmi-id.c	driver core: make struct class.dev_uevent() take a const *	2022-11-24 17:12:15 +01:00
dmi-sysfs.c	firmware: dmi-sysfs: Fix null-ptr-deref in dmi_sysfs_register_handle	2023-01-20 14:27:40 +01:00
dmi_scan.c	firmware: dmi: Fortify entry point length checks	2022-09-23 14:53:14 +02:00
edd.c	edd: simplify the check of 'attr->test' in edd_populate_dir()	2022-05-19 18:57:04 +02:00
iscsi_ibft.c	iscsi_ibft: Fix isa_bus_to_virt not working under ARM	2021-09-02 16:22:00 -04:00
iscsi_ibft_find.c	iscsi_ibft: fix warning in reserve_ibft_region()	2021-08-05 19:47:57 -04:00
memmap.c	firmware: memmap: use default_groups in kobj_type	2022-01-05 19:17:29 +01:00
mtk-adsp-ipc.c	firmware: mediatek: Use meaningful names for mbox	2022-06-22 13:39:30 +01:00
pcdp.c	…
pcdp.h	…
qcom_scm-legacy.c	firmware: qcom_scm: Move qcom_scm.h to include/linux/firmware/qcom/	2023-02-08 19:15:16 -08:00
qcom_scm-smc.c	firmware: qcom_scm: Move qcom_scm.h to include/linux/firmware/qcom/	2023-02-08 19:15:16 -08:00
qcom_scm.c	firmware: qcom_scm: Move qcom_scm.h to include/linux/firmware/qcom/	2023-02-08 19:15:16 -08:00
qcom_scm.h	firmware: qcom: scm: Add wait-queue handling logic	2023-01-18 21:14:40 -06:00
qemu_fw_cfg.c	firmware: qemu_fw_cfg: remove sysfs entries explicitly	2022-01-14 18:50:52 -05:00
raspberrypi.c	Char/Misc driver changes for 6.2-rc1	2022-12-16 03:49:24 -08:00
scpi_pm_domain.c	firmware: arm_scpi: Fix string overflow in SCPI genpd driver	2021-12-13 15:17:37 +01:00
stratix10-rsu.c	firmware: stratix10-rsu: extend RSU driver to get DCMF status	2022-07-14 16:55:09 +02:00
stratix10-svc.c	firmware: stratix10-svc: fix error handle while alloc/add device failed	2023-01-20 13:05:48 +01:00
sysfb.c	fbdev/vga16fb: Create EGA/VGA devices in sysfb code	2022-07-19 13:19:11 +02:00
sysfb_simplefb.c	firmware/sysfb: Fix EFI/VESA format selection	2023-01-03 14:23:03 +01:00
ti_sci.c	firmware: ti_sci: Use devm_bitmap_zalloc when applicable	2022-11-03 21:45:10 -05:00
ti_sci.h	…
trusted_foundations.c	…
turris-mox-rwtm.c	hwrng: core - treat default_quality as a maximum and default to 1024	2022-11-18 16:59:34 +08:00