5febf6d6ae
The current codebase makes use of the zero-length array language extension
to the C90 standard, but the preferred mechanism to declare variable-length
types such as these ones is a flexible array member[1][2], introduced in
C99:
struct foo {
int stuff;
struct boo array[];
};
By making use of the mechanism above, we will get a compiler warning in
case the flexible array does not occur last in the structure, which will
help us prevent some kind of undefined behavior bugs from being
inadvertently introduced[3] to the codebase from now on.
Also, notice that, dynamic memory allocations won't be affected by this
change:
"Flexible array members have incomplete type, and so the sizeof operator
may not be applied. As a quirk of the original implementation of
zero-length arrays, sizeof evaluates to zero."[1]
This issue was found with the help of Coccinelle.
[1] https://gcc.gnu.org/onlinedocs/gcc/Zero-Length.html
[2] https://github.com/KSPP/linux/issues/21
[3] commit
|
||
|---|---|---|
| .. | ||
| Makefile | ||
| cq_desc.h | ||
| cq_enet_desc.h | ||
| snic.h | ||
| snic_attrs.c | ||
| snic_ctl.c | ||
| snic_debugfs.c | ||
| snic_disc.c | ||
| snic_disc.h | ||
| snic_fwint.h | ||
| snic_io.c | ||
| snic_io.h | ||
| snic_isr.c | ||
| snic_main.c | ||
| snic_res.c | ||
| snic_res.h | ||
| snic_scsi.c | ||
| snic_stats.h | ||
| snic_trc.c | ||
| snic_trc.h | ||
| vnic_cq.c | ||
| vnic_cq.h | ||
| vnic_cq_fw.h | ||
| vnic_dev.c | ||
| vnic_dev.h | ||
| vnic_devcmd.h | ||
| vnic_intr.c | ||
| vnic_intr.h | ||
| vnic_resource.h | ||
| vnic_snic.h | ||
| vnic_stats.h | ||
| vnic_wq.c | ||
| vnic_wq.h | ||
| wq_enet_desc.h | ||