OpenCloudOS-Kernel/samples/bpf
Kees Cook ef33f02968 bpf: Replace bpf_lpm_trie_key 0-length array with flexible array
[ Upstream commit 896880ff30866f386ebed14ab81ce1ad3710cfc4 ]

Replace deprecated 0-length array in struct bpf_lpm_trie_key with
flexible array. Found with GCC 13:

../kernel/bpf/lpm_trie.c:207:51: warning: array subscript i is outside array bounds of 'const __u8[0]' {aka 'const unsigned char[]'} [-Warray-bounds=]
  207 |                                        *(__be16 *)&key->data[i]);
      |                                                   ^~~~~~~~~~~~~
../include/uapi/linux/swab.h:102:54: note: in definition of macro '__swab16'
  102 | #define __swab16(x) (__u16)__builtin_bswap16((__u16)(x))
      |                                                      ^
../include/linux/byteorder/generic.h:97:21: note: in expansion of macro '__be16_to_cpu'
   97 | #define be16_to_cpu __be16_to_cpu
      |                     ^~~~~~~~~~~~~
../kernel/bpf/lpm_trie.c:206:28: note: in expansion of macro 'be16_to_cpu'
  206 |                 u16 diff = be16_to_cpu(*(__be16 *)&node->data[i]
^
      |                            ^~~~~~~~~~~
In file included from ../include/linux/bpf.h:7:
../include/uapi/linux/bpf.h:82:17: note: while referencing 'data'
   82 |         __u8    data[0];        /* Arbitrary size */
      |                 ^~~~

And found at run-time under CONFIG_FORTIFY_SOURCE:

  UBSAN: array-index-out-of-bounds in kernel/bpf/lpm_trie.c:218:49
  index 0 is out of range for type '__u8 [*]'

Changing struct bpf_lpm_trie_key is difficult since has been used by
userspace. For example, in Cilium:

	struct egress_gw_policy_key {
	        struct bpf_lpm_trie_key lpm_key;
	        __u32 saddr;
	        __u32 daddr;
	};

While direct references to the "data" member haven't been found, there
are static initializers what include the final member. For example,
the "{}" here:

        struct egress_gw_policy_key in_key = {
                .lpm_key = { 32 + 24, {} },
                .saddr   = CLIENT_IP,
                .daddr   = EXTERNAL_SVC_IP & 0Xffffff,
        };

To avoid the build time and run time warnings seen with a 0-sized
trailing array for struct bpf_lpm_trie_key, introduce a new struct
that correctly uses a flexible array for the trailing bytes,
struct bpf_lpm_trie_key_u8. As part of this, include the "header"
portion (which is just the "prefixlen" member), so it can be used
by anything building a bpf_lpr_trie_key that has trailing members that
aren't a u8 flexible array (like the self-test[1]), which is named
struct bpf_lpm_trie_key_hdr.

Unfortunately, C++ refuses to parse the __struct_group() helper, so
it is not possible to define struct bpf_lpm_trie_key_hdr directly in
struct bpf_lpm_trie_key_u8, so we must open-code the union directly.

Adjust the kernel code to use struct bpf_lpm_trie_key_u8 through-out,
and for the selftest to use struct bpf_lpm_trie_key_hdr. Add a comment
to the UAPI header directing folks to the two new options.

Reported-by: Mark Rutland <mark.rutland@arm.com>
Signed-off-by: Kees Cook <keescook@chromium.org>
Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
Acked-by: Gustavo A. R. Silva <gustavoars@kernel.org>
Closes: https://paste.debian.net/hidden/ca500597/
Link: https://lore.kernel.org/all/202206281009.4332AA33@keescook/ [1]
Link: https://lore.kernel.org/bpf/20240222155612.it.533-kees@kernel.org
Stable-dep-of: 59f2f841179a ("bpf: Avoid kfree_rcu() under lock in bpf_lpm_trie.")
Signed-off-by: Sasha Levin <sashal@kernel.org>
2024-08-19 06:04:27 +02:00
..
gnu bpf: Replace deprecated -target with --target= for Clang 2023-06-29 15:46:17 +02:00
.gitignore samples/bpf: Cleanup .gitignore 2023-08-24 08:43:50 -07:00
Makefile samples/bpf: Remove the xdp_sample_pkts utility 2023-08-24 08:43:50 -07:00
Makefile.target samples/bpf: Clean up samples/bpf build failes 2021-12-02 15:23:40 -08:00
README.rst samples/bpf: Add note to README about the XDP utilities moved to xdp-tools 2023-08-24 08:43:50 -07:00
asm_goto_workaround.h work around gcc bugs with 'asm goto' with outputs 2024-02-23 09:24:47 +01:00
bpf_insn.h samples/bpf: Relicense bpf_insn.h as GPL-2.0-only OR BSD-2-Clause 2021-09-29 16:03:55 +02:00
cookie_uid_helper_example.c samples/bpf: Get rid of deprecated libbpf API uses 2021-12-02 15:23:40 -08:00
cpustat_kern.c bpf: use canonical ftrace path 2023-03-13 21:51:30 -07:00
cpustat_user.c samples/bpf: Use libbpf 1.0 API mode instead of RLIMIT_MEMLOCK 2022-04-10 20:17:15 -07:00
do_hbm_test.sh samples: bpf: Fix a spelling typo in do_hbm_test.sh 2021-03-15 22:17:35 -07:00
fds_example.c samples: bpf: Replace sizeof(arr)/sizeof(arr[0]) with ARRAY_SIZE 2022-07-13 21:43:52 -07:00
hash_func01.h samples/bpf: add Paul Hsieh's (LGPL 2.1) hash function SuperFastHash 2018-08-10 16:07:49 +02:00
hbm.c samples/bpf: Drop unnecessary fallthrough 2023-05-16 19:44:05 +02:00
hbm.h bpf: Add more stats to HBM 2019-05-31 16:41:29 -07:00
hbm_edt_kern.c samples/bpf: Fix double word in comments 2022-10-19 11:21:49 -07:00
hbm_kern.h samples/bpf: Clean up samples/bpf build failes 2021-12-02 15:23:40 -08:00
hbm_out_kern.c bpf: Add more stats to HBM 2019-05-31 16:41:29 -07:00
ibumad_kern.c bpf: use canonical ftrace path 2023-03-13 21:51:30 -07:00
ibumad_user.c samples/bpf: Use libbpf 1.0 API mode instead of RLIMIT_MEMLOCK 2022-04-10 20:17:15 -07:00
lathist_kern.c samples: bpf: Refactor kprobe tracing programs with libbpf 2020-08-24 20:59:35 -07:00
lathist_user.c samples: bpf: Refactor kprobe tracing programs with libbpf 2020-08-24 20:59:35 -07:00
lwt_len_hist.bpf.c samples/bpf: change _kern suffix to .bpf with BPF test programs 2023-01-15 13:32:45 -08:00
lwt_len_hist.sh bpf: use canonical ftrace path 2023-03-13 21:51:30 -07:00
lwt_len_hist_user.c samples: bpf: Fix build error 2020-05-14 12:37:39 -07:00
map_perf_test.bpf.c samples/bpf: Use BPF_KSYSCALL macro in syscall tracing programs 2022-12-29 14:22:34 -08:00
map_perf_test_user.c bpf: Replace bpf_lpm_trie_key 0-length array with flexible array 2024-08-19 06:04:27 +02:00
net_shared.h samples/bpf: convert to vmlinux.h with tracing programs 2023-08-21 15:39:09 -07:00
offwaketime.bpf.c samples/bpf: make tracing programs to be more CO-RE centric 2023-08-21 15:39:09 -07:00
offwaketime_user.c samples/bpf: unify bpf program suffix to .bpf with tracing programs 2023-08-21 15:39:09 -07:00
parse_ldabs.c samples/bpf: Use consistent include paths for libbpf 2020-01-20 16:37:45 -08:00
parse_simple.c samples/bpf: Use consistent include paths for libbpf 2020-01-20 16:37:45 -08:00
parse_varlen.c samples/bpf: Use consistent include paths for libbpf 2020-01-20 16:37:45 -08:00
run_cookie_uid_helper_example.sh License cleanup: add SPDX GPL-2.0 license identifier to files with no license 2017-11-02 11:10:55 +01:00
sampleip_kern.c bpf: Remove unused headers 2021-03-25 22:03:46 -07:00
sampleip_user.c samples/bpf: sampleip: Replace PAGE_OFFSET with _text address 2023-04-13 21:57:11 -07:00
sock_example.c samples: bpf: Replace sizeof(arr)/sizeof(arr[0]) with ARRAY_SIZE 2022-07-13 21:43:52 -07:00
sock_example.h samples: bpf: include bpf/bpf.h instead of local libbpf.h 2018-05-14 22:52:10 -07:00
sock_flags.bpf.c samples/bpf: change _kern suffix to .bpf with BPF test programs 2023-01-15 13:32:45 -08:00
sockex1_kern.c samples/bpf: Use consistent include paths for libbpf 2020-01-20 16:37:45 -08:00
sockex1_user.c samples/bpf: Get rid of deprecated libbpf API uses 2021-12-02 15:23:40 -08:00
sockex2_kern.c samples/bpf: Remove compiler warnings 2020-05-13 12:30:50 -07:00
sockex2_user.c samples/bpf: Use libbpf 1.0 API mode instead of RLIMIT_MEMLOCK 2022-04-10 20:17:15 -07:00
sockex3_kern.c samples/bpf: Fix sockex3 error: Missing BPF prog type 2022-11-07 17:13:35 -08:00
sockex3_user.c samples/bpf: Fix sockex3 error: Missing BPF prog type 2022-11-07 17:13:35 -08:00
spintest.bpf.c samples/bpf: simplify spintest with kprobe.multi 2023-08-21 15:39:10 -07:00
spintest_user.c samples/bpf: simplify spintest with kprobe.multi 2023-08-21 15:39:10 -07:00
syscall_nrs.c samples: bpf: syscall_nrs: use mmap2 if defined 2019-08-21 14:31:38 +02:00
syscall_tp_kern.c samples/bpf: syscall_tp: Aarch64 no open syscall 2023-07-11 10:02:42 -07:00
syscall_tp_user.c samples/bpf: syscall_tp_user: Fix array out-of-bound access 2023-11-28 17:19:48 +00:00
task_fd_query_kern.c samples/bpf: Replace blk_account_io_done() with __blk_account_io_done() 2022-09-20 17:25:59 -07:00
task_fd_query_user.c bpf: use canonical ftrace path 2023-03-13 21:51:30 -07:00
tc_l2_redirect.sh samples/bpf: ensure ipv6 is enabled before running tests 2023-01-15 13:32:45 -08:00
tc_l2_redirect_kern.c samples/bpf: Use consistent include paths for libbpf 2020-01-20 16:37:45 -08:00
tc_l2_redirect_user.c treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 206 2019-05-30 11:29:53 -07:00
tcbpf1_kern.c samples/bpf: Use consistent include paths for libbpf 2020-01-20 16:37:45 -08:00
tcp_basertt_kern.c samples/bpf: Fix buffer overflow in tcp_basertt 2023-05-05 08:37:48 -07:00
tcp_bpf.readme samples/bpf: fix tcp_bpf.readme detach command 2019-07-03 16:52:02 +02:00
tcp_bufs_kern.c samples/bpf: Use consistent include paths for libbpf 2020-01-20 16:37:45 -08:00
tcp_clamp_kern.c samples/bpf: Use consistent include paths for libbpf 2020-01-20 16:37:45 -08:00
tcp_cong_kern.c samples/bpf: Use consistent include paths for libbpf 2020-01-20 16:37:45 -08:00
tcp_dumpstats_kern.c samples/bpf: Use consistent include paths for libbpf 2020-01-20 16:37:45 -08:00
tcp_iw_kern.c samples/bpf: Use consistent include paths for libbpf 2020-01-20 16:37:45 -08:00
tcp_rwnd_kern.c samples/bpf: Use consistent include paths for libbpf 2020-01-20 16:37:45 -08:00
tcp_synrto_kern.c samples/bpf: Use consistent include paths for libbpf 2020-01-20 16:37:45 -08:00
tcp_tos_reflect_kern.c samples/bpf: Use consistent include paths for libbpf 2020-01-20 16:37:45 -08:00
test_cgrp2_array_pin.c samples/bpf: Get rid of deprecated libbpf API uses 2021-12-02 15:23:40 -08:00
test_cgrp2_attach.c samples: bpf: Replace sizeof(arr)/sizeof(arr[0]) with ARRAY_SIZE 2022-07-13 21:43:52 -07:00
test_cgrp2_sock.c samples/bpf: Get rid of deprecated libbpf API uses 2021-12-02 15:23:40 -08:00
test_cgrp2_sock.sh samples/bpf: refactor BPF functionality testing scripts 2023-01-15 13:32:45 -08:00
test_cgrp2_sock2.c samples: bpf: Refactor test_cgrp2_sock2 program with libbpf 2020-11-26 19:33:35 -08:00
test_cgrp2_sock2.sh samples/bpf: change _kern suffix to .bpf with BPF test programs 2023-01-15 13:32:45 -08:00
test_cgrp2_tc.bpf.c samples/bpf: change _kern suffix to .bpf with BPF test programs 2023-01-15 13:32:45 -08:00
test_cgrp2_tc.sh samples/bpf: change _kern suffix to .bpf with BPF test programs 2023-01-15 13:32:45 -08:00
test_cls_bpf.sh License cleanup: add SPDX GPL-2.0 license identifier to files with no license 2017-11-02 11:10:55 +01:00
test_current_task_under_cgroup.bpf.c samples/bpf: Use BPF_KSYSCALL macro in syscall tracing programs 2022-12-29 14:22:34 -08:00
test_current_task_under_cgroup_user.c samples/bpf: Change _kern suffix to .bpf with syscall tracing program 2022-12-29 14:22:34 -08:00
test_lru_dist.c samples/bpf: remove unused function with test_lru_dist 2022-12-19 14:21:05 -08:00
test_lwt_bpf.c samples/bpf: use vmlinux.h instead of implicit headers in BPF test program 2023-01-15 13:32:45 -08:00
test_lwt_bpf.sh bpf: Replace deprecated -target with --target= for Clang 2023-06-29 15:46:17 +02:00
test_map_in_map.bpf.c samples/bpf: refactor syscall tracing programs using BPF_KSYSCALL macro 2023-08-21 15:39:10 -07:00
test_map_in_map_user.c samples/bpf: Use bpf_{btf,link,map,prog}_get_info_by_fd() 2023-02-16 15:32:45 -08:00
test_overhead_kprobe.bpf.c samples/bpf: make tracing programs to be more CO-RE centric 2023-08-21 15:39:09 -07:00
test_overhead_raw_tp.bpf.c samples/bpf: change _kern suffix to .bpf with BPF test programs 2023-01-15 13:32:45 -08:00
test_overhead_tp.bpf.c samples/bpf: convert to vmlinux.h with tracing programs 2023-08-21 15:39:09 -07:00
test_overhead_user.c samples/bpf: change _kern suffix to .bpf with BPF test programs 2023-01-15 13:32:45 -08:00
test_override_return.sh samples: bpf: Fix tracex7 error raised on the missing argument 2021-07-27 11:15:09 -07:00
test_probe_write_user.bpf.c samples/bpf: Use BPF_KSYSCALL macro in syscall tracing programs 2022-12-29 14:22:34 -08:00
test_probe_write_user_user.c samples/bpf: Change _kern suffix to .bpf with syscall tracing program 2022-12-29 14:22:34 -08:00
trace_event_kern.c bpf: Remove unused headers 2021-03-25 22:03:46 -07:00
trace_event_user.c bpf: samples: Do not touch RLIMIT_MEMLOCK 2020-12-02 18:32:47 -08:00
trace_output.bpf.c samples/bpf: Change _kern suffix to .bpf with syscall tracing program 2022-12-29 14:22:34 -08:00
trace_output_user.c samples/bpf: Change _kern suffix to .bpf with syscall tracing program 2022-12-29 14:22:34 -08:00
tracex1.bpf.c samples/bpf: make tracing programs to be more CO-RE centric 2023-08-21 15:39:09 -07:00
tracex1_user.c samples/bpf: unify bpf program suffix to .bpf with tracing programs 2023-08-21 15:39:09 -07:00
tracex2.bpf.c samples/bpf: Fix tracex2 by using BPF_KSYSCALL macro 2022-12-29 14:22:34 -08:00
tracex2_user.c samples/bpf: Change _kern suffix to .bpf with syscall tracing program 2022-12-29 14:22:34 -08:00
tracex3.bpf.c samples/bpf: fix bio latency check with tracepoint 2023-08-21 15:39:09 -07:00
tracex3_user.c samples/bpf: unify bpf program suffix to .bpf with tracing programs 2023-08-21 15:39:09 -07:00
tracex4.bpf.c samples/bpf: unify bpf program suffix to .bpf with tracing programs 2023-08-21 15:39:09 -07:00
tracex4_user.c samples/bpf: unify bpf program suffix to .bpf with tracing programs 2023-08-21 15:39:09 -07:00
tracex5.bpf.c samples/bpf: make tracing programs to be more CO-RE centric 2023-08-21 15:39:09 -07:00
tracex5_user.c samples/bpf: unify bpf program suffix to .bpf with tracing programs 2023-08-21 15:39:09 -07:00
tracex6.bpf.c samples/bpf: fix broken map lookup probe 2023-08-21 15:39:09 -07:00
tracex6_user.c samples/bpf: unify bpf program suffix to .bpf with tracing programs 2023-08-21 15:39:09 -07:00
tracex7.bpf.c samples/bpf: unify bpf program suffix to .bpf with tracing programs 2023-08-21 15:39:09 -07:00
tracex7_user.c samples/bpf: unify bpf program suffix to .bpf with tracing programs 2023-08-21 15:39:09 -07:00
xdp2skb_meta.sh samples/bpf: Fix tc and ip paths in xdp2skb_meta.sh 2018-07-10 09:19:01 +02:00
xdp2skb_meta_kern.c samples: bpf: Remove bpf_load loader completely 2020-11-26 19:33:36 -08:00
xdp_adjust_tail_kern.c samples/bpf: Use consistent include paths for libbpf 2020-01-20 16:37:45 -08:00
xdp_adjust_tail_user.c samples/bpf: Use bpf_{btf,link,map,prog}_get_info_by_fd() 2023-02-16 15:32:45 -08:00
xdp_fwd_kern.c samples/bpf: Use consistent include paths for libbpf 2020-01-20 16:37:45 -08:00
xdp_fwd_user.c samples/bpf: Use bpf_{btf,link,map,prog}_get_info_by_fd() 2023-02-16 15:32:45 -08:00
xdp_router_ipv4.bpf.c sample: bpf: xdp_router_ipv4: Allow the kernel to send arp requests 2022-06-02 16:26:54 -07:00
xdp_router_ipv4_user.c bpf: Replace bpf_lpm_trie_key 0-length array with flexible array 2024-08-19 06:04:27 +02:00
xdp_sample.bpf.c samples: bpf: Add BPF support for devmap_xmit tracepoint 2021-08-24 14:48:41 -07:00
xdp_sample.bpf.h samples/bpf: split common macros to net_shared.h 2023-01-15 13:32:45 -08:00
xdp_sample_shared.h samples: bpf: Add basic infrastructure for XDP samples 2021-08-24 14:48:40 -07:00
xdp_sample_user.c samples/bpf: Use libbpf 1.0 API mode instead of RLIMIT_MEMLOCK 2022-04-10 20:17:15 -07:00
xdp_sample_user.h samples/bpf: use preferred getters/setters instead of deprecated ones 2022-01-25 17:59:07 -08:00
xdp_tx_iptunnel_common.h treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 206 2019-05-30 11:29:53 -07:00
xdp_tx_iptunnel_kern.c samples/bpf: fixup some tools to be able to support xdp multibuffer 2022-06-21 18:55:53 -07:00
xdp_tx_iptunnel_user.c samples/bpf: Use bpf_{btf,link,map,prog}_get_info_by_fd() 2023-02-16 15:32:45 -08:00

README.rst

eBPF sample programs
====================

This directory contains a test stubs, verifier test-suite and examples
for using eBPF. The examples use libbpf from tools/lib/bpf.

Note that the XDP-specific samples have been removed from this directory and
moved to the xdp-tools repository: https://github.com/xdp-project/xdp-tools
See the commit messages removing each tool from this directory for how to
convert specific command invocations between the old samples and the utilities
in xdp-tools.

Build dependencies
==================

Compiling requires having installed:
 * clang
 * llvm
 * pahole

Consult :ref:`Documentation/process/changes.rst <changes>` for the minimum
version numbers required and how to update them. Note that LLVM's tool
'llc' must support target 'bpf', list version and supported targets with
command: ``llc --version``

Clean and configuration
-----------------------

It can be needed to clean tools, samples or kernel before trying new arch or
after some changes (on demand)::

 make -C tools clean
 make -C samples/bpf clean
 make clean

Configure kernel, defconfig for instance
(see "tools/testing/selftests/bpf/config" for a reference config)::

 make defconfig

Kernel headers
--------------

There are usually dependencies to header files of the current kernel.
To avoid installing devel kernel headers system wide, as a normal
user, simply call::

 make headers_install

This will create a local "usr/include" directory in the git/build top
level directory, that the make system will automatically pick up first.

Compiling
=========

For building the BPF samples, issue the below command from the kernel
top level directory::

 make M=samples/bpf

It is also possible to call make from this directory.  This will just
hide the invocation of make as above.

Manually compiling LLVM with 'bpf' support
------------------------------------------

Since version 3.7.0, LLVM adds a proper LLVM backend target for the
BPF bytecode architecture.

By default llvm will build all non-experimental backends including bpf.
To generate a smaller llc binary one can use::

 -DLLVM_TARGETS_TO_BUILD="BPF"

We recommend that developers who want the fastest incremental builds
use the Ninja build system, you can find it in your system's package
manager, usually the package is ninja or ninja-build.

Quick sniplet for manually compiling LLVM and clang
(build dependencies are ninja, cmake and gcc-c++)::

 $ git clone https://github.com/llvm/llvm-project.git
 $ mkdir -p llvm-project/llvm/build
 $ cd llvm-project/llvm/build
 $ cmake .. -G "Ninja" -DLLVM_TARGETS_TO_BUILD="BPF;X86" \
            -DLLVM_ENABLE_PROJECTS="clang"    \
            -DCMAKE_BUILD_TYPE=Release        \
            -DLLVM_BUILD_RUNTIME=OFF
 $ ninja

It is also possible to point make to the newly compiled 'llc' or
'clang' command via redefining LLC or CLANG on the make command line::

 make M=samples/bpf LLC=~/git/llvm-project/llvm/build/bin/llc CLANG=~/git/llvm-project/llvm/build/bin/clang

Cross compiling samples
-----------------------
In order to cross-compile, say for arm64 targets, export CROSS_COMPILE and ARCH
environment variables before calling make. But do this before clean,
configuration and header install steps described above. This will direct make to
build samples for the cross target::

 export ARCH=arm64
 export CROSS_COMPILE="aarch64-linux-gnu-"

Headers can be also installed on RFS of target board if need to keep them in
sync (not necessarily and it creates a local "usr/include" directory also)::

 make INSTALL_HDR_PATH=~/some_sysroot/usr headers_install

Pointing LLC and CLANG is not necessarily if it's installed on HOST and have
in its targets appropriate arm64 arch (usually it has several arches).
Build samples::

 make M=samples/bpf

Or build samples with SYSROOT if some header or library is absent in toolchain,
say libelf, providing address to file system containing headers and libs,
can be RFS of target board::

 make M=samples/bpf SYSROOT=~/some_sysroot