Dave Jones 020318d0d2 irda: fix locking unbalance in irda_sendmsg ... 5b40964ead ("irda: Remove BKL instances from af_irda.c") introduced a path where we have a locking unbalance. If we pass invalid flags, we unlock a socket we never locked, resulting in this... ===================================== [ BUG: bad unlock balance detected! ] ------------------------------------- trinity/20101 is trying to release lock (sk_lock-AF_IRDA) at: [<ffffffffa057f001>] irda_sendmsg+0x207/0x21d [irda] but there are no more locks to release! other info that might help us debug this: no locks held by trinity/20101. stack backtrace: Pid: 20101, comm: trinity Not tainted 2.6.39-rc3+ #3 Call Trace: [<ffffffffa057f001>] ? irda_sendmsg+0x207/0x21d [irda] [<ffffffff81085041>] print_unlock_inbalance_bug+0xc7/0xd2 [<ffffffffa057f001>] ? irda_sendmsg+0x207/0x21d [irda] [<ffffffff81086aca>] lock_release+0xcf/0x18e [<ffffffff813ed190>] release_sock+0x2d/0x155 [<ffffffffa057f001>] irda_sendmsg+0x207/0x21d [irda] [<ffffffff813e9f8c>] __sock_sendmsg+0x69/0x75 [<ffffffff813ea105>] sock_sendmsg+0xa1/0xb6 [<ffffffff81100ca3>] ? might_fault+0x5c/0xac [<ffffffff81086b7c>] ? lock_release+0x181/0x18e [<ffffffff81100cec>] ? might_fault+0xa5/0xac [<ffffffff81100ca3>] ? might_fault+0x5c/0xac [<ffffffff81133b94>] ? fcheck_files+0xb9/0xf0 [<ffffffff813f387a>] ? copy_from_user+0x2f/0x31 [<ffffffff813f3b70>] ? verify_iovec+0x52/0xa6 [<ffffffff813eb4e3>] sys_sendmsg+0x23a/0x2b8 [<ffffffff81086b7c>] ? lock_release+0x181/0x18e [<ffffffff810773c6>] ? up_read+0x28/0x2c [<ffffffff814bec3d>] ? do_page_fault+0x360/0x3b4 [<ffffffff81087043>] ? trace_hardirqs_on_caller+0x10b/0x12f [<ffffffff810458aa>] ? finish_task_switch+0xb2/0xe3 [<ffffffff8104583e>] ? finish_task_switch+0x46/0xe3 [<ffffffff8108364a>] ? trace_hardirqs_off_caller+0x33/0x90 [<ffffffff814bbaf9>] ? retint_swapgs+0x13/0x1b [<ffffffff81087043>] ? trace_hardirqs_on_caller+0x10b/0x12f [<ffffffff810a9dd3>] ? audit_syscall_entry+0x11c/0x148 [<ffffffff8125609e>] ? trace_hardirqs_on_thunk+0x3a/0x3f [<ffffffff814c22c2>] system_call_fastpath+0x16/0x1b Signed-off-by: Dave Jones <davej@redhat.com> Signed-off-by: David S. Miller <davem@davemloft.net>		2011-04-12 15:29:54 -07:00
..
ircomm	tty: now phase out the ioctl file pointer for good	2011-02-17 11:59:56 -08:00
irlan	Net: irda: irlan: Makefile: Remove deprecated kbuild goal definitions	2010-11-22 08:16:13 -08:00
irnet	Fix common misspellings	2011-03-31 11:26:23 -03:00
Kconfig	[S390] Kconfig: unwanted menus for s390.	2007-05-10 15:46:07 +02:00
Makefile	[IrDA]: Netlink layer.	2007-07-10 22:16:43 -07:00
af_irda.c	irda: fix locking unbalance in irda_sendmsg	2011-04-12 15:29:54 -07:00
discovery.c	net: return operator cleanup	2010-09-23 14:33:39 -07:00
irda_device.c	include cleanup: Update gfp.h and slab.h includes to prepare for breaking implicit slab.h inclusion from percpu.h	2010-03-30 22:02:32 +09:00
iriap.c	irda: validate peer name and attribute lengths	2011-03-27 17:59:02 -07:00
iriap_event.c	include cleanup: Update gfp.h and slab.h includes to prepare for breaking implicit slab.h inclusion from percpu.h	2010-03-30 22:02:32 +09:00
irias_object.c	include cleanup: Update gfp.h and slab.h includes to prepare for breaking implicit slab.h inclusion from percpu.h	2010-03-30 22:02:32 +09:00
irlap.c	Fix common misspellings	2011-03-31 11:26:23 -03:00
irlap_event.c	Fix common misspellings	2011-03-31 11:26:23 -03:00
irlap_frame.c	Fix common misspellings	2011-03-31 11:26:23 -03:00
irlmp.c	net: return operator cleanup	2010-09-23 14:33:39 -07:00
irlmp_event.c	Fix common misspellings	2011-03-31 11:26:23 -03:00
irlmp_frame.c	net: return operator cleanup	2010-09-23 14:33:39 -07:00
irmod.c	net: convert usage of packet_type to read_mostly	2009-03-10 05:22:43 -07:00
irnetlink.c	include cleanup: Update gfp.h and slab.h includes to prepare for breaking implicit slab.h inclusion from percpu.h	2010-03-30 22:02:32 +09:00
irproc.c	net: file_operations should be const	2009-09-02 01:03:53 -07:00
irqueue.c	Fix common misspellings	2011-03-31 11:26:23 -03:00
irsysctl.c	sysctl net: Remove unused binary sysctl code	2009-11-12 02:05:06 -08:00
irttp.c	Fix common misspellings	2011-03-31 11:26:23 -03:00
parameters.c	irda: Fix parameter extraction stack overflow	2010-10-11 02:12:17 +02:00
qos.c	Fix common misspellings	2011-03-31 11:26:23 -03:00
timer.c	Fix common misspellings	2011-03-31 11:26:23 -03:00
wrapper.c	net: replace remaining __FUNCTION__ occurrences	2008-03-05 20:47:47 -08:00