Borislav Petkov (AMD) 49ce8b6297 kbuild: Disable KCSAN for autogenerated *.mod.c intermediaries ... [ Upstream commit 54babdc0343fff2f32dfaafaaa9e42c4db278204 ] When KCSAN and CONSTRUCTORS are enabled, one can trigger the "Unpatched return thunk in use. This should not happen!" catch-all warning. Usually, when objtool runs on the .o objects, it does generate a section .return_sites which contains all offsets in the objects to the return thunks of the functions present there. Those return thunks then get patched at runtime by the alternatives. KCSAN and CONSTRUCTORS add this to the object file's .text.startup section: ------------------- Disassembly of section .text.startup: ... 0000000000000010 <_sub_I_00099_0>: 10: f3 0f 1e fa endbr64 14: e8 00 00 00 00 call 19 <_sub_I_00099_0+0x9> 15: R_X86_64_PLT32 __tsan_init-0x4 19: e9 00 00 00 00 jmp 1e <__UNIQUE_ID___addressable_cryptd_alloc_aead349+0x6> 1a: R_X86_64_PLT32 __x86_return_thunk-0x4 ------------------- which, if it is built as a module goes through the intermediary stage of creating a <module>.mod.c file which, when translated, receives a second constructor: ------------------- Disassembly of section .text.startup: 0000000000000010 <_sub_I_00099_0>: 10: f3 0f 1e fa endbr64 14: e8 00 00 00 00 call 19 <_sub_I_00099_0+0x9> 15: R_X86_64_PLT32 __tsan_init-0x4 19: e9 00 00 00 00 jmp 1e <_sub_I_00099_0+0xe> 1a: R_X86_64_PLT32 __x86_return_thunk-0x4 ... 0000000000000030 <_sub_I_00099_0>: 30: f3 0f 1e fa endbr64 34: e8 00 00 00 00 call 39 <_sub_I_00099_0+0x9> 35: R_X86_64_PLT32 __tsan_init-0x4 39: e9 00 00 00 00 jmp 3e <__ksymtab_cryptd_alloc_ahash+0x2> 3a: R_X86_64_PLT32 __x86_return_thunk-0x4 ------------------- in the .ko file. Objtool has run already so that second constructor's return thunk cannot be added to the .return_sites section and thus the return thunk remains unpatched and the warning rightfully fires. Drop KCSAN flags from the mod.c generation stage as those constructors do not contain data races one would be interested about. Debugged together with David Kaplan <David.Kaplan@amd.com> and Nikolay Borisov <nik.borisov@suse.com>. Reported-by: Paul Menzel <pmenzel@molgen.mpg.de> Closes: https://lore.kernel.org/r/0851a207-7143-417e-be31-8bf2b3afb57d@molgen.mpg.de Signed-off-by: Borislav Petkov (AMD) <bp@alien8.de> Tested-by: Paul Menzel <pmenzel@molgen.mpg.de> # Dell XPS 13 Reviewed-by: Nikolay Borisov <nik.borisov@suse.com> Reviewed-by: Marco Elver <elver@google.com> Signed-off-by: Masahiro Yamada <masahiroy@kernel.org> Signed-off-by: Sasha Levin <sashal@kernel.org>		2024-05-17 12:02:12 +02:00
..
atomic	locking/atomic: scripts: fix fallback ifdeffery	2023-09-20 09:39:03 +02:00
basic	kbuild: implement CONFIG_TRIM_UNUSED_KSYMS without recursion	2023-06-22 21:21:06 +09:00
clang-tools	gen_compile_commands: fix invalid escape sequence warning	2024-03-26 18:19:11 -04:00
coccinelle	Revert "debugfs, coccinelle: check for obsolete DEFINE_SIMPLE_ATTRIBUTE() usage"	2023-07-29 11:05:31 -04:00
dtc	dt: dt-extract-compatibles: Don't follow symlinks when walking tree	2023-12-13 18:45:03 +01:00
dummy-tools	kbuild: dummy-tools: make MPROFILE_KERNEL checks work on BE	2023-09-01 16:38:04 +09:00
gcc-plugins	gcc-plugins/stackleak: Avoid .head.text section	2024-04-13 13:07:40 +02:00
gdb	scripts/gdb: fix lx-device-list-bus and lx-device-list-class	2023-12-13 18:45:19 +01:00
genksyms	genksyms: adjust the output format to modpost	2022-05-24 16:33:20 +09:00
kconfig	kconfig: fix infinite loop when expanding a macro at the end of file	2024-03-26 18:20:05 -04:00
ksymoops	…
mod	modpost: fix null pointer dereference	2024-04-13 13:07:39 +02:00
package	kbuild: remove stale code for 'source' symlink in packaging scripts	2023-10-01 23:06:06 +09:00
selinux	selinux: remove runtime disable message in the install_policy.sh script	2022-09-20 14:12:25 -04:00
tracing	tracing: Always use canonical ftrace path	2023-02-18 14:34:09 -05:00
.gitignore	rust: support running Rust documentation tests as KUnit ones	2023-07-19 09:32:53 -06:00
Kbuild.include	kbuild: replace $(dot-target).tmp in filechk with $(tmp-target)	2023-01-22 23:43:33 +09:00
Kconfig.include	kbuild: Add -Wa,--fatal-warnings to as-instr invocation	2024-03-06 14:48:41 +00:00
Lindent	…
Makefile	rust: support running Rust documentation tests as KUnit ones	2023-07-19 09:32:53 -06:00
Makefile.asm-generic	kbuild: add kbuild-file macro	2022-11-22 23:40:02 +09:00
Makefile.build	kbuild: rust: force `alloc` extern to allow "empty" Rust files	2024-05-02 16:32:42 +02:00
Makefile.clang	Kbuild updates for v6.5	2023-07-01 09:24:31 -07:00
Makefile.clean	kbuild: make clean rule robust against too long argument error	2023-06-25 23:12:20 +09:00
Makefile.compiler	kbuild: Add -Wa,--fatal-warnings to as-instr invocation	2024-03-06 14:48:41 +00:00
Makefile.debug	Makefile.debug: support for -gz=zstd	2022-11-21 10:18:39 +09:00
Makefile.defconf	kbuild: Provide a version of merge_into_defconfig without override warnings	2023-02-13 20:18:28 +01:00
Makefile.dtbinst	kbuild: Support flat DTBs install	2023-06-21 07:51:08 -06:00
Makefile.extrawarn	kbuild: Move -Wenum-{compare-conditional,enum-conversion} into W=1	2024-04-03 15:28:29 +02:00
Makefile.gcc-plugins	gcc-plugins: Undefine LATENT_ENTROPY_PLUGIN when plugin disabled for a file	2022-08-16 12:25:53 -07:00
Makefile.headersinst	…
Makefile.host	kbuild: rust: avoid creating temporary files	2023-07-24 03:15:31 +09:00
Makefile.kasan	kasan: remove hwasan-kernel-mem-intrinsic-prefix=1 for clang-14	2023-04-18 16:29:43 -07:00
Makefile.kcov	…
Makefile.kcsan	kcsan: Ignore GCC 11+ warnings about TSan runtime support	2021-12-09 16:42:27 -08:00
Makefile.kmsan	kmsan: add KMSAN runtime core	2022-10-03 14:03:19 -07:00
Makefile.lib	kbuild: Disallow DTB overlays to built from .dts named source files	2023-05-22 10:34:37 +09:00
Makefile.modfinal	kbuild: Disable KCSAN for autogenerated *.mod.c intermediaries	2024-05-17 12:02:12 +02:00
Makefile.modinst	kbuild: Use CRC32 and a 1MiB dictionary for XZ compressed modules	2023-09-25 16:01:05 +09:00
Makefile.modpost	linux/export.h: make <linux/export.h> independent of CONFIG_MODULES	2023-07-25 00:59:32 +09:00
Makefile.package	kbuild: deb-pkg: support DEB_BUILD_OPTIONS=parallel=N in debian/rules	2023-08-29 22:29:35 +09:00
Makefile.randstruct	randstruct: Enable Clang support	2022-05-08 01:33:07 -07:00
Makefile.ubsan	ubsan: Tighten UBSAN_BOUNDS on GCC	2023-05-16 13:57:14 -07:00
Makefile.userprogs	…
Makefile.vmlinux	x86/retpoline: Make sure there are no unconverted return thunks due to KCSAN	2023-11-28 17:19:36 +00:00
Makefile.vmlinux_o	x86/srso: Fix unret validation dependencies	2023-11-20 11:58:52 +01:00
as-version.sh	kbuild: Update assembler calls to use proper flags and language target	2023-01-26 12:41:38 +09:00
asn1_compiler.c	ASN.1: Fix check for strdup() success	2023-04-21 08:58:00 -07:00
bloat-o-meter	scripts/bloat-o-meter: count weak symbol sizes	2023-08-21 13:46:25 -07:00
bootgraph.pl	…
bpf_doc.py	scripts/bpf_doc: Use silent mode when exec make cmd	2024-04-10 16:35:40 +02:00
cc-can-link.sh	…
cc-version.sh	scripts: Remove ICC-related dead code	2023-04-24 10:18:32 -07:00
check-git	kbuild: use git-archive for source package creation	2023-03-16 22:46:12 +09:00
check-sysctl-docs	sysctl: Remove register_sysctl_table	2023-05-23 21:43:26 -07:00
check_extable.sh	scripts: check_extable: fix typo in user error message	2021-09-08 11:50:28 -07:00
checkdeclares.pl	scripts: make some scripts executable	2021-08-10 09:13:25 +09:00
checkincludes.pl	…
checkkconfigsymbols.py	scripts: handle BrokenPipeError for python scripts	2023-01-26 12:43:33 +09:00
checkpatch.pl	- An extensive rework of kexec and crash Kconfig from Eric DeVolder	2023-08-29 14:53:51 -07:00
checkstack.pl	scripts/checkstack.pl: match all stack sizes for s390	2023-12-20 17:01:59 +01:00
checksyscalls.sh	checksyscalls: ignore fstat to silence build warning on LoongArch	2023-03-23 17:18:32 -07:00
checkversion.pl	scripts: checkversion: modernize linux/version.h search strings	2021-08-05 20:55:39 +09:00
cleanfile	…
cleanpatch	…
coccicheck	scripts: coccicheck: Use /usr/bin/env	2023-02-25 20:11:06 +01:00
config	…
const_structs.checkpatch	const_structs.checkpatch.pl: add kobj_type	2023-02-08 13:33:29 +01:00
decode_stacktrace.sh	scripts/decode_stacktrace.sh: optionally use LLVM utilities	2024-01-20 11:51:49 +01:00
decodecode	scripts/decodecode: Add support for RISC-V	2023-02-21 16:53:54 -08:00
depmod.sh	kbuild: move depmod rule to scripts/Makefile.modinst	2023-08-29 22:38:23 +09:00
dev-needs.sh	…
diffconfig	scripts: handle BrokenPipeError for python scripts	2023-01-26 12:43:33 +09:00
documentation-file-ref-check	scripts: documentation-file-ref-check: fix bpf selftests path	2021-10-26 09:42:29 -06:00
export_report.pl	…
extract-ikconfig	scripts/extract-ikconfig: add zstd compression support	2022-08-29 13:58:47 +09:00
extract-module-sig.pl	…
extract-sys-certs.pl	…
extract-vmlinux	…
extract_xc3028.pl	…
faddr2line	scripts/faddr2line: Fix regression in name resolution on ppc64le	2022-11-16 10:42:10 +01:00
file-size.sh	…
find-unused-docs.sh	…
gcc-x86_32-has-stack-protector.sh	…
gcc-x86_64-has-stack-protector.sh	…
gen-randstruct-seed.sh	randstruct: Move seed generation into scripts/basic/	2022-05-08 01:33:07 -07:00
generate_initcall_order.pl	…
generate_rust_analyzer.py	scripts: generate_rust_analyzer: provide `cfg`s for `core` and `alloc`	2023-08-20 22:54:32 +02:00
generate_rust_target.rs	x86: enable initial Rust support	2022-09-28 09:02:45 +02:00
get_abi.pl	scripts/get_abi: fix source path leak	2024-01-31 16:18:55 -08:00
get_dvb_firmware	…
get_feat.pl	scripts: get_feat.pl: use /usr/bin/env to find perl	2022-06-30 12:22:17 -06:00
get_maintainer.pl	get_maintainer: Honor mailmap for in file emails	2022-04-29 14:38:00 -07:00
gfp-translate	scripts: fix the gfp flags header path in gfp-translate	2023-06-19 13:19:32 -07:00
head-object-list.txt	powerpc/64: Rename entry_64.S to prom_entry_64.S	2023-06-15 14:04:19 +10:00
headerdep.pl	…
headers_install.sh	x86: Remove the arch_calc_vm_prot_bits() macro from the UAPI	2023-09-06 23:50:46 +02:00
insert-sys-cert.c	…
install.sh	kbuild: factor out the common installation code into scripts/install.sh	2022-05-11 21:45:53 +09:00
jobserver-exec	scripts: support GNU make 4.4 in jobserver-exec	2023-01-16 20:15:20 +09:00
kallsyms.c	scripts/kallsyms: Fix build failure by setting errno before calling getline()	2023-07-29 15:57:32 +09:00
kernel-doc	scripts: kernel-doc: fix macro handling in enums	2023-08-18 11:14:08 -06:00
ld-version.sh	…
leaking_addresses.pl	leaking_addresses: also skip canonical ftrace path	2023-03-29 06:52:08 -04:00
link-vmlinux.sh	kbuild: Fix changing ELF file type for output of gen_btf for big endian	2024-02-23 09:25:02 +01:00
makelst	…
markup_oops.pl	…
min-tool-version.sh	rust: upgrade to Rust 1.73.0	2024-02-16 19:10:43 +01:00
misc-check	kbuild: make W=1 warn files that are tracked but ignored by git	2023-01-22 23:43:33 +09:00
mkcompile_h	Revert "kbuild: Make scripts/compile.h when sh != bash"	2022-09-29 04:40:15 +09:00
mksysmap	kallsyms: ignore ARMv4 thunks along with others	2024-02-23 09:24:59 +01:00
mkuboot.sh	…
module.lds.S	arm64: unwind: add asynchronous unwind tables to kernel and modules	2022-11-09 18:06:35 +00:00
modules-check.sh	kbuild: change module.order to list *.o instead of *.ko	2022-12-14 15:42:40 +09:00
nsdeps	scripts/nsdeps: adjust to the format change of *.mod files	2022-06-08 20:14:13 +09:00
objdiff	kbuild: clean .tmp_* pattern by make clean	2022-06-05 06:20:57 +09:00
objdump-func	scripts/objdump-func: Support multiple functions	2023-04-14 16:08:28 +02:00
orc_hash.sh	x86/unwind/orc: Add ELF section with ORC version identifier	2023-06-16 17:17:42 +02:00
pahole-flags.sh	bpf: Add --skip_encoding_btf_inconsistent_proto, --btf_gen_optimized to pahole flags for v1.25	2023-05-12 11:47:05 -07:00
pahole-version.sh	kbuild: Add CONFIG_PAHOLE_VERSION	2022-02-02 11:19:33 +01:00
parse-maintainers.pl	…
patch-kernel	…
profile2linkerlist.pl	…
prune-kernel	scripts/prune-kernel: Use kernel-install if available	2022-05-11 21:46:38 +09:00
recordmcount.c	recordmcount: Fix memory leaks in the uwrite function	2023-04-25 21:10:20 -04:00
recordmcount.h	…
recordmcount.pl	nds32: Remove the architecture	2022-03-07 13:54:59 +01:00
relocs_check.sh	powerpc: Move script to check relocations at compile time in scripts/	2023-04-19 07:46:31 -07:00
remove-stale-files	kbuild: rpm-pkg: rename binkernel.spec to kernel.spec	2023-07-25 00:59:33 +09:00
rust_is_available.sh	kbuild: rust_is_available: check that output looks as expected	2023-08-10 01:18:34 +02:00
rust_is_available_bindgen_libclang.h	scripts: add `rust_is_available.sh`	2022-09-28 09:02:06 +02:00
rust_is_available_test.py	kbuild: rust_is_available: add test suite	2023-08-10 01:18:34 +02:00
rustdoc_test_builder.rs	rust: support running Rust documentation tests as KUnit ones	2023-07-19 09:32:53 -06:00
rustdoc_test_gen.rs	rust: support running Rust documentation tests as KUnit ones	2023-07-19 09:32:53 -06:00
setlocalversion	scripts/setlocalversion: also consider annotated tags of the form vx.y.z-${file_localversion}	2023-08-08 01:08:54 +09:00
show_delta	…
sign-file.c	sign-file: Fix incorrect return values check	2023-12-20 17:01:49 +01:00
sorttable.c	LoongArch: extable: Add `type` and `data` fields	2022-12-14 08:36:11 +08:00
sorttable.h	x86,objtool: Split UNWIND_HINT_EMPTY in two	2023-03-23 23:18:58 +01:00
spdxcheck-test.sh	docs: move Linux logo into a new `images` folder	2022-06-01 09:32:45 -06:00
spdxcheck.py	scripts/spdxcheck: Put excluded files and directories into a separate file	2022-05-18 15:34:33 +02:00
spdxexclude	scripts/spdxcheck: Exclude top-level README	2022-05-18 15:35:42 +02:00
spelling.txt	scripts/spelling.txt: remove 'thead' as a typo	2023-07-27 13:07:04 -07:00
sphinx-pre-install	docs: sphinx-pre-install: don't require the RTD theme	2022-10-13 11:14:43 -06:00
split-man.pl	…
stackdelta	…
stackusage	…
subarch.include	LoongArch: Add build infrastructure	2022-06-03 20:09:27 +08:00
syscallhdr.sh	…
syscallnr.sh	scripts: make some scripts executable	2021-08-10 09:13:25 +09:00
syscalltbl.sh	…
tags.sh	Char/Misc and other driver subsystem updates for 6.5-rc1	2023-07-03 12:46:47 -07:00
test_fortify.sh	fortify: Update compile-time tests for Clang 14	2022-02-13 16:50:06 -08:00
tools-support-relr.sh	Makefile: use -z pack-relative-relocs	2023-04-17 11:23:06 +09:00
unifdef.c	…
ver_linux	…
xen-hypercalls.sh	scripts: make some scripts executable	2021-08-10 09:13:25 +09:00
xz_wrap.sh	…