OpenCloudOS-Kernel/fs/notify/fanotify
Miklos Szeredi f37650f1c7 fanotify: fix fsnotify_prepare_user_wait() failure
If fsnotify_prepare_user_wait() fails, we leave the event on the
notification list.  Which will result in a warning in
fsnotify_destroy_event() and later use-after-free.

Instead of adding a new helper to remove the event from the list in this
case, I opted to move the prepare/finish up into fanotify_handle_event().

This will allow these to be moved further out into the generic code later,
and perhaps let us move to non-sleeping RCU.

Reviewed-by: Amir Goldstein <amir73il@gmail.com>
Signed-off-by: Miklos Szeredi <mszeredi@redhat.com>
Fixes: 05f0e38724 ("fanotify: Release SRCU lock when waiting for userspace response")
Cc: <stable@vger.kernel.org> # v4.12
Signed-off-by: Jan Kara <jack@suse.cz>
2017-10-31 17:54:56 +01:00
..
Kconfig treewide: fix typo of "suport" in various comments and Kconfig 2012-11-19 14:16:09 +01:00
Makefile fanotify: fanotify_init syscall declaration 2010-07-28 09:58:55 -04:00
fanotify.c fanotify: fix fsnotify_prepare_user_wait() failure 2017-10-31 17:54:56 +01:00
fanotify.h fsnotify: Move ->free_mark callback to fsnotify_ops 2017-04-10 17:37:36 +02:00
fanotify_user.c fanotify: don't expose EOPENSTALE to userspace 2017-04-25 15:48:06 +02:00