Lukas Wunner 32e5b57232 spi: pxa2xx: Fix controller unregister order ... The PXA2xx SPI driver uses devm_spi_register_controller() on bind. As a consequence, on unbind, __device_release_driver() first invokes pxa2xx_spi_remove() before unregistering the SPI controller via devres_release_all(). This order is incorrect: pxa2xx_spi_remove() disables the chip, rendering the SPI bus inaccessible even though the SPI controller is still registered. When the SPI controller is subsequently unregistered, it unbinds all its slave devices. Because their drivers cannot access the SPI bus, e.g. to quiesce interrupts, the slave devices may be left in an improper state. As a rule, devm_spi_register_controller() must not be used if the ->remove() hook performs teardown steps which shall be performed after unregistering the controller and specifically after unbinding of slaves. Fix by reverting to the non-devm variant of spi_register_controller(). An alternative approach would be to use device-managed functions for all steps in pxa2xx_spi_remove(), e.g. by calling devm_add_action_or_reset() on probe. However that approach would add more LoC to the driver and it wouldn't lend itself as well to backporting to stable. The improper use of devm_spi_register_controller() was introduced in 2013 by commit a807fcd090 ("spi: pxa2xx: use devm_spi_register_master()"), but all earlier versions of the driver going back to 2006 were likewise broken because they invoked spi_unregister_master() at the end of pxa2xx_spi_remove(), rather than at the beginning. Fixes: e0c9905e87 ("[PATCH] SPI: add PXA2xx SSP SPI Driver") Signed-off-by: Lukas Wunner <lukas@wunner.de> Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> Cc: stable@vger.kernel.org # v2.6.17+ Cc: Tsuchiya Yuto <kitakar@gmail.com> Link: https://bugzilla.kernel.org/show_bug.cgi?id=206403#c1 Link: https://lore.kernel.org/r/834c446b1cf3284d2660f1bee1ebe3e737cd02a9.1590408496.git.lukas@wunner.de Signed-off-by: Mark Brown <broonie@kernel.org>		2020-05-26 15:40:30 +01:00
..
accessibility	…
acpi	ACPI fixes for 5.6-rc4	2020-02-28 09:02:18 -08:00
amba	…
android	for-5.6/io_uring-vfs-2020-01-29	2020-01-29 18:53:37 -08:00
ata	libata-5.6-2020-02-05	2020-02-06 06:11:50 +00:00
atm	Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net-next	2020-01-28 16:02:33 -08:00
auxdisplay	…
base	ARM: SoC-related driver updates	2020-02-08 14:04:19 -08:00
bcma	Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net-next	2020-01-28 16:02:33 -08:00
block	SCSI fixes on 20200229	2020-02-29 09:58:47 -06:00
bluetooth	Bluetooth: btrtl: Use kvmalloc for FW allocations	2020-01-24 19:57:53 +01:00
bus	bus: moxtet: fix potential stack buffer overflow	2020-02-15 10:33:19 -08:00
cdrom	scsi: compat_ioctl: cdrom: Replace .ioctl with .compat_ioctl in four appropriate places	2020-02-24 15:06:07 -05:00
char	tpm: Initialize crypto_id of allocated_banks to HASH_ALGO__LAST	2020-02-17 20:47:06 +02:00
clk	ARM: SoC: late updates	2020-02-08 14:17:27 -08:00
clocksource	ARM: SoC: late updates	2020-02-08 14:17:27 -08:00
connector	…
counter	…
cpufreq	cpufreq: Fix policy initialization for internal governor drivers	2020-02-27 08:57:48 +01:00
cpuidle	ARM: SoC-related driver updates	2020-02-08 14:04:19 -08:00
crypto	Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net-next	2020-01-28 16:02:33 -08:00
dax	dax: Get rid of fs_dax_get_by_host() helper	2020-01-16 09:52:27 -08:00
dca	…
devfreq	Revert "PM / devfreq: Modify the device name as devfreq(X) for sysfs"	2020-02-24 11:14:29 +09:00
dio	…
dma	ARM: Device-tree updates	2020-02-08 13:58:44 -08:00
dma-buf	…
edac	EDAC/sysfs: Remove csrow objects on errors	2020-02-13 13:29:41 +01:00
eisa	…
extcon	…
firewire	…
firmware	efi: READ_ONCE rng seed size before munmap	2020-02-26 15:31:43 +01:00
fpga	…
fsi	fsi: aspeed: add unspecified HAS_IOMEM dependency	2020-02-10 13:45:49 -08:00
gnss	…
gpio	gpio: sifive: fix static checker warning	2020-02-10 13:54:17 +01:00
gpu	drm/i915 fixes for v5.6-rc4:	2020-02-28 12:40:49 +10:00
greybus	…
hid	Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/hid/hid	2020-02-27 11:13:27 -08:00
hsi	…
hv	- Most of the commits here are work to enable host-initiated hibernation	2020-02-03 14:42:03 +00:00
hwmon	hwmon: (w83627ehf) Fix crash seen with W83627DHG-P	2020-02-21 09:16:24 -08:00
hwspinlock	hwspinlock: sirf: Use devm_hwspin_lock_register() to register hwlock controller	2020-01-21 16:16:36 -08:00
hwtracing	coresight: etm4x: Fix unused function warning	2020-01-14 15:38:28 +01:00
i2c	i2c: altera: Fix potential integer overflow	2020-02-13 09:29:30 +01:00
i3c	…
ide	scsi: compat_ioctl: cdrom: Replace .ioctl with .compat_ioctl in four appropriate places	2020-02-24 15:06:07 -05:00
idle	intel_idle: Introduce 'states_off' module parameter	2020-02-03 11:57:18 +01:00
iio	chrome platform changes for 5.6	2020-02-04 07:17:41 +00:00
infiniband	SCSI fixes on 20200221	2020-02-22 11:00:52 -08:00
input	Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/dtor/input	2020-02-15 16:49:25 -08:00
interconnect	…
iommu	iommu/arm-smmu: Restore naming of driver parameter prefix	2020-02-19 12:03:21 +01:00
ipack	…
irqchip	irqchip/gic-v4.1: Avoid 64bit division for the sake of 32bit ARM	2020-02-09 15:47:37 -08:00
isdn	proc: convert everything to "struct proc_ops"	2020-02-04 03:05:26 +00:00
leds	leds: lm3532: add pointer to documentation and fix typo	2020-01-22 21:08:24 +01:00
lightnvm	…
macintosh	macintosh: therm_windtunnel: fix regression when instantiating devices	2020-02-29 21:13:22 +01:00
mailbox	…
mcb	…
md	block-5.6-2020-02-16	2020-02-16 12:35:52 -08:00
media	chrome platform changes for 5.6	2020-02-04 07:17:41 +00:00
memory	mvebu drivers for 5.6 (part 1)	2020-01-16 10:45:44 -08:00
memstick	…
message	Merge ra.kernel.org:/pub/scm/linux/kernel/git/netdev/net	2020-01-19 22:10:04 +01:00
mfd	chrome platform changes for 5.6	2020-02-04 07:17:41 +00:00
misc	habanalabs: patched cb equals user cb in device memset	2020-02-11 11:12:47 +02:00
mmc	ioremap changes for 5.6	2020-01-27 13:03:00 -08:00
mtd	mtd: spi-nor: remove mtk-quadspi driver	2020-03-11 19:56:08 +00:00
mux	…
net	net: dsa: mv88e6xxx: Fix masking of egress port	2020-02-27 12:29:09 -08:00
nfc	nfc: pn544: Fix occasional HW initialization failure	2020-02-19 11:09:27 -08:00
ntb	…
nubus	…
nvdimm	mm: Cleanup __put_devmap_managed_page() vs ->page_free()	2020-01-31 10:30:37 -08:00
nvme	nvme-pci: Hold cq_poll_lock while completing CQEs	2020-02-28 01:32:14 +09:00
nvmem	Merge branch 'i2c/for-5.6' of git://git.kernel.org/pub/scm/linux/kernel/git/wsa/linux	2020-02-07 12:54:13 -08:00
of	ARM: SoC-related driver updates	2020-02-08 14:04:19 -08:00
opp	ioremap changes for 5.6	2020-01-27 13:03:00 -08:00
oprofile	…
parisc	proc: convert everything to "struct proc_ops"	2020-02-04 03:05:26 +00:00
parport	…
pci	PCI: brcmstb: Fix build on 32bit ARM platforms with older compilers	2020-02-27 08:06:20 -06:00
pcmcia	…
perf	perf/smmuv3: Use platform_get_irq_optional() for wired interrupt	2020-02-10 18:14:46 +00:00
phy	treewide: remove redundant IS_ERR() before error code check	2020-02-04 03:05:27 +00:00
pinctrl	pinctrl: fix pxa2xx.c build warnings	2020-02-04 03:05:24 +00:00
platform	platform/chrome: wilco_ec: Include asm/unaligned instead of linux/ path	2020-02-11 09:10:36 +01:00
pnp	proc: convert everything to "struct proc_ops"	2020-02-04 03:05:26 +00:00
power	ARM: SoC platform updates	2020-02-08 13:55:25 -08:00
powercap	…
pps	…
ps3	…
ptp	Merge ra.kernel.org:/pub/scm/linux/kernel/git/netdev/net	2020-01-19 22:10:04 +01:00
pwm	pwm: Remove set but not set variable 'pwm'	2020-01-20 15:40:49 +01:00
rapidio	…
ras	…
regulator	regulator: anatop: Lower error message level for -EPROBE_DEFER	2020-03-03 14:31:48 +00:00
remoteproc	remoteproc: qcom: q6v5-mss: Improve readability of reset_assert	2020-01-24 09:34:07 -08:00
reset	…
rpmsg	rpmsg: add rpmsg support for mt8183 SCP.	2020-01-20 10:29:56 -08:00
rtc	chrome platform changes for 5.6	2020-02-04 07:17:41 +00:00
s390	SCSI fixes on 20200229	2020-02-29 09:58:47 -06:00
sbus	…
scsi	scsi: compat_ioctl: cdrom: Replace .ioctl with .compat_ioctl in four appropriate places	2020-02-24 15:06:07 -05:00
sfi	…
sh	…
siox	siox: Use the correct style for SPDX License Identifier	2020-01-14 21:46:53 +01:00
slimbus	slimbus: qcom: add missed clk_disable_unprepare in remove	2020-01-14 21:46:48 +01:00
soc	soc/tegra: fuse: Fix build with Tegra194 configuration	2020-02-11 15:00:15 -08:00
soundwire	soundwire: cadence: fix kernel-doc parameter descriptions	2020-01-16 17:34:38 +05:30
spi	spi: pxa2xx: Fix controller unregister order	2020-05-26 15:40:30 +01:00
spmi	spmi: pmic-arb: Set lockdep class for hierarchical irq domains	2020-02-10 13:16:04 +01:00
ssb	…
staging	staging: rtl8723bs: Remove unneeded goto statements	2020-02-10 10:32:38 -08:00
target	scsi: Revert "target: iscsi: Wait for all commands to finish before freeing a session"	2020-02-14 17:13:54 -05:00
tc	The main MIPS changes for 5.6:	2020-01-31 11:28:31 -08:00
tee	Merge branch 'linus' of git://git.kernel.org/pub/scm/linux/kernel/git/herbert/crypto-2.6	2020-02-24 11:40:23 -08:00
thermal	- Fix a SEVERE docs build failure for cpu idle cooling device (Randy Dunlap)	2020-01-31 14:39:21 -08:00
thunderbolt	thunderbolt: Prevent crash if non-active NVMem file is read	2020-02-13 04:59:30 -08:00
tty	vt: selection, close sel_buffer race	2020-02-13 12:10:07 -08:00
uio	uio: uio_pdrv_genirq: Do not log an error when deferring probe routine.	2020-01-14 15:27:51 +01:00
usb	USB: misc: iowarrior: add support for the 100 device	2020-02-17 10:44:43 +01:00
vfio	VFIO updates for v5.6-rc1	2020-02-03 22:22:05 +00:00
vhost	vhost: Check docket sk_family instead of call getname	2020-02-22 21:41:42 -08:00
video	Kbuild updates for v5.6 (2nd)	2020-02-09 16:05:50 -08:00
virt	…
virtio	virtio_balloon: Fix memory leaks on errors in virtballoon_probe()	2020-02-06 03:40:27 -05:00
visorbus	visorbus: fix uninitialized variable access	2020-01-14 15:30:35 +01:00
vlynq	…
vme	Char/Misc driver changes for 5.6-rc1	2020-01-29 10:35:54 -08:00
w1	Char/Misc driver changes for 5.6-rc1	2020-01-29 10:35:54 -08:00
watchdog	ACPI fixes for 5.6-rc4	2020-02-28 09:02:18 -08:00
xen	xen: branch for v5.6-rc3	2020-02-21 16:10:10 -08:00
zorro	Kbuild updates for v5.6 (2nd)	2020-02-09 16:05:50 -08:00
Kconfig	…
Makefile	…