OpenCloudOS-Kernel/drivers/scsi/qla2xxx
Nilesh Javali f6be298cc1 scsi: qla2xxx: validate nvme_local_port correctly
commit eb1d4ce2609584eeb7694866f34d4b213caa3af9 upstream.

The driver load failed with error message,

qla2xxx [0000:04:00.0]-ffff:0: register_localport failed: ret=ffffffef

and with a kernel crash,

	BUG: unable to handle kernel NULL pointer dereference at 0000000000000070
	Workqueue: events_unbound qla_register_fcport_fn [qla2xxx]
	RIP: 0010:nvme_fc_register_remoteport+0x16/0x430 [nvme_fc]
	RSP: 0018:ffffaaa040eb3d98 EFLAGS: 00010282
	RAX: 0000000000000000 RBX: ffff9dfb46b78c00 RCX: 0000000000000000
	RDX: ffff9dfb46b78da8 RSI: ffffaaa040eb3e08 RDI: 0000000000000000
	RBP: ffff9dfb612a0a58 R08: ffffffffaf1d6270 R09: 3a34303a30303030
	R10: 34303a303030305b R11: 2078787832616c71 R12: ffff9dfb46b78dd4
	R13: ffff9dfb46b78c24 R14: ffff9dfb41525300 R15: ffff9dfb46b78da8
	FS:  0000000000000000(0000) GS:ffff9dfc67c00000(0000) knlGS:0000000000000000
	CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
	CR2: 0000000000000070 CR3: 000000018da10004 CR4: 00000000000206f0
	Call Trace:
	qla_nvme_register_remote+0xeb/0x1f0 [qla2xxx]
	? qla2x00_dfs_create_rport+0x231/0x270 [qla2xxx]
	qla2x00_update_fcport+0x2a1/0x3c0 [qla2xxx]
	qla_register_fcport_fn+0x54/0xc0 [qla2xxx]

Exit the qla_nvme_register_remote() function when qla_nvme_register_hba()
fails and correctly validate nvme_local_port.

Cc: stable@vger.kernel.org
Signed-off-by: Nilesh Javali <njavali@marvell.com>
Link: https://lore.kernel.org/r/20240710171057.35066-3-njavali@marvell.com
Reviewed-by: Himanshu Madhani <himanshu.madhani@oracle.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2024-08-03 08:54:27 +02:00
..
Kconfig scsi: Add HAS_IOPORT dependencies 2023-05-31 19:59:26 -04:00
Makefile
qla_attr.c scsi: qla2xxx: Delay I/O Abort on PCI error 2024-04-03 15:29:02 +02:00
qla_bsg.c scsi: qla2xxx: Use QP lock to search for bsg 2024-08-03 08:54:26 +02:00
qla_bsg.h scsi: qla2xxx: Add NVMe parameters support in Auxiliary Image Status 2022-09-01 00:30:55 -04:00
qla_dbg.c scsi: qla2xxx: Remove unsupported ql2xenabledif option 2023-08-21 17:45:15 -04:00
qla_dbg.h scsi: qla2xxx: Add Unsolicited LS Request and Response Support for NVMe 2023-08-21 17:45:14 -04:00
qla_def.h scsi: qla2xxx: Reduce fabric scan duplicate code 2024-08-03 08:54:26 +02:00
qla_devtbl.h
qla_dfs.c scsi: qla2xxx: Fix debugfs output for fw_resource_count 2024-06-12 11:11:50 +02:00
qla_dsd.h
qla_edif.c scsi: qla2xxx: Fix off by one in qla_edif_app_getstats() 2024-04-17 11:19:28 +02:00
qla_edif.h scsi: qla2xxx: Relocate/rename vp map 2023-01-11 23:48:25 -05:00
qla_edif_bsg.h scsi: qla2xxx: edif: Fix clang warning 2023-01-11 23:48:26 -05:00
qla_fw.h scsi: qla2xxx: Add NVMe parameters support in Auxiliary Image Status 2022-09-01 00:30:55 -04:00
qla_gbl.h scsi: qla2xxx: Reduce fabric scan duplicate code 2024-08-03 08:54:26 +02:00
qla_gs.c scsi: qla2xxx: Reduce fabric scan duplicate code 2024-08-03 08:54:26 +02:00
qla_init.c scsi: qla2xxx: Fix flash read failure 2024-08-03 08:54:27 +02:00
qla_inline.h scsi: qla2xxx: Unable to act on RSCN for port online 2024-08-03 08:54:26 +02:00
qla_iocb.c scsi: qla2xxx: Fix double free of fcport 2024-04-03 15:29:02 +02:00
qla_isr.c scsi: qla2xxx: Use raw_smp_processor_id() instead of smp_processor_id() 2023-09-05 05:36:08 -04:00
qla_mbx.c scsi: qla2xxx: Change debug message during driver unload 2024-04-03 15:29:02 +02:00
qla_mid.c scsi: qla2xxx: During vport delete send async logout explicitly 2024-08-03 08:54:26 +02:00
qla_mr.c scsi: qla2xxx: Replace all non-returning strlcpy() with strscpy() 2023-05-16 21:41:34 -04:00
qla_mr.h
qla_nvme.c scsi: qla2xxx: validate nvme_local_port correctly 2024-08-03 08:54:27 +02:00
qla_nvme.h scsi: qla2xxx: Add Unsolicited LS Request and Response Support for NVMe 2023-08-21 17:45:14 -04:00
qla_nx.c
qla_nx.h scsi: qla2xxx: Allow 32-byte CDBs 2023-08-21 17:37:42 -04:00
qla_nx2.c
qla_nx2.h
qla_os.c scsi: qla2xxx: Complete command early within lock 2024-08-03 08:54:27 +02:00
qla_settings.h
qla_sup.c scsi: qla2xxx: Fix flash read failure 2024-08-03 08:54:27 +02:00
qla_target.c scsi: qla2xxx: Fix command flush on cable pull 2024-04-03 15:29:02 +02:00
qla_target.h scsi: qla2xxx: Relocate/rename vp map 2023-01-11 23:48:25 -05:00
qla_tmpl.c
qla_tmpl.h
qla_version.h scsi: qla2xxx: Update version to 10.02.09.100-k 2023-08-21 17:45:15 -04:00
tcm_qla2xxx.c scsi: qla2xxx: Use raw_smp_processor_id() instead of smp_processor_id() 2023-09-05 05:36:08 -04:00
tcm_qla2xxx.h