Daniel Axtens 2925c2fdf1 cxl: Fix unbalanced pci_dev_get in cxl_probe ... Currently the first thing we do in cxl_probe is to grab a reference on the pci device. Later on, we call device_register on our adapter. In our remove path, we call device_unregister, but we never call pci_dev_put. We therefore leak the device every time we do a reflash. device_register/unregister is sufficient to hold the reference. Therefore, drop the call to pci_dev_get. Here's why this is safe. The proposed cxl_probe(pdev) calls cxl_adapter_init: a) init calls cxl_adapter_alloc, which creates a struct cxl, conventionally called adapter. This struct contains a device entry, adapter->dev. b) init calls cxl_configure_adapter, where we set adapter->dev.parent = &dev->dev (here dev is the pci dev) So at this point, the cxl adapter's device's parent is the PCI device that I want to be refcounted properly. c) init calls cxl_register_adapter *) cxl_register_adapter calls device_register(&adapter->dev) So now we're in device_register, where dev is the adapter device, and we want to know if the PCI device is safe after we return. device_register(&adapter->dev) calls device_initialize() and then device_add(). device_add() does a get_device(). device_add() also explicitly grabs the device's parent, and calls get_device() on it: parent = get_device(dev->parent); So therefore, device_register() takes a lock on the parent PCI dev, which is what pci_dev_get() was guarding. pci_dev_get() can therefore be safely removed. Fixes: f204e0b8ce ("cxl: Driver code for powernv PCIe based cards for userspace access") Cc: stable@vger.kernel.org Signed-off-by: Daniel Axtens <dja@axtens.net> Acked-by: Ian Munsie <imunsie@au1.ibm.com> Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>		2015-09-15 19:33:38 +10:00
..
accessibility	…
acpi	Power management and ACPI material for v4.3-rc1	2015-09-01 19:45:46 -07:00
amba	…
android	…
ata	Merge branch 'upstream' of git://git.linux-mips.org/pub/scm/ralf/upstream-linus	2015-09-03 16:55:55 -07:00
atm	…
auxdisplay	…
base	Merge branch 'akpm' (patches from Andrew)	2015-09-05 14:27:38 -07:00
bcma	bcma: switch GPIO portions to use GPIOLIB_IRQCHIP	2015-08-18 09:08:47 +03:00
block	Merge branch 'for-4.3/drivers' of git://git.kernel.dk/linux-block	2015-09-02 13:14:58 -07:00
bluetooth	Bluetooth: hci_bcm: Fix crash on suspend	2015-08-28 21:09:14 +02:00
bus	MIPS: Remove "weak" from mips_cdmm_phys_base() declaration	2015-09-03 12:07:39 +02:00
cdrom	…
char	Merge branch 'drm-next' of git://people.freedesktop.org/~airlied/linux	2015-09-04 15:49:32 -07:00
clk	This is the bulk of pin control changes for the v4.3 development	2015-09-04 10:22:09 -07:00
clocksource	- New Device Support	2015-09-04 11:35:03 -07:00
connector	…
cpufreq	Power management and ACPI material for v4.3-rc1	2015-09-01 19:45:46 -07:00
cpuidle	Merge branch 'for-linus' of git://ftp.arm.linux.org.uk/~rmk/linux-arm	2015-09-03 16:27:01 -07:00
crypto	Merge branch 'for-4.3/sg' of git://git.kernel.dk/linux-block	2015-09-02 13:22:38 -07:00
dca	…
devfreq	…
dio	…
dma	dmaengine updates for 4.3-rc1	2015-09-04 11:10:18 -07:00
dma-buf	…
edac	Minor stuff: AMD MCE decoding correction and xgene_edac cleanup.	2015-09-01 18:34:22 -07:00
eisa	…
extcon	regulator: Updates for v4.3	2015-08-31 15:49:19 -07:00
firewire	…
firmware	Merge branch 'for-linus' of git://ftp.arm.linux.org.uk/~rmk/linux-arm	2015-09-03 16:27:01 -07:00
fmc	…
gpio	Merge branch 'drm-next' of git://people.freedesktop.org/~airlied/linux	2015-09-04 15:49:32 -07:00
gpu	Merge branch 'drm-next' of git://people.freedesktop.org/~airlied/linux	2015-09-04 15:49:32 -07:00
hid	Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/dtor/input	2015-09-04 12:02:11 -07:00
hsi	…
hv	…
hwmon	hwmon: (fam15h_power) Add ratio of Tsample to the PTSC period	2015-08-27 07:53:19 -07:00
hwspinlock	…
hwtracing/coresight	…
i2c	- New Device Support	2015-09-04 11:35:03 -07:00
ide	…
idle	…
iio	This is the bulk of GPIO changes for the v4.3 kernel cycle:	2015-09-04 10:07:45 -07:00
infiniband	Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net	2015-08-21 11:44:04 -07:00
input	Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/dtor/input	2015-09-04 12:02:11 -07:00
iommu	Merge branch 'for-4.3/sg' of git://git.kernel.dk/linux-block	2015-09-02 13:22:38 -07:00
ipack	…
irqchip	Merge branch 'upstream' of git://git.linux-mips.org/pub/scm/ralf/upstream-linus	2015-09-03 16:55:55 -07:00
isdn	Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next	2015-09-03 08:08:17 -07:00
leds	- Stop using LP855X Platform Data to control regulators	2015-09-04 11:40:40 -07:00
lguest	…
macintosh	powerpc updates for 4.3	2015-09-03 16:41:38 -07:00
mailbox	Merge branch 'mailbox-for-next' of git://git.linaro.org/landing-teams/working/fujitsu/integration	2015-09-05 18:11:04 -07:00
mcb	…
md	md updates for 4.3	2015-09-05 17:52:22 -07:00
media	media updates for v4.3-rc1	2015-09-05 18:21:14 -07:00
memory	powerpc updates for 4.3	2015-09-03 16:41:38 -07:00
memstick	…
message	mptfusion: prevent some memory corruption	2015-08-26 07:11:45 -07:00
mfd	Merge branch 'drm-next' of git://people.freedesktop.org/~airlied/linux	2015-09-04 15:49:32 -07:00
misc	cxl: Fix unbalanced pci_dev_get in cxl_probe	2015-09-15 19:33:38 +10:00
mmc	Merge branch 'for-4.3/sg' of git://git.kernel.dk/linux-block	2015-09-02 13:22:38 -07:00
mtd	powerpc updates for 4.3	2015-09-03 16:41:38 -07:00
net	Merge branch 'upstream' of git://git.linux-mips.org/pub/scm/ralf/upstream-linus	2015-09-03 16:55:55 -07:00
nfc	This is the bulk of GPIO changes for the v4.3 kernel cycle:	2015-09-04 10:07:45 -07:00
ntb	…
nubus	…
nvdimm	Merge branch 'for-4.3/core' of git://git.kernel.dk/linux-block	2015-09-02 13:10:25 -07:00
nvmem	…
of	arm64 updates for 4.3:	2015-09-04 07:18:09 -07:00
oprofile	…
parisc	Merge branch 'irq-core-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip	2015-09-01 14:33:35 -07:00
parport	…
pci	Merge branch 'irq-core-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip	2015-09-01 14:33:35 -07:00
pcmcia	pcmcia: soc_common: remove skt_dev_info's clk pointer	2015-09-03 16:01:03 +01:00
perf	…
phy	This is the bulk of GPIO changes for the v4.3 kernel cycle:	2015-09-04 10:07:45 -07:00
pinctrl	This is the bulk of pin control changes for the v4.3 development	2015-09-04 10:22:09 -07:00
platform	Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/dtor/input	2015-09-04 12:02:11 -07:00
pnp	…
power	Power management and ACPI material for v4.3-rc1	2015-09-01 19:45:46 -07:00
powercap	powercap / RAPL: disable the 2nd power limit properly	2015-08-29 01:46:40 +02:00
pps	…
ps3	…
ptp	…
pwm	…
rapidio	…
ras	…
regulator	Merge remote-tracking branch 'regulator/topic/tps6586x' into regulator-next	2015-08-30 14:40:29 +01:00
remoteproc	…
reset	…
rpmsg	…
rtc	- New Device Support	2015-09-04 11:35:03 -07:00
s390	Merge branch 'locking-core-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip	2015-09-03 15:46:07 -07:00
sbus	…
scsi	Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next	2015-09-03 08:08:17 -07:00
sfi	…
sh	…
sn	…
soc	ARM: SoC driver updates for v4.3	2015-09-01 13:00:04 -07:00
spi	Merge remote-tracking branches 'spi/topic/ti-qspi', 'spi/topic/xcomm' and 'spi/topic/xlp' into spi-next	2015-08-31 14:45:45 +01:00
spmi	Merge branch 'irq-core-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip	2015-09-01 14:33:35 -07:00
ssb	…
staging	media updates for v4.3-rc1	2015-09-05 18:21:14 -07:00
target	Merge branch 'for-4.3/sg' of git://git.kernel.dk/linux-block	2015-09-02 13:22:38 -07:00
tc	…
thermal	Merge branch 'x86-asm-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip	2015-09-01 08:40:25 -07:00
thunderbolt	…
tty	Merge branch 'upstream' of git://git.linux-mips.org/pub/scm/ralf/upstream-linus	2015-09-03 16:55:55 -07:00
uio	…
usb	Merge branch 'for-next' of git://git.kernel.org/pub/scm/linux/kernel/git/jikos/trivial	2015-09-01 18:46:42 -07:00
uwb	…
vfio	…
vhost	…
video	Merge branch 'akpm' (patches from Andrew)	2015-09-05 14:27:38 -07:00
virt	…
virtio	…
vlynq	…
vme	…
w1	Merge branch 'for-next' of git://git.kernel.org/pub/scm/linux/kernel/git/jikos/trivial	2015-09-01 18:46:42 -07:00
watchdog	- New Device Support	2015-09-04 11:35:03 -07:00
xen	Power management and ACPI material for v4.3-rc1	2015-09-01 19:45:46 -07:00
zorro	…
Kconfig	Merge branch 'for-linus' of git://ftp.arm.linux.org.uk/~rmk/linux-arm	2015-09-03 16:27:01 -07:00
Makefile	This is the bulk of pin control changes for the v4.3 development	2015-09-04 10:22:09 -07:00