Al Viro e968edf6ec afs: fix __afs_break_callback() / afs_drop_open_mmap() race ... [ Upstream commit 275655d3207b9e65d1561bf21c06a622d9ec1d43 ] In __afs_break_callback() we might check ->cb_nr_mmap and if it's non-zero do queue_work(&vnode->cb_work). In afs_drop_open_mmap() we decrement ->cb_nr_mmap and do flush_work(&vnode->cb_work) if it reaches zero. The trouble is, there's nothing to prevent __afs_break_callback() from seeing ->cb_nr_mmap before the decrement and do queue_work() after both the decrement and flush_work(). If that happens, we might be in trouble - vnode might get freed before the queued work runs. __afs_break_callback() is always done under ->cb_lock, so let's make sure that ->cb_nr_mmap can change from non-zero to zero while holding ->cb_lock (the spinlock component of it - it's a seqlock and we don't need to mess with the counter). Acked-by: Christian Brauner <brauner@kernel.org> Signed-off-by: Al Viro <viro@zeniv.linux.org.uk> Signed-off-by: Sasha Levin <sashal@kernel.org>		2024-08-29 17:33:32 +02:00
..
Kconfig	afs: Convert afs to use the new fscache API	2022-01-07 13:44:47 +00:00
Makefile	afs: Convert afs to use the new fscache API	2022-01-07 13:44:47 +00:00
addr_list.c	afs: Use kfree_rcu() instead of casting kfree() to rcu_callback_t	2020-03-13 10:47:33 -07:00
afs.h	rxrpc: Fix timeout of a call that hasn't yet been granted a channel	2023-05-01 07:43:19 +01:00
afs_cm.h	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152	2019-05-30 11:26:32 -07:00
afs_fs.h	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152	2019-05-30 11:26:32 -07:00
afs_vl.h	afs: Implement client support for the YFSVL.GetCellName RPC op	2020-06-04 15:37:57 +01:00
callback.c	afs: fix the usage of read_seqbegin_or_lock() in afs_lookup_volume_rcu()	2024-02-05 20:14:16 +00:00
cell.c	afs: Fix overwriting of result of DNS query	2024-01-01 12:42:34 +00:00
cmservice.c	rxrpc: Tidy up abort generation infrastructure	2023-01-06 09:43:32 +00:00
dir.c	afs: Revert "afs: Hide silly-rename files from userspace"	2024-03-26 18:20:03 -04:00
dir_edit.c	afs: fix the afs_dir_get_folio return value	2023-05-06 10:10:08 -07:00
dir_silly.c	netfs: Fix gcc-12 warning by embedding vfs inode in netfs_i_context	2022-06-09 13:55:00 -07:00
dynroot.c	afs: Fix dynamic root lookup DNS check	2024-01-01 12:42:33 +00:00
file.c	afs: fix __afs_break_callback() / afs_drop_open_mmap() race	2024-08-29 17:33:32 +02:00
flock.c	fs: remove locks_inode	2023-01-11 06:52:43 -05:00
fs_operation.c	netfs: Fix gcc-12 warning by embedding vfs inode in netfs_i_context	2022-06-09 13:55:00 -07:00
fs_probe.c	afs: Fix lost servers_outstanding count	2022-12-22 11:40:35 +00:00
fsclient.c	afs: Use the operation issue time instead of the reply time for callbacks	2022-09-01 11:44:13 +01:00
inode.c	fs: pass the request_mask to generic_fillattr	2023-08-09 08:56:36 +02:00
internal.h	afs: Fix use-after-free due to get/remove race in volume tree	2024-01-01 12:42:34 +00:00
main.c	afs: Convert afs to use the new fscache API	2022-01-07 13:44:47 +00:00
misc.c	afs: Return -EAGAIN, not -EREMOTEIO, when a file already locked	2022-09-06 21:33:01 -04:00
mntpt.c	afs: Don't cross .backup mountpoint from backup volume	2024-06-16 13:47:30 +02:00
proc.c	afs: Use refcount_t rather than atomic_t	2022-08-02 18:10:11 +01:00
protocol_afs.h	afs: Fix corruption in reads at fpos 2G-4G from an OpenAFS server	2021-09-13 09:14:21 +01:00
protocol_uae.h	afs: Add support for the UAE error table	2019-06-28 18:37:53 +01:00
protocol_yfs.h	afs: Fix corruption in reads at fpos 2G-4G from an OpenAFS server	2021-09-13 09:14:21 +01:00
rotate.c	afs: Adjust ACK interpretation to try and cope with NAT	2022-05-22 21:03:02 +01:00
rxrpc.c	afs: Fix refcount underflow from error handling race	2023-12-20 17:01:43 +01:00
security.c	fs: port ->permission() to pass mnt_idmap	2023-01-19 09:24:28 +01:00
server.c	afs: fix the usage of read_seqbegin_or_lock() in afs_find_server*()	2024-02-05 20:14:16 +00:00
server_list.c	afs: Fix afs_server_list to be cleaned up with RCU	2023-12-03 07:33:02 +01:00
super.c	afs: Fix file locking on R/O volumes to operate in local mode	2023-12-03 07:33:05 +01:00
vl_alias.c	afs: Add tracing for cell refcount and active user count	2020-10-16 14:39:21 +01:00
vl_list.c	afs: Use refcount_t rather than atomic_t	2022-08-02 18:10:11 +01:00
vl_probe.c	afs: Fix vlserver probe RTT handling	2023-06-16 14:43:41 -07:00
vl_rotate.c	afs: Return ENOENT if no cell DNS record can be found	2023-12-03 07:33:05 +01:00
vlclient.c	afs: Fix fall-through warnings for Clang	2021-05-25 07:30:34 -10:00
volume.c	afs: Increase buffer size in afs_update_volume_status()	2024-03-01 13:35:07 +01:00
write.c	mm: page_ref: remove folio_try_get_rcu()	2024-07-25 09:50:56 +02:00
xattr.c	fs: port xattr to mnt_idmap	2023-01-19 09:24:28 +01:00
xdr_fs.h	afs: Fix directory entry size calculation	2021-01-04 12:25:19 +00:00
yfsclient.c	afs: Use the operation issue time instead of the reply time for callbacks	2022-09-01 11:44:13 +01:00