Zhang Rui dd64ea0337 thermal: intel: int340x: processor: Fix warning during module unload ... [ Upstream commit 99ca0b57e49fb73624eede1c4396d9e3d10ccf14 ] The processor_thermal driver uses pcim_device_enable() to enable a PCI device, which means the device will be automatically disabled on driver detach. Thus there is no need to call pci_disable_device() again on it. With recent PCI device resource management improvements, e.g. commit f748a07a0b64 ("PCI: Remove legacy pcim_release()"), this problem is exposed and triggers the warining below. [ 224.010735] proc_thermal_pci 0000:00:04.0: disabling already-disabled device [ 224.010747] WARNING: CPU: 8 PID: 4442 at drivers/pci/pci.c:2250 pci_disable_device+0xe5/0x100 ... [ 224.010844] Call Trace: [ 224.010845] <TASK> [ 224.010847] ? show_regs+0x6d/0x80 [ 224.010851] ? __warn+0x8c/0x140 [ 224.010854] ? pci_disable_device+0xe5/0x100 [ 224.010856] ? report_bug+0x1c9/0x1e0 [ 224.010859] ? handle_bug+0x46/0x80 [ 224.010862] ? exc_invalid_op+0x1d/0x80 [ 224.010863] ? asm_exc_invalid_op+0x1f/0x30 [ 224.010867] ? pci_disable_device+0xe5/0x100 [ 224.010869] ? pci_disable_device+0xe5/0x100 [ 224.010871] ? kfree+0x21a/0x2b0 [ 224.010873] pcim_disable_device+0x20/0x30 [ 224.010875] devm_action_release+0x16/0x20 [ 224.010878] release_nodes+0x47/0xc0 [ 224.010880] devres_release_all+0x9f/0xe0 [ 224.010883] device_unbind_cleanup+0x12/0x80 [ 224.010885] device_release_driver_internal+0x1ca/0x210 [ 224.010887] driver_detach+0x4e/0xa0 [ 224.010889] bus_remove_driver+0x6f/0xf0 [ 224.010890] driver_unregister+0x35/0x60 [ 224.010892] pci_unregister_driver+0x44/0x90 [ 224.010894] proc_thermal_pci_driver_exit+0x14/0x5f0 [processor_thermal_device_pci] ... [ 224.010921] ---[ end trace 0000000000000000 ]--- Remove the excess pci_disable_device() calls. Fixes: acd65d5d1c ("thermal/drivers/int340x/processor_thermal: Add PCI MMIO based thermal driver") Signed-off-by: Zhang Rui <rui.zhang@intel.com> Reviewed-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com> Link: https://patch.msgid.link/20240930081801.28502-3-rui.zhang@intel.com [ rjw: Subject and changelog edits ] Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com> Signed-off-by: Sasha Levin <sashal@kernel.org>		2024-10-17 15:24:24 +02:00
..
broadcom	thermal/drivers/broadcom: Fix race between removal and clock disable	2024-08-11 12:47:12 +02:00
intel	thermal: intel: int340x: processor: Fix warning during module unload	2024-10-17 15:24:24 +02:00
mediatek	thermal/drivers/mediatek/lvts_thermal: Check NULL ptr on lvts_data	2024-07-11 12:49:07 +02:00
qcom	thermal/drivers/qcom/lmh: Check for SCM availability at probe	2024-06-16 13:47:33 +02:00
samsung	…
st	…
tegra	…
ti-soc-thermal	…
Kconfig	…
Makefile	…
amlogic_thermal.c	…
armada_thermal.c	…
cpufreq_cooling.c	…
cpuidle_cooling.c	…
da9062-thermal.c	…
db8500_thermal.c	…
devfreq_cooling.c	thermal: devfreq_cooling: Fix perf state when calculate dfc res_util	2024-04-03 15:28:56 +02:00
dove_thermal.c	…
gov_bang_bang.c	thermal: core: Store trip pointer in struct thermal_instance	2024-01-31 16:19:10 -08:00
gov_fair_share.c	thermal: core: Store trip pointer in struct thermal_instance	2024-01-31 16:19:10 -08:00
gov_power_allocator.c	thermal: gov_power_allocator: avoid inability to reset a cdev	2024-01-31 16:19:10 -08:00
gov_step_wise.c	thermal: core: Store trip pointer in struct thermal_instance	2024-01-31 16:19:10 -08:00
gov_user_space.c	…
hisi_thermal.c	…
imx8mm_thermal.c	…
imx_sc_thermal.c	…
imx_thermal.c	…
k3_bandgap.c	…
k3_j72xx_bandgap.c	…
khadas_mcu_fan.c	…
kirkwood_thermal.c	…
loongson2_thermal.c	…
max77620_thermal.c	…
qoriq_thermal.c	thermal/drivers/qoriq: Fix getting tmu range	2024-03-26 18:20:07 -04:00
rcar_gen3_thermal.c	…
rcar_thermal.c	…
rockchip_thermal.c	…
rzg2l_thermal.c	…
spear_thermal.c	…
sprd_thermal.c	…
sun8i_thermal.c	…
thermal-generic-adc.c	…
thermal_acpi.c	…
thermal_core.c	thermal: core: Fix thermal zone suspend-resume synchronization	2024-02-05 20:14:15 +00:00
thermal_core.h	thermal: core: Store trip pointer in struct thermal_instance	2024-01-31 16:19:10 -08:00
thermal_helpers.c	thermal: core: Store trip pointer in struct thermal_instance	2024-01-31 16:19:10 -08:00
thermal_hwmon.c	…
thermal_hwmon.h	…
thermal_mmio.c	…
thermal_netlink.c	…
thermal_netlink.h	…
thermal_of.c	thermal: of: Fix OF node leak in of_thermal_zone_find() error paths	2024-09-04 13:28:22 +02:00
thermal_sysfs.c	thermal: core: Store trip pointer in struct thermal_instance	2024-01-31 16:19:10 -08:00
thermal_trace.h	…
thermal_trace_ipa.h	…
thermal_trip.c	thermal: trip: Drop lockdep assertion from thermal_zone_trip_id()	2024-01-31 16:19:14 -08:00
uniphier_thermal.c	…