Takashi Iwai d5dbbe6569 ALSA: dummy: Fix a use-after-free at closing ... syzkaller fuzzer spotted a potential use-after-free case in snd-dummy driver when hrtimer is used as backend: > ================================================================== > BUG: KASAN: use-after-free in rb_erase+0x1b17/0x2010 at addr ffff88005e5b6f68 > Read of size 8 by task syz-executor/8984 > ============================================================================= > BUG kmalloc-192 (Not tainted): kasan: bad access detected > ----------------------------------------------------------------------------- > > Disabling lock debugging due to kernel taint > INFO: Allocated in 0xbbbbbbbbbbbbbbbb age=18446705582212484632 > .... > [< none >] dummy_hrtimer_create+0x49/0x1a0 sound/drivers/dummy.c:464 > .... > INFO: Freed in 0xfffd8e09 age=18446705496313138713 cpu=2164287125 pid=-1 > [< none >] dummy_hrtimer_free+0x68/0x80 sound/drivers/dummy.c:481 > .... > Call Trace: > [<ffffffff8179e59e>] __asan_report_load8_noabort+0x3e/0x40 mm/kasan/report.c:333 > [< inline >] rb_set_parent include/linux/rbtree_augmented.h:111 > [< inline >] __rb_erase_augmented include/linux/rbtree_augmented.h:218 > [<ffffffff82ca5787>] rb_erase+0x1b17/0x2010 lib/rbtree.c:427 > [<ffffffff82cb02e8>] timerqueue_del+0x78/0x170 lib/timerqueue.c:86 > [<ffffffff814d0c80>] __remove_hrtimer+0x90/0x220 kernel/time/hrtimer.c:903 > [< inline >] remove_hrtimer kernel/time/hrtimer.c:945 > [<ffffffff814d23da>] hrtimer_try_to_cancel+0x22a/0x570 kernel/time/hrtimer.c:1046 > [<ffffffff814d2742>] hrtimer_cancel+0x22/0x40 kernel/time/hrtimer.c:1066 > [<ffffffff85420531>] dummy_hrtimer_stop+0x91/0xb0 sound/drivers/dummy.c:417 > [<ffffffff854228bf>] dummy_pcm_trigger+0x17f/0x1e0 sound/drivers/dummy.c:507 > [<ffffffff85392170>] snd_pcm_do_stop+0x160/0x1b0 sound/core/pcm_native.c:1106 > [<ffffffff85391b26>] snd_pcm_action_single+0x76/0x120 sound/core/pcm_native.c:956 > [<ffffffff85391e01>] snd_pcm_action+0x231/0x290 sound/core/pcm_native.c:974 > [< inline >] snd_pcm_stop sound/core/pcm_native.c:1139 > [<ffffffff8539754d>] snd_pcm_drop+0x12d/0x1d0 sound/core/pcm_native.c:1784 > [<ffffffff8539d3be>] snd_pcm_common_ioctl1+0xfae/0x2150 sound/core/pcm_native.c:2805 > [<ffffffff8539ee91>] snd_pcm_capture_ioctl1+0x2a1/0x5e0 sound/core/pcm_native.c:2976 > [<ffffffff8539f2ec>] snd_pcm_kernel_ioctl+0x11c/0x160 sound/core/pcm_native.c:3020 > [<ffffffff853d9a44>] snd_pcm_oss_sync+0x3a4/0xa30 sound/core/oss/pcm_oss.c:1693 > [<ffffffff853da27d>] snd_pcm_oss_release+0x1ad/0x280 sound/core/oss/pcm_oss.c:2483 > ..... A workaround is to call hrtimer_cancel() in dummy_hrtimer_sync() which is called certainly before other blocking ops. Reported-by: Dmitry Vyukov <dvyukov@google.com> Tested-by: Dmitry Vyukov <dvyukov@google.com> Cc: <stable@vger.kernel.org> Signed-off-by: Takashi Iwai <tiwai@suse.de>		2016-06-24 15:18:32 +02:00
..
aoa	ALSA: aoa-soundbus: Switch to dev_pm_ops	2015-08-05 16:47:47 +02:00
arm	dma, mm/pat: Rename dma_*_writecombine() to dma_*_wc()	2016-03-09 14:57:51 +01:00
atmel	ALSA: sound/atmel/ac97c.c: remove unused variable	2015-05-20 06:18:25 +02:00
core	ASoC: Updates for v4.7	2016-05-16 14:59:00 +02:00
drivers	ALSA: dummy: Fix a use-after-free at closing	2016-06-24 15:18:32 +02:00
firewire	ALSA: firewire-lib: change a member of event structure to suppress sparse wanings to bool type	2016-05-18 16:32:09 +02:00
hda	ALSA: hdac_regmap - fix the register access for runtime PM	2016-06-17 14:01:06 +02:00
i2c	ALSA: i2c: constify snd_i2c_ops structures	2015-11-30 11:40:08 +01:00
isa	ALSA: isa/wavefront: prevent some out of bound writes	2016-05-08 11:39:44 +02:00
mips	ALSA: Remove deprecated AU1X00 AC97 driver	2016-02-08 08:17:15 +01:00
oss	sound: oss: Use setup_timer and mod_timer.	2016-05-17 18:02:20 +02:00
parisc	…
pci	ALSA: hda / realtek - add two more Thinkpad IDs (5050,5053) for tpt460 fixup	2016-06-24 15:16:50 +02:00
pcmcia	…
ppc	PCI: Remove includes of asm/pci-bridge.h	2016-02-05 16:29:28 -06:00
sh	…
soc	sound updates #2 for 4.7-rc1	2016-05-28 12:23:12 -07:00
sparc	ALSA: Add missing dependency on CONFIG_SND_TIMER	2016-01-27 07:10:38 +01:00
spi	ALSA: at73c213: manage SSC clock	2016-01-20 09:59:27 +01:00
synth	ALSA: emux: constify nrpn_conv_table structures	2016-01-06 10:19:49 +01:00
usb	Merge branch 'for-next' into for-linus	2016-05-16 09:13:08 +02:00
Kconfig	…
Makefile	…
ac97_bus.c	ASoC: Updates for v4.3	2015-08-31 16:25:22 +02:00
last.c	…
sound_core.c	sound: fix check for error condition of register_chrdev()	2015-11-07 11:14:30 +01:00
sound_firmware.c	sound: sound_firmware: Fix invalid use of vfs_read()	2015-05-26 13:48:58 +02:00