Michał Winiarski 1bbbca0db7 drm/i915/guc: Move shared data allocation away from submission path ... We need shared data for actions (e.g. guc suspend/resume), and we're using those with GuC submission disabled. Let's introduce intel_guc_init and move shared data alloc there. This fixes GPF during module unload with HuC, but without GuC submission: BUG: unable to handle kernel NULL pointer dereference at 000000005aee7809 IP: intel_guc_suspend+0x34/0x140 [i915] PGD 0 P4D 0 Oops: 0000 [#1] PREEMPT SMP Modules linked in: i915(O-) netconsole x86_pkg_temp_thermal intel_powerclamp coretemp crct10dif_pclmul crc32_pclmul ghash_clmulni_intel mei_me i2c_i801 mei prime_numbers [last unloaded: i915] CPU: 2 PID: 2794 Comm: rmmod Tainted: G U W O 4.15.0-rc2+ #297 Hardware name: /NUC6i5SYB, BIOS SYSKLi35.86A.0054.2016.0930.1102 09/30/2016 task: 0000000055945c61 task.stack: 00000000264ccb43 RIP: 0010:intel_guc_suspend+0x34/0x140 [i915] RSP: 0018:ffffc90000483df8 EFLAGS: 00010286 RAX: 0000000000000000 RBX: ffff880829180000 RCX: 0000000000000000 RDX: 0000000000000006 RSI: ffff880844c2c938 RDI: ffff880844c2c000 RBP: ffff880829180000 R08: 00000000a29c58c1 R09: 0000000000000000 R10: 0000000000000000 R11: 0000000000000000 R12: ffffffffa040ba40 R13: ffffffffa040bab0 R14: ffff88084a195060 R15: 000055df3ef357a0 FS: 00007ff43c043740(0000) GS:ffff88084e200000(0000) knlGS:0000000000000000 CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 CR2: 00000000000000f9 CR3: 000000083f179005 CR4: 00000000003606e0 Call Trace: i915_gem_suspend+0x9d/0x130 [i915] ? i915_driver_unload+0x68/0x180 [i915] i915_driver_unload+0x70/0x180 [i915] i915_pci_remove+0x15/0x20 [i915] pci_device_remove+0x36/0xb0 device_release_driver_internal+0x15f/0x220 driver_detach+0x3a/0x80 bus_remove_driver+0x58/0xd0 pci_unregister_driver+0x29/0x90 SyS_delete_module+0x150/0x1e0 entry_SYSCALL_64_fastpath+0x23/0x9a RIP: 0033:0x7ff43b51b5c7 RSP: 002b:00007ffe6825a758 EFLAGS: 00000206 ORIG_RAX: 00000000000000b0 RAX: ffffffffffffffda RBX: 0000000000000003 RCX: 00007ff43b51b5c7 RDX: 000000000000000a RSI: 0000000000000800 RDI: 000055df3ef35808 RBP: 0000000000000000 R08: 00007ffe682596d1 R09: 0000000000000000 R10: 00007ff43b594880 R11: 0000000000000206 R12: 000055df3ef357a0 R13: 00007ffe68259740 R14: 000055df3ef35260 R15: 000055df3ef357a0 Code: 00 00 02 74 03 31 c0 c3 53 48 89 fb 48 83 ec 10 e8 52 0f f8 ff 48 b8 01 05 00 00 02 00 00 00 48 89 44 24 04 48 8b 83 00 12 00 00 <f6> 80 f9 00 00 00 01 0f 84 a7 00 00 00 f6 80 98 00 00 00 01 0f RIP: intel_guc_suspend+0x34/0x140 [i915] RSP: ffffc90000483df8 CR2: 00000000000000f9 ---[ end trace 23a192a61d937a3e ]--- Fixes: b8e5eb960b ("drm/i915/guc: Allocate separate shared data object for GuC communication") Signed-off-by: Michał Winiarski <michal.winiarski@intel.com> Cc: Chris Wilson <chris@chris-wilson.co.uk> Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com> Cc: Michal Wajdeczko <michal.wajdeczko@intel.com> Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk> Link: https://patchwork.freedesktop.org/patch/msgid/20171213221352.7173-1-michal.winiarski@intel.com		2017-12-14 08:06:52 +00:00
..
amd	drm/amdgpu: Use drm_fb_helper_lastclose() and _poll_changed()	2017-12-06 12:48:33 -05:00
arc	drm/arc: Use drm_gem_cma_print_info()	2017-11-11 11:23:15 +01:00
arm	Merge arlied/drm-next into drm-misc-next	2017-12-04 16:04:45 -02:00
armada	main drm pull request for v4.15	2017-11-15 20:42:10 -08:00
ast	drm/ttm: add operation ctx to ttm_bo_validate v2	2017-12-06 12:48:01 -05:00
atmel-hlcdc	main drm pull request for v4.15	2017-11-15 20:42:10 -08:00
bochs	drm/ttm: add operation ctx to ttm_bo_validate v2	2017-12-06 12:48:01 -05:00
bridge	Merge tag 'drm-misc-next-2017-11-30' of git://anongit.freedesktop.org/drm/drm-misc into drm-next	2017-12-04 05:42:49 +10:00
cirrus	drm/ttm: add operation ctx to ttm_bo_validate v2	2017-12-06 12:48:01 -05:00
etnaviv	main drm pull request for v4.15	2017-11-15 20:42:10 -08:00
exynos	Merge tag 'drm-misc-next-2017-11-30' of git://anongit.freedesktop.org/drm/drm-misc into drm-next	2017-12-04 05:42:49 +10:00
fsl-dcu	drm/fsl-dcu: Use drm_mode_config_helper_suspend/resume()	2017-12-05 13:46:41 +01:00
gma500	Merge tag 'drm-misc-next-2017-11-30' of git://anongit.freedesktop.org/drm/drm-misc into drm-next	2017-12-04 05:42:49 +10:00
hisilicon	drm/ttm: add operation ctx to ttm_bo_validate v2	2017-12-06 12:48:01 -05:00
i2c	Merge tag 'drm-misc-next-2017-11-30' of git://anongit.freedesktop.org/drm/drm-misc into drm-next	2017-12-04 05:42:49 +10:00
i810	…
i915	drm/i915/guc: Move shared data allocation away from submission path	2017-12-14 08:06:52 +00:00
imx	Merge tag 'drm-misc-next-2017-11-30' of git://anongit.freedesktop.org/drm/drm-misc into drm-next	2017-12-04 05:42:49 +10:00
lib	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
mediatek	Merge tag 'drm-misc-next-2017-11-30' of git://anongit.freedesktop.org/drm/drm-misc into drm-next	2017-12-04 05:42:49 +10:00
meson	drm: Move drm_plane_helper_check_state() into drm_atomic_helper.c	2017-11-20 21:14:22 +02:00
mga	…
mgag200	drm/ttm: add operation ctx to ttm_bo_validate v2	2017-12-06 12:48:01 -05:00
msm	Merge tag 'drm-misc-next-2017-11-30' of git://anongit.freedesktop.org/drm/drm-misc into drm-next	2017-12-04 05:42:49 +10:00
mxsfb	drm/mxsfb: Use drm_gem_fb_create() and drm_gem_fb_prepare_fb()	2017-10-01 17:02:20 +02:00
nouveau	drm/ttm: add context to driver move callback as well	2017-12-06 12:48:03 -05:00
omapdrm	omapdrm: hdmi4_cec: signedness bug in hdmi4_cec_init()	2017-11-30 12:25:37 +02:00
panel	Merge tag 'drm-misc-next-2017-11-30' of git://anongit.freedesktop.org/drm/drm-misc into drm-next	2017-12-04 05:42:49 +10:00
pl111	main drm pull request for v4.15	2017-11-15 20:42:10 -08:00
qxl	drm/ttm: add context to driver move callback as well	2017-12-06 12:48:03 -05:00
r128	r128: switch compat ioctls to drm_ioctl_kernel()	2017-09-29 13:42:35 -04:00
radeon	drm/radeon: Use drm_fb_helper_lastclose() and _poll_changed()	2017-12-06 12:48:34 -05:00
rcar-du	drm: rcar-du: Clip planes to screen boundaries	2017-12-04 18:38:31 +02:00
rockchip	Merge tag 'drm-misc-next-2017-11-30' of git://anongit.freedesktop.org/drm/drm-misc into drm-next	2017-12-04 05:42:49 +10:00
savage	…
selftests	Merge tag 'drm-misc-next-2017-11-30' of git://anongit.freedesktop.org/drm/drm-misc into drm-next	2017-12-04 05:42:49 +10:00
shmobile	main drm pull request for v4.15	2017-11-15 20:42:10 -08:00
sis	…
sti	gpu: drm: sti: Adopt SPDX identifiers	2017-12-06 15:51:23 +01:00
stm	gpu: drm: stm: Adopt SPDX identifiers	2017-12-06 15:51:37 +01:00
sun4i	drm/sun4i: Fix uninitialized variables in vi layer	2017-12-07 09:51:41 +01:00
tdfx	…
tegra	Merge tag 'drm-misc-next-2017-11-30' of git://anongit.freedesktop.org/drm/drm-misc into drm-next	2017-12-04 05:42:49 +10:00
tilcdc	Merge tag 'drm-misc-next-2017-11-30' of git://anongit.freedesktop.org/drm/drm-misc into drm-next	2017-12-04 05:42:49 +10:00
tinydrm	drm/tinydrm: add driver for ILI9225 panels	2017-12-01 14:08:37 +01:00
ttm	drm/ttm: swap consecutive allocated pooled pages v4	2017-12-06 12:48:32 -05:00
tve200	drm/tve200: Use drm_gem_fb_create() and drm_gem_fb_prepare_fb()	2017-10-01 17:04:36 +02:00
udl	Merge tag 'drm-misc-next-2017-10-20' of git://anongit.freedesktop.org/drm/drm-misc into drm-next	2017-10-24 16:51:05 +10:00
vc4	Merge tag 'drm-misc-next-2017-11-30' of git://anongit.freedesktop.org/drm/drm-misc into drm-next	2017-12-04 05:42:49 +10:00
vgem	treewide: setup_timer() -> timer_setup()	2017-11-21 15:57:07 -08:00
via	Merge tag 'drm-misc-next-2017-11-30' of git://anongit.freedesktop.org/drm/drm-misc into drm-next	2017-12-04 05:42:49 +10:00
virtio	drm/ttm: add context to driver move callback as well	2017-12-06 12:48:03 -05:00
vmwgfx	drm/ttm: add operation ctx to ttm_bo_validate v2	2017-12-06 12:48:01 -05:00
zte	Merge tag 'drm-misc-next-2017-11-30' of git://anongit.freedesktop.org/drm/drm-misc into drm-next	2017-12-04 05:42:49 +10:00
Kconfig	drm: Document that drm_panel_orientation_quirks.c is shared with fbdev	2017-12-05 12:08:57 +01:00
Makefile	drm: Add panel orientation quirks, v6.	2017-12-04 23:03:21 +01:00
ati_pcigart.c	…
drm_agpsupport.c	…
drm_atomic.c	Merge airlied/drm-next into drm-misc-next	2017-11-21 14:17:56 +01:00
drm_atomic_helper.c	Merge tag 'drm-misc-next-2017-11-30' of git://anongit.freedesktop.org/drm/drm-misc into drm-next	2017-12-04 05:42:49 +10:00
drm_auth.c	drm: Check mode object lease status in all master ioctl paths [v4]	2017-10-25 16:31:30 +10:00
drm_blend.c	…
drm_bridge.c	…
drm_bufs.c	…
drm_cache.c	…
drm_color_mgmt.c	drm: Pass struct drm_file * to __drm_mode_object_find [v2]	2017-10-12 10:03:04 +10:00
drm_connector.c	drm: Add support for a panel-orientation connector property, v6	2017-12-04 23:03:21 +01:00
drm_context.c	…
drm_crtc.c	drm: Pass struct drm_file * to __drm_mode_object_find [v2]	2017-10-12 10:03:04 +10:00
drm_crtc_helper.c	drm: Replace kzalloc with kcalloc	2017-10-13 15:49:03 -04:00
drm_crtc_helper_internal.h	…
drm_crtc_internal.h	drm: Pass struct drm_file * to __drm_mode_object_find [v2]	2017-10-12 10:03:04 +10:00
drm_debugfs.c	drm/debugfs: Fix framebuffer debugfs file init	2017-11-14 11:08:17 +02:00
drm_debugfs_crc.c	…
drm_dma.c	…
drm_dp_aux_dev.c	Pass mode to wait_on_atomic_t() action funcs and provide default actions	2017-11-13 15:38:16 +00:00
drm_dp_dual_mode_helper.c	drm: Add retries for lspcon mode detection	2017-10-13 12:13:54 +03:00
drm_dp_helper.c	drm: don't link DP aux i2c adapter to the hardware device node	2017-11-20 09:34:17 +01:00
drm_dp_mst_topology.c	…
drm_drv.c	Merge airlied/drm-next into drm-misc-next	2017-11-21 14:17:56 +01:00
drm_dumb_buffers.c	…
drm_edid.c	Merge tag 'drm-misc-next-2017-11-30' of git://anongit.freedesktop.org/drm/drm-misc into drm-next	2017-12-04 05:42:49 +10:00
drm_edid_load.c	…
drm_encoder.c	drm: Check mode object lease status in all master ioctl paths [v4]	2017-10-25 16:31:30 +10:00
drm_encoder_slave.c	…
drm_fb_cma_helper.c	drm/cma-helper: Remove drm_fb_cma_debugfs_show()	2017-11-11 11:25:14 +01:00
drm_fb_helper.c	drm/fb-helper: Fix potential NULL pointer dereference	2017-12-06 21:45:28 +01:00
drm_file.c	…
drm_flip_work.c	…
drm_fourcc.c	…
drm_framebuffer.c	Merge airlied/drm-next into drm-misc-next	2017-11-21 14:17:56 +01:00
drm_gem.c	drm/framebuffer: Add framebuffer debugfs file	2017-11-11 11:21:19 +01:00
drm_gem_cma_helper.c	drm: gem_cma_helper.c: Allow importing of contiguous scatterlists with nents > 1	2017-11-15 18:14:46 +01:00
drm_gem_framebuffer_helper.c	drm/gem-fb-helper: Improve documentation	2017-10-08 15:02:51 +02:00
drm_global.c	…
drm_hashtab.c	…
drm_info.c	…
drm_internal.h	Merge airlied/drm-next into drm-misc-next	2017-11-21 14:17:56 +01:00
drm_ioc32.c	…
drm_ioctl.c	drm: Add four ioctls for managing drm mode object leases [v7]	2017-10-25 16:31:30 +10:00
drm_irq.c	…
drm_kms_helper_common.c	…
drm_lease.c	drm: Add four ioctls for managing drm mode object leases [v7]	2017-10-25 16:31:30 +10:00
drm_legacy.h	…
drm_lock.c	…
drm_memory.c	…
drm_mipi_dsi.c	…
drm_mm.c	drm: Spelling fixes	2017-11-02 11:10:37 -02:00
drm_mode_config.c	drm: Check mode object lease status in all master ioctl paths [v4]	2017-10-25 16:31:30 +10:00
drm_mode_object.c	drm/mode_object: fix documentation for object lookups.	2017-11-10 13:50:47 +10:00
drm_modes.c	…
drm_modeset_helper.c	drm/modeset-helper: Add simple modeset suspend/resume helpers	2017-11-30 18:18:08 +01:00
drm_modeset_lock.c	drm: Require __GFP_NOFAIL for the legacy drm_modeset_lock_all	2017-10-31 17:36:46 +01:00
drm_of.c	drm/drm_of: Move drm_of_panel_bridge_remove_function into header.	2017-10-13 16:59:36 +02:00
drm_panel.c	…
drm_panel_orientation_quirks.c	drm: Add panel orientation quirks, v6.	2017-12-04 23:03:21 +01:00
drm_pci.c	drm/core: clean up references to drm_dev_unref()	2017-09-27 10:53:12 +02:00
drm_plane.c	drm/vblank: Pass crtc_id to page_flip_ioctl.	2017-11-23 13:04:19 +01:00
drm_plane_helper.c	drm: Move drm_plane_helper_check_state() into drm_atomic_helper.c	2017-11-20 21:14:22 +02:00
drm_prime.c	drm/prime: skip CPU sync in map/unmap dma_buf	2017-12-04 17:30:19 +01:00
drm_print.c	drm/printer: Add drm_vprintf()	2017-11-23 12:31:49 +02:00
drm_probe_helper.c	drm/probe-helper: Fix drm_kms_helper_poll_enable() docs	2017-11-30 18:17:37 +01:00
drm_property.c	drm: Pass struct drm_file * to __drm_mode_object_find [v2]	2017-10-12 10:03:04 +10:00
drm_rect.c	…
drm_scatter.c	…
drm_scdc_helper.c	Merge tag 'drm-misc-next-2017-09-20' of git://anongit.freedesktop.org/git/drm-misc into drm-next	2017-09-28 05:46:15 +10:00
drm_simple_kms_helper.c	drm: Move drm_plane_helper_check_state() into drm_atomic_helper.c	2017-11-20 21:14:22 +02:00
drm_syncobj.c	Merge airlied/drm-next into drm-misc-next	2017-11-21 14:17:56 +01:00
drm_sysfs.c	…
drm_trace.h	main drm pull request for v4.15	2017-11-15 20:42:10 -08:00
drm_trace_points.c	…
drm_vblank.c	Merge tag 'drm-misc-next-2017-11-30' of git://anongit.freedesktop.org/drm/drm-misc into drm-next	2017-12-04 05:42:49 +10:00
drm_vm.c	…
drm_vma_manager.c	drm/drm_vma_manager.c: Remove useless goto statement	2017-11-02 10:44:08 +01:00