OpenCloudOS-Kernel/drivers/ptp
Vladis Dronov 75718584cb ptp: free ptp device pin descriptors properly
There is a bug in ptp_clock_unregister(), where ptp_cleanup_pin_groups()
first frees ptp->pin_{,dev_}attr, but then posix_clock_unregister() needs
them to destroy a related sysfs device.

These functions can not be just swapped, as posix_clock_unregister() frees
ptp which is needed in the ptp_cleanup_pin_groups(). Fix this by calling
ptp_cleanup_pin_groups() in ptp_clock_release(), right before ptp is freed.

This makes this patch fix an UAF bug in a patch which fixes an UAF bug.

Reported-by: Antti Laakso <antti.laakso@intel.com>
Fixes: a33121e548 ("ptp: fix the race between the release of ptp_clock and cdev")
Link: https://lore.kernel.org/netdev/3d2bd09735dbdaf003585ca376b7c1e5b69a19bd.camel@intel.com/
Signed-off-by: Vladis Dronov <vdronov@redhat.com>
Acked-by: Richard Cochran <richardcochran@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
2020-01-14 10:58:57 -08:00
..
Kconfig ptp: clockmatrix: add I2C dependency 2019-12-13 15:42:09 -08:00
Makefile ptp: Add a ptp clock driver for IDT ClockMatrix. 2019-11-03 17:35:40 -08:00
idt8a340_reg.h ptp: Add a ptp clock driver for IDT ClockMatrix. 2019-11-03 17:35:40 -08:00
ptp_chardev.c ptp: Introduce strict checking of external time stamp options. 2019-11-15 12:48:32 -08:00
ptp_clock.c ptp: free ptp device pin descriptors properly 2020-01-14 10:58:57 -08:00
ptp_clockmatrix.c ptp: ptp_clockmatrix: Fix missing unlock on error in idtcm_probe() 2019-11-06 21:19:59 -08:00
ptp_clockmatrix.h ptp: Add a ptp clock driver for IDT ClockMatrix. 2019-11-03 17:35:40 -08:00
ptp_dte.c ptp: ptp_dte: use devm_platform_ioremap_resource() to simplify code 2019-10-10 16:21:13 -07:00
ptp_ixp46x.c treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 61 2019-05-24 17:36:45 +02:00
ptp_kvm.c treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 157 2019-05-30 11:26:37 -07:00
ptp_pch.c treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 167 2019-05-30 11:26:39 -07:00
ptp_private.h ptp: fix the race between the release of ptp_clock and cdev 2019-12-30 20:19:27 -08:00
ptp_qoriq.c ptp_qoriq: Initialize the registers' spinlock before calling ptp_qoriq_settime 2019-10-02 12:20:38 -04:00
ptp_qoriq_debugfs.c ptp_qoriq: add little enadian support 2019-02-12 12:58:48 -05:00
ptp_sysfs.c treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 61 2019-05-24 17:36:45 +02:00