Kent Gibson 67ccb6b021 gpiolib: cdev: Disallow reconfiguration without direction (uAPI v1) ... [ Upstream commit 9919cce62f68e6ab68dc2a975b5dc670f8ca7d40 ] linehandle_set_config() behaves badly when direction is not set. The configuration validation is borrowed from linehandle_create(), where, to verify the intent of the user, the direction must be set to in order to effect a change to the electrical configuration of a line. But, when applied to reconfiguration, that validation does not allow for the unset direction case, making it possible to clear flags set previously without specifying the line direction. Adding to the inconsistency, those changes are not immediately applied by linehandle_set_config(), but will take effect when the line value is next get or set. For example, by requesting a configuration with no flags set, an output line with GPIOHANDLE_REQUEST_ACTIVE_LOW and GPIOHANDLE_REQUEST_OPEN_DRAIN requested could have those flags cleared, inverting the sense of the line and changing the line drive to push-pull on the next line value set. Ensure the intent of the user by disallowing configurations which do not have direction set, returning an error to userspace to indicate that the configuration is invalid. And, for clarity, use lflags, a local copy of gcnf.flags, throughout when dealing with the requested flags, rather than a mixture of both. Fixes: e588bb1eae ("gpio: add new SET_CONFIG ioctl() to gpio chardev") Signed-off-by: Kent Gibson <warthog618@gmail.com> Link: https://lore.kernel.org/r/20240626052925.174272-2-warthog618@gmail.com Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org> Signed-off-by: Sasha Levin <sashal@kernel.org>		2024-07-05 09:33:54 +02:00
..
accel	kthread: add kthread_stop_put	2024-06-12 11:12:52 +02:00
accessibility	speakup: Fix sizeof() vs ARRAY_SIZE() bug	2024-06-12 11:11:18 +02:00
acpi	ACPI: EC: Evaluate orphan _REG under EC device	2024-06-27 13:49:10 +02:00
amba	…
android	binder: fix max_thread type inconsistency	2024-05-25 16:22:54 +02:00
ata	ata: pata_legacy: make legacy_exit() work again	2024-06-16 13:47:33 +02:00
atm	…
auxdisplay	…
base	drivers: core: synchronize really_probe() and dev_uevent()	2024-06-21 14:38:37 +02:00
bcma	…
block	nbd: Fix signal handling	2024-06-27 13:49:14 +02:00
bluetooth	Bluetooth: ath3k: Fix multiple issues reported by checkpatch.pl	2024-06-27 13:49:02 +02:00
bus	bus: mhi: host: Add MHI_PM_SYS_ERR_FAIL state	2024-04-13 13:07:38 +02:00
cache	cache: ax45mp_cache: Align end size to cache boundary in ax45mp_dma_cache_wback()	2024-03-01 13:35:08 +01:00
cdrom	…
cdx	…
char	tpm_tis: Do *not* flush uninitialized work	2024-06-16 13:47:41 +02:00
clk	clkdev: Update clkdev id usage to allow for longer names	2024-06-21 14:38:38 +02:00
clocksource	clocksource/drivers/arm_global_timer: Fix maximum prescaler value	2024-04-03 15:28:50 +02:00
comedi	comedi: vmk80xx: fix incomplete endpoint checking	2024-04-27 17:11:39 +02:00
connector	…
counter	…
cpufreq	cpufreq: amd-pstate: fix memory leak on CPU EPP exit	2024-06-27 13:49:05 +02:00
cpuidle	cpuidle: Avoid potential overflow in integer multiplication	2024-04-13 13:07:29 +02:00
crypto	crypto: hisilicon/qm - Add the err memory release process to qm uninit	2024-06-27 13:49:00 +02:00
cxl	cxl/region: Fix memregion leaks in devm_cxl_add_region()	2024-06-21 14:38:26 +02:00
dax	…
dca	…
devfreq	…
dio	…
dma	dmaengine: ioatdma: Fix missing kmem_cache_destroy()	2024-06-27 13:49:09 +02:00
dma-buf	dma-buf: handle testing kthreads creation failure	2024-06-21 14:38:40 +02:00
edac	EDAC/igen6: Convert PCIBIOS_* return codes to errnos	2024-06-16 13:47:47 +02:00
eisa	…
extcon	extcon: max8997: select IRQ_DOMAIN instead of depending on it	2024-06-12 11:12:27 +02:00
firewire	firewire: ohci: fulfill timestamp for some local asynchronous transaction	2024-05-17 12:02:30 +02:00
firmware	LoongArch: Fix entry point in kernel image header	2024-06-27 13:49:15 +02:00
fpga	fpga: region: add owner module and take its refcount	2024-06-12 11:12:23 +02:00
fsi	…
gnss	…
gpio	gpiolib: cdev: Disallow reconfiguration without direction (uAPI v1)	2024-07-05 09:33:54 +02:00
gpu	drm/amdgpu: Fix pci state save during mode-1 reset	2024-07-05 09:33:53 +02:00
greybus	greybus: Fix use-after-free bug in gb_interface_release due to race condition.	2024-06-21 14:38:48 +02:00
hid	hid: asus: asus_report_fixup: fix potential read out of bounds	2024-06-27 13:49:15 +02:00
hsi	…
hte	…
hv	Drivers: hv: vmbus: Don't free ring buffers that couldn't be re-encrypted	2024-05-17 12:02:17 +02:00
hwmon	hwmon: (shtc1) Fix property misspelling	2024-06-12 11:13:00 +02:00
hwspinlock	…
hwtracing	intel_th: pci: Add Lunar Lake support	2024-06-21 14:38:43 +02:00
i2c	i2c: ocores: set IACK bit after core is enabled	2024-06-27 13:49:13 +02:00
i3c	i3c: master: svc: fix invalidate IBI type and miss call client IBI handler	2024-06-16 13:47:46 +02:00
idle	…
iio	iio: pressure: bmp280: Fix BMP580 temperature reading	2024-07-05 09:33:42 +02:00
infiniband	RDMA/restrack: Fix potential invalid address access	2024-07-05 09:33:51 +02:00
input	Input: ili210x - fix ili251x_read_touch_data() return value	2024-07-05 09:33:43 +02:00
interconnect	interconnect: qcom: qcm2290: Fix mas_snoc_bimc QoS port assignment	2024-06-12 11:12:18 +02:00
iommu	iommu/arm-smmu-v3: Free MSIs in case of ENOMEM	2024-06-27 13:49:03 +02:00
ipack	…
irqchip	irqchip/loongson: Select GENERIC_IRQ_EFFECTIVE_AFF_MASK if SMP for IRQ_LOONGARCH_CPU	2024-07-05 09:33:52 +02:00
isdn	…
leds	leds: pwm: Disable PWM when going to suspend	2024-06-12 11:12:24 +02:00
macintosh	macintosh/via-macii: Fix "BUG: sleeping function called from invalid context"	2024-06-12 11:11:47 +02:00
mailbox	…
mcb	…
md	md/raid5: fix deadlock that raid5d() wait for itself to clear MD_SB_CHANGE_PENDING	2024-06-16 13:47:34 +02:00
media	media: dvbdev: Initialize sbuf	2024-07-05 09:33:52 +02:00
memory	memory: tegra: Correct DLA client names	2024-03-26 18:19:32 -04:00
memstick	…
message	…
mfd	mfd: cs42l43: Fix wrong GPIO_FN_SEL and SPI_CLK_CONFIG1 defaults	2024-03-26 18:19:55 -04:00
misc	misc: microchip: pci1xxxx: Fix a memory leak in the error handling of gp_aux_bus_probe()	2024-06-21 14:38:49 +02:00
mmc	mmc: sdhci-acpi: Add quirk to enable pull-up on the card-detect GPIO on Asus T100TA	2024-06-16 13:47:37 +02:00
most	…
mtd	mtd: partitions: redboot: Added conversion of operands to a larger type	2024-07-05 09:33:51 +02:00
mux	…
net	net/dpaa2: Avoid explicit cpumask var allocation on stack	2024-07-05 09:33:51 +02:00
nfc	NFC: trf7970a: disable all regulators on removal	2024-05-02 16:32:36 +02:00
ntb	NTB: fix possible name leak in ntb_register_device()	2024-03-26 18:19:48 -04:00
nubus	…
nvdimm	…
nvme	nvmet-passthru: propagate status from id override functions	2024-06-21 14:38:35 +02:00
nvmem	nvmem: add explicit config option to read old syntax fixed OF cells	2024-05-17 12:01:55 +02:00
of	of: module: add buffer overflow check in of_modalias()	2024-06-12 11:12:10 +02:00
opp	OPP: debugfs: Fix warning around icc_get_name()	2024-03-26 18:19:40 -04:00
parisc	…
parport	…
pci	PCI: Do not wait for disconnected devices when resuming	2024-06-27 13:49:05 +02:00
pcmcia	…
peci	…
perf	perf/arm-dmc620: Fix lockdep assert in ->event_init()	2024-06-12 11:12:46 +02:00
phy	phy: qcom: qmp-combo: fix duplicate return in qmp_v4_configure_dp_phy	2024-06-12 11:12:14 +02:00
pinctrl	pinctrl: rockchip: fix pinmux reset in rockchip_pmx_set	2024-07-05 09:33:44 +02:00
platform	platform/x86: p2sb: Don't init until unassigned resources have been assigned	2024-06-27 13:49:03 +02:00
pmdomain	pmdomain: ti-sci: Fix duplicate PD referrals	2024-06-21 14:38:44 +02:00
pnp	…
power	power: supply: cros_usbpd: provide ID table for avoiding fallback match	2024-06-27 13:49:03 +02:00
powercap	powercap: intel_rapl_tpmi: Fix System Domain probing	2024-04-03 15:28:19 +02:00
pps	…
ps3	…
ptp	ptp: fix integer overflow in max_vclocks_store	2024-06-27 13:49:07 +02:00
pwm	pwm: Rename pwm_apply_state() to pwm_apply_might_sleep()	2024-06-12 11:12:24 +02:00
rapidio	…
ras	…
regulator	regulator: bd71815: fix ramp values	2024-06-27 13:49:09 +02:00
remoteproc	remoteproc: k3-r5: Jump to error handling labels in start/stop errors	2024-06-21 14:38:47 +02:00
reset	…
rpmsg	…
rtc	nvmem: add explicit config option to read old syntax fixed OF cells	2024-05-17 12:01:55 +02:00
s390	s390/ap: Fix crash in AP internal function modify_bitmap()	2024-06-16 13:47:46 +02:00
sbus	…
scsi	scsi: qedi: Fix crash while reading debugfs attribute	2024-06-27 13:49:01 +02:00
sh	…
siox	…
slimbus	slimbus: qcom-ngd-ctrl: Add timeout for wait operation	2024-05-17 12:02:33 +02:00
soc	soc: ti: wkup_m3_ipc: Send NULL dummy message instead of pointer message	2024-07-05 09:33:52 +02:00
soundwire	soundwire: cadence: fix invalid PDI offset	2024-06-12 11:12:15 +02:00
spi	spi: stm32: qspi: Clamp stm32_qspi_get_mode() output to CCR_BUSWIDTH_4	2024-06-27 13:49:14 +02:00
spmi	spmi: hisi-spmi-controller: Do not override device identifier	2024-06-21 14:38:40 +02:00
ssb	ssb: Fix potential NULL pointer dereference in ssb_device_uevent()	2024-06-27 13:49:01 +02:00
staging	greybus: arche-ctrl: move device table to its right location	2024-06-12 11:12:17 +02:00
target	scsi: target: Fix SELinux error when systemd-modules loads the target module	2024-05-17 12:02:15 +02:00
tc	…
tee	tee: optee: Fix kernel panic caused by incorrect error handling	2024-04-03 15:28:44 +02:00
thermal	thermal/drivers/mediatek/lvts_thermal: Return error in case of invalid efuse data	2024-06-27 13:49:09 +02:00
thunderbolt	thunderbolt: debugfs: Fix margin debugfs node creation condition	2024-06-21 14:38:25 +02:00
tty	serial: 8250_dw: Revert "Move definitions to the shared header"	2024-06-27 13:49:13 +02:00
ufs	scsi: ufs: core: Free memory allocated for model before reinit	2024-06-27 13:49:11 +02:00
uio	uio_hv_generic: Don't free decrypted memory	2024-05-17 12:02:17 +02:00
usb	usb: typec: ucsi: Ack also failed Get Error commands	2024-07-05 09:33:43 +02:00
vdpa	vduse: Temporarily fail if control queue feature requested	2024-07-05 09:33:50 +02:00
vfio	vfio/pci: Collect hot-reset devices to local buffer	2024-06-27 13:49:05 +02:00
vhost	vhost: Add smp_rmb() in vhost_enable_notify()	2024-04-17 11:19:35 +02:00
video	fbdev: savage: Handle err return when savagefb_check_var failed	2024-06-16 13:47:37 +02:00
virt	drivers/virt/acrn: fix PFNMAP PTE checks in acrn_vm_ram_map()	2024-06-12 11:12:09 +02:00
virtio	virtio: delete vq in vp_find_vqs_msix() when request_irq() fails	2024-06-12 11:12:49 +02:00
vlynq	…
w1	nvmem: add explicit config option to read old syntax fixed OF cells	2024-05-17 12:01:55 +02:00
watchdog	watchdog: rti_wdt: Set min_hw_heartbeat_ms to accommodate a safety margin	2024-06-16 13:47:43 +02:00
xen	drivers/xen: Improve the late XenStore init protocol	2024-06-12 11:12:51 +02:00
zorro	…
Kconfig	…
Makefile	…