OpenCloudOS-Kernel/drivers/net/ethernet/intel/igb
Andi Kleen 58e4e1f6ca igb: Avoid uninitialized advertised variable in eee_set_cur
eee_get_cur assumes that the output data is already zeroed. It can
read-modify-write the advertised field:

              if (ipcnfg & E1000_IPCNFG_EEE_100M_AN)
2594			edata->advertised |= ADVERTISED_100baseT_Full;

This is ok for the normal ethtool eee_get call, which always
zeroes the input data before.

But eee_set_cur also calls eee_get_cur and it did not zero the input
field. Later on it then compares agsinst the field, which can contain partial
stack garbage.

Zero the input field in eee_set_cur() too.

Cc: jeffrey.t.kirsher@intel.com
Cc: netdev@vger.kernel.org
Signed-off-by: Andi Kleen <ak@linux.intel.com>
Acked-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
2013-10-02 16:31:48 -04:00
..
Makefile igb: Copyright string update to year 2013 2013-01-19 05:05:05 -08:00
e1000_82575.c igb: Add additional get_phy_id call for i354 devices 2013-09-12 16:24:55 -04:00
e1000_82575.h igb: Add support for i354 devices 2013-04-18 16:40:35 -07:00
e1000_defines.h igb: New PHY_ID for i354 device 2013-09-04 04:57:13 -07:00
e1000_hw.h igb: Add device support for flashless SKU of i210 device 2013-08-22 02:26:06 -07:00
e1000_i210.c igb: Refactor NVM read functions to accommodate devices with no flash 2013-08-22 02:26:00 -07:00
e1000_i210.h igb: Refactor NVM read functions to accommodate devices with no flash 2013-08-22 02:26:00 -07:00
e1000_mac.c igb: Read flow control for i350 from correct EEPROM section 2013-09-12 16:24:55 -04:00
e1000_mac.h igb: Fix code comments and whitespace 2013-04-18 16:40:25 -07:00
e1000_mbx.c igb: Fix code comments and whitespace 2013-04-18 16:40:25 -07:00
e1000_mbx.h igb: Fix code comments and whitespace 2013-04-18 16:40:25 -07:00
e1000_nvm.c igb: Fix get_fw_version function for all parts 2013-08-22 02:26:09 -07:00
e1000_nvm.h igb: Fix get_fw_version function for all parts 2013-08-22 02:26:09 -07:00
e1000_phy.c igb: M88E1543 PHY downshift implementation 2013-09-04 05:04:31 -07:00
e1000_phy.h igb: Support for SFP modules discovery 2013-05-21 02:37:36 -07:00
e1000_regs.h igb: Add support for i354 devices 2013-04-18 16:40:35 -07:00
igb.h igb: Implementation of 1-sec delay for i210 devices 2013-09-04 03:53:53 -07:00
igb_ethtool.c igb: Avoid uninitialized advertised variable in eee_set_cur 2013-10-02 16:31:48 -04:00
igb_hwmon.c igb: Fix code comments and whitespace 2013-04-18 16:40:25 -07:00
igb_main.c igb: Update version number 2013-09-04 05:49:27 -07:00
igb_ptp.c igb: Read register for latch_on without return value 2013-08-22 02:25:25 -07:00