Olga Kornievskaia 9b332c7229 SUNRPC: add a missing rpc_stat for TCP TLS ... [ Upstream commit 8e088a20dbe33919695a8082c0b32deb62d23b4a ] Commit 1548036ef120 ("nfs: make the rpc_stat per net namespace") added functionality to specify rpc_stats function but missed adding it to the TCP TLS functionality. As the result, mounting with xprtsec=tls lead to the following kernel oops. [ 128.984192] Unable to handle kernel NULL pointer dereference at virtual address 000000000000001c [ 128.985058] Mem abort info: [ 128.985372] ESR = 0x0000000096000004 [ 128.985709] EC = 0x25: DABT (current EL), IL = 32 bits [ 128.986176] SET = 0, FnV = 0 [ 128.986521] EA = 0, S1PTW = 0 [ 128.986804] FSC = 0x04: level 0 translation fault [ 128.987229] Data abort info: [ 128.987597] ISV = 0, ISS = 0x00000004, ISS2 = 0x00000000 [ 128.988169] CM = 0, WnR = 0, TnD = 0, TagAccess = 0 [ 128.988811] GCS = 0, Overlay = 0, DirtyBit = 0, Xs = 0 [ 128.989302] user pgtable: 4k pages, 48-bit VAs, pgdp=0000000106c84000 [ 128.990048] [000000000000001c] pgd=0000000000000000, p4d=0000000000000000 [ 128.990736] Internal error: Oops: 0000000096000004 [#1] SMP [ 128.991168] Modules linked in: nfs_layout_nfsv41_files rpcsec_gss_krb5 auth_rpcgss nfsv4 dns_resolver nfs lockd grace netfs uinput dm_mod nft_fib_inet nft_fib_ipv4 nft_fib_ipv6 nft_fib nft_reject_inet nf_reject_ipv4 nf_reject_ipv6 nft_reject nft_ct nft_chain_nat nf_nat nf_conntrack nf_defrag_ipv6 nf_defrag_ipv4 rfkill ip_set nf_tables nfnetlink qrtr vsock_loopback vmw_vsock_virtio_transport_common vmw_vsock_vmci_transport vsock sunrpc vfat fat uvcvideo videobuf2_vmalloc videobuf2_memops uvc videobuf2_v4l2 videodev videobuf2_common mc vmw_vmci xfs libcrc32c e1000e crct10dif_ce ghash_ce sha2_ce vmwgfx nvme sha256_arm64 nvme_core sr_mod cdrom sha1_ce drm_ttm_helper ttm drm_kms_helper drm sg fuse [ 128.996466] CPU: 0 PID: 179 Comm: kworker/u4:26 Kdump: loaded Not tainted 6.8.0-rc6+ #12 [ 128.997226] Hardware name: VMware, Inc. VMware20,1/VBSA, BIOS VMW201.00V.21805430.BA64.2305221830 05/22/2023 [ 128.998084] Workqueue: xprtiod xs_tcp_tls_setup_socket [sunrpc] [ 128.998701] pstate: 81400005 (Nzcv daif +PAN -UAO -TCO +DIT -SSBS BTYPE=--) [ 128.999384] pc : call_start+0x74/0x138 [sunrpc] [ 128.999809] lr : __rpc_execute+0xb8/0x3e0 [sunrpc] [ 129.000244] sp : ffff8000832b3a00 [ 129.000508] x29: ffff8000832b3a00 x28: ffff800081ac79c0 x27: ffff800081ac7000 [ 129.001111] x26: 0000000004248060 x25: 0000000000000000 x24: ffff800081596008 [ 129.001757] x23: ffff80007b087240 x22: ffff00009a509d30 x21: 0000000000000000 [ 129.002345] x20: ffff000090075600 x19: ffff00009a509d00 x18: ffffffffffffffff [ 129.002912] x17: 733d4d4554535953 x16: 42555300312d746e x15: ffff8000832b3a88 [ 129.003464] x14: ffffffffffffffff x13: ffff8000832b3a7d x12: 0000000000000008 [ 129.004021] x11: 0101010101010101 x10: ffff8000150cb560 x9 : ffff80007b087c00 [ 129.004577] x8 : ffff00009a509de0 x7 : 0000000000000000 x6 : 00000000be8c4ee3 [ 129.005026] x5 : 0000000000000000 x4 : 0000000000000000 x3 : ffff000094d56680 [ 129.005425] x2 : ffff80007b0637f8 x1 : ffff000090075600 x0 : ffff00009a509d00 [ 129.005824] Call trace: [ 129.005967] call_start+0x74/0x138 [sunrpc] [ 129.006233] __rpc_execute+0xb8/0x3e0 [sunrpc] [ 129.006506] rpc_execute+0x160/0x1d8 [sunrpc] [ 129.006778] rpc_run_task+0x148/0x1f8 [sunrpc] [ 129.007204] tls_probe+0x80/0xd0 [sunrpc] [ 129.007460] rpc_ping+0x28/0x80 [sunrpc] [ 129.007715] rpc_create_xprt+0x134/0x1a0 [sunrpc] [ 129.007999] rpc_create+0x128/0x2a0 [sunrpc] [ 129.008264] xs_tcp_tls_setup_socket+0xdc/0x508 [sunrpc] [ 129.008583] process_one_work+0x174/0x3c8 [ 129.008813] worker_thread+0x2c8/0x3e0 [ 129.009033] kthread+0x100/0x110 [ 129.009225] ret_from_fork+0x10/0x20 [ 129.009432] Code: f0ffffc2 911fe042 aa1403e1 aa1303e0 (b9401c83) Fixes: 1548036ef120 ("nfs: make the rpc_stat per net namespace") Signed-off-by: Olga Kornievskaia <kolga@netapp.com> Signed-off-by: Trond Myklebust <trond.myklebust@hammerspace.com> Signed-off-by: Sasha Levin <sashal@kernel.org>		2024-05-17 12:02:20 +02:00
..
auth_gss	SUNRPC: fix some memleaks in gssx_dec_option_array	2024-03-26 18:19:36 -04:00
xprtrdma	svcrdma: Drop connection after an RDMA Read error	2023-11-28 17:20:02 +00:00
.kunitconfig	SUNRPC: Remove RPCSEC_GSS_KRB5_ENCTYPES_DES	2023-08-29 17:45:22 -04:00
Kconfig	SUNRPC: Remove CONFIG_RPCSEC_GSS_KRB5_CRYPTOSYSTEM	2023-08-29 17:45:22 -04:00
Makefile	SUNRPC: Add RPC client support for the RPC_AUTH_TLS auth flavor	2023-06-19 12:18:36 -04:00
addr.c	net: sunrpc: Fix an off by one in rpc_sockaddr2uaddr()	2024-03-26 18:20:01 -04:00
auth.c	cred: get rid of CONFIG_DEBUG_CREDENTIALS	2023-12-20 17:01:51 +01:00
auth_null.c	SUNRPC: Add rpc_auth::au_ralign field	2019-02-14 11:48:36 -05:00
auth_tls.c	SUNRPC: Fail quickly when server does not recognize TLS	2023-09-27 15:16:40 -04:00
auth_unix.c	SUNRPC: Fix unx_lookup_cred() allocation	2022-03-22 15:52:55 -04:00
backchannel_rqst.c	NFS client updates for Linux 5.20	2022-08-10 14:04:32 -07:00
cache.c	treewide: use get_random_u32_below() instead of deprecated function	2022-11-18 02:15:15 +01:00
clnt.c	sunrpc: add a struct rpc_stats arg to rpc_create_args	2024-05-17 12:01:57 +02:00
debugfs.c	SUNRPC: Cache deferral injection	2022-05-19 12:25:38 -04:00
fail.h	SUNRPC: Cache deferral injection	2022-05-19 12:25:38 -04:00
netns.h	SUNRPC: Fix occasional warning when destroying gss_krb5_enctypes	2023-02-20 09:20:57 -05:00
rpc_pipe.c	sunrpc: convert to ctime accessor functions	2023-07-24 10:30:07 +02:00
rpcb_clnt.c	SUNRPC: Add an IS_ERR() check back to where it was	2023-11-28 17:19:48 +00:00
sched.c	SUNRPC: Don't change task->tk_status after the call to rpc_exit_task	2023-05-19 16:50:05 -04:00
socklib.c	use less confusing names for iov_iter direction initializers	2022-11-25 13:01:55 -05:00
socklib.h	SUNRPC: Refactor xs_sendpages()	2020-03-16 12:04:33 -04:00
stats.c	SUNRPC: Use per-CPU counters to tally server RPC counts	2023-02-20 09:20:32 -05:00
sunrpc.h	treewide: Replace GPLv2 boilerplate/reference with SPDX - gpl-2.0_149.RULE	2022-06-10 14:51:35 +02:00
sunrpc_syms.c	sunrpc: add IDs to multipath	2021-07-08 14:03:23 -04:00
svc.c	NFS CLient Updates for Linux 6.6	2023-08-31 15:36:41 -07:00
svc_xprt.c	SUNRPC: Revert 5f7fc5d69f	2024-01-01 12:42:26 +00:00
svcauth.c	SUNRPC: Add enum svc_auth_status	2023-08-29 17:45:22 -04:00
svcauth_unix.c	SUNRPC: Add enum svc_auth_status	2023-08-29 17:45:22 -04:00
svcsock.c	SUNRPC: Fix a slow server-side memory leak with RPC-over-TCP	2024-04-10 16:36:01 +02:00
sysctl.c	sunrpc: simplify one-level sysctl registration for debug_table	2023-04-11 12:45:19 -04:00
sysfs.c	SUNRPC: Add a TCP-with-TLS RPC transport class	2023-06-19 12:28:10 -04:00
sysfs.h	NFS: Add sysfs links to sunrpc clients for nfs_clients	2023-06-19 15:04:13 -04:00
timer.c	treewide: Add SPDX license identifier for missed files	2019-05-21 10:50:45 +02:00
xdr.c	NFS CLient Updates for Linux 6.6	2023-08-31 15:36:41 -07:00
xprt.c	timers: Get rid of del_singleshot_timer_sync()	2022-11-24 15:09:10 +01:00
xprtmultipath.c	SUNRPC: Fix a suspicious RCU usage warning	2024-02-05 20:14:17 +00:00
xprtsock.c	SUNRPC: add a missing rpc_stat for TCP TLS	2024-05-17 12:02:20 +02:00