Namhyung Kim c418d7a675 perf lock contention: Add a missing NULL check ... [ Upstream commit f3408580bac8ce5cd76e7391e529c0a22e7c7eb2 ] I got a report for a failure in BPF verifier on a recent kernel with perf lock contention command. It checks task->sighand->siglock without checking if sighand is NULL or not. Let's add one. ; if (&curr->sighand->siglock == (void *)lock) 265: (79) r1 = *(u64 *)(r0 +2624) ; frame1: R0_w=trusted_ptr_task_struct(off=0,imm=0) ; R1_w=rcu_ptr_or_null_sighand_struct(off=0,imm=0) 266: (b7) r2 = 0 ; frame1: R2_w=0 267: (0f) r1 += r2 R1 pointer arithmetic on rcu_ptr_or_null_ prohibited, null-check it first processed 164 insns (limit 1000000) max_states_per_insn 1 total_states 15 peak_states 15 mark_read 5 -- END PROG LOAD LOG -- libbpf: prog 'contention_end': failed to load: -13 libbpf: failed to load object 'lock_contention_bpf' libbpf: failed to load BPF skeleton 'lock_contention_bpf': -13 Failed to load lock-contention BPF skeleton lock contention BPF setup failed lock contention did not detect any lock contention Fixes: 1811e82767 ("perf lock contention: Track and show siglock with address") Reviewed-by: Ian Rogers <irogers@google.com> Acked-by: Arnaldo Carvalho de Melo <acme@redhat.com> Cc: Song Liu <song@kernel.org> Cc: bpf@vger.kernel.org Signed-off-by: Namhyung Kim <namhyung@kernel.org> Link: https://lore.kernel.org/r/20240409225542.1870999-1-namhyung@kernel.org Signed-off-by: Sasha Levin <sashal@kernel.org>		2024-04-27 17:11:34 +02:00
..
vmlinux	perf tools: Do not ignore the default vmlinux.h	2023-11-20 11:59:28 +01:00
.gitignore	perf build: Add ability to build with a generated vmlinux.h	2023-06-23 21:35:45 -07:00
augmented_raw_syscalls.bpf.c	perf trace: Use the right bpf_probe_read(_str) variant for reading user data	2023-11-20 11:59:28 +01:00
bench_uprobe.bpf.c	perf bench uprobe trace_printk: Add entry attaching an BPF program that does a trace_printk	2023-07-20 11:33:24 -03:00
bperf_cgroup.bpf.c	perf stat: Support old kernels for bperf cgroup counting	2022-10-14 10:29:05 -03:00
bperf_follower.bpf.c	perf bpf_skel: Do not use typedef to avoid error on old clang	2021-12-06 21:57:53 -03:00
bperf_leader.bpf.c	perf bpf_skel: Do not use typedef to avoid error on old clang	2021-12-06 21:57:53 -03:00
bperf_u.h	perf stat: Introduce 'bperf' to share hardware PMCs with BPF	2021-03-23 17:46:44 -03:00
bpf_prog_profiler.bpf.c	perf bpf: Fix building perf with BUILD_BPF_SKEL=1 by default in more distros	2021-12-06 21:57:53 -03:00
func_latency.bpf.c	perf ftrace latency: Add -n/--use-nsec option	2022-03-22 17:43:46 -03:00
kwork_trace.bpf.c	perf kwork: Add workqueue trace BPF support	2022-07-26 16:31:54 -03:00
lock_contention.bpf.c	perf lock contention: Add a missing NULL check	2024-04-27 17:11:34 +02:00
lock_data.h	perf lock contention: Update default map size to 16384	2023-04-06 21:52:27 -03:00
off_cpu.bpf.c	perf test: Fix offcpu test prev_state check	2023-02-19 07:58:23 -03:00
sample-filter.h	perf bpf filter: Add logical OR operator	2023-03-15 11:08:36 -03:00
sample_filter.bpf.c	perf bpf filter: Fix a broken perf sample data naming for BPF CO-RE	2023-05-26 15:21:08 -03:00