Xingui Yang 34579739f9 scsi: libsas: Fix the failure of adding phy with zero-address to port ... commit 06036a0a5db34642c5dbe22021a767141f010b7a upstream. As of commit 7d1d865181 ("[SCSI] libsas: fix false positive 'device attached' conditions"), reset the phy->entacted_sas_addr address to a zero-address when the link rate is less than 1.5G. Currently we find that when a new device is attached, and the link rate is less than 1.5G, but the device type is not NO_DEVICE, for example: the link rate is SAS_PHY_RESET_IN_PROGRESS and the device type is stp. After setting the phy->entacted_sas_addr address to the zero address, the port will continue to be created for the phy with the zero-address, and other phys with the zero-address will be tried to be added to the new port: [562240.051197] sas: ex 500e004aaaaaaa1f phy19:U:0 attached: 0000000000000000 (no device) // phy19 is deleted but still on the parent port's phy_list [562240.062536] sas: ex 500e004aaaaaaa1f phy0 new device attached [562240.062616] sas: ex 500e004aaaaaaa1f phy00:U:5 attached: 0000000000000000 (stp) [562240.062680] port-7:7:0: trying to add phy phy-7:7:19 fails: it's already part of another port Therefore, it should be the same as sas_get_phy_attached_dev(). Only when device_type is SAS_PHY_UNUSED, sas_address is set to the 0 address. Fixes: 7d1d865181 ("[SCSI] libsas: fix false positive 'device attached' conditions") Signed-off-by: Xingui Yang <yangxingui@huawei.com> Link: https://lore.kernel.org/r/20240312141103.31358-5-yangxingui@huawei.com Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com> Signed-off-by: Jianping Liu <frankjpliu@tencent.com>		2024-11-14 19:54:10 +08:00
..
Kconfig	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 167	2019-05-30 11:26:39 -07:00
Makefile	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 167	2019-05-30 11:26:39 -07:00
sas_ata.c	tkernel: sync code to the same with tk4 pub/lts/0017-kabi	2024-06-12 13:13:20 +08:00
sas_discover.c	scsi: libsas: Abort all in-flight requests when device is gone	2024-11-14 19:54:09 +08:00
sas_event.c	tkernel: sync code to the same with tk4 pub/lts/0017-kabi	2024-06-12 13:13:20 +08:00
sas_expander.c	scsi: libsas: Fix the failure of adding phy with zero-address to port	2024-11-14 19:54:10 +08:00
sas_host_smp.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 372	2019-06-05 17:37:10 +02:00
sas_init.c	tkernel: sync code to the same with tk4 pub/lts/0017-kabi	2024-06-12 13:13:20 +08:00
sas_internal.h	scsi: libsas: Fix exp-attached device scan after probe failure scanned in again after probe failed	2024-11-14 19:54:09 +08:00
sas_phy.c	SCSI misc on 20190709	2019-07-11 15:14:01 -07:00
sas_port.c	tkernel: sync code to the same with tk4 pub/lts/0017-kabi	2024-06-12 13:13:20 +08:00
sas_scsi_host.c	tkernel: sync code to the same with tk4 pub/lts/0017-kabi	2024-06-12 13:13:20 +08:00
sas_task.c	scsi: libsas: add a SPDX tag to sas_task.c	2019-05-21 06:16:22 -04:00