This patch remove variables that are initialized with a constant,
are never updated, and are only used as parameter of return.
Return the constant instead of using a variable.
Verified by compilation only.
The coccinelle script that find and fixes this issue is:
// <smpl>
@@
type T;
constant C;
identifier ret;
@@
- T ret = C;
... when != ret
when strict
return
- ret
+ C
;
// </smpl>
Signed-off-by: Peter Senna Tschudin <peter.senna@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Use the normal mechanism for emitting a function name.
Signed-off-by: Joe Perches <joe@perches.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This patch outsources the big PHS-rule-applying code chunk into a
function.
It also replaces member accessing by using variables.
Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This patch replaces long object->member.member foo by variable useage.
Increases the reading experience a lot by introducing only one variable
(as it decreases the whoa-wall-of-text experience).
Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This patch outsources the code from the IsFlash2x() check in
bcm_char_ioctl_nvm_rw() function to shorten it.
Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This patch outsourced the true-branch for the IOCTL_BCM_NVM_READ command
handling to shorten the bcm_char_ioctl_nvm_rw() function.
Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Fixes code style errors in drivers/staging/bcm/Qos.c
Signed-off-by: Marcos A. Di Pietro <marcosadp@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Just cleaned up a few issues presented by checkpatch in InterfaceMisc.h.
I converted some spaces to tabs, and removed unnecessary whitespace. The
kernel version I am using linux-next-20140411.
Signed-off-by: Julian Gindi <juliangindi@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Fixed badly placed and unnecessary braces.
PS: Performed as task 10 of the Eudyptula Challenge.
Signed-off-by: Luis Ortega <luiorpe1@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Remove the temp bracing afixed to case labels.
Properly indent switch/case breaks.
Signed-off-by: Gary Alan Rookard <garyrookard@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Fix checkpatch.pl issues with line over 80 characters in Adapter.h
Signed-off-by: Heena Sirwani <heenasirwani@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Firstly, some background is needed to confirm the validity of
this patch as error fixing. It seems the developer when writing
this driver from scratch, used what are known to me as error
suppressors in the form of extra tmp bracing added to the case labels.
They aid during construction time, but are not intended to remain.
In this scenario there are declarations occupying space only
reserved for statements. If these tmp braces were to be removed
before the declarations in question were reassigned to there
proper place in the funtion, compile time errors would result.
So, having that said, I moved the declarations,
UINT uiSearchRuleIndex = 0; and ULONG ulSFID;,
and also deleted the duplicates thereof from
the switch/case statement.
Removed temporary bracing from case labels.
Removed new lines as needed.
Properly indented case breaks.
Added /* FALLTHROUGH */ comments to switch/case.
Signed-off-by: Gary Rookard <garyrookard@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Removes needless boolean TRUE and false comparisons and reflows some lines to
eliminate over 80 character if statments.
Signed-off-by: Jade Bilkey <herself@thefumon.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cleans up a few needless comparisons with booleans and cleans up an
interupt handler to take advantage of earlier bailout shortcircuit.
Signed-off-by: Jade Bilkey <herself@thefumon.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Fixes checkpatch.pl warnings and errors:
ERROR: that open brace { should be on the previous line
+ if (!psIntfAdapter->psInterruptUrb)
+ {
WARNING: line over 80 characters
+ BCM_DEBUG_PRINT(psIntfAdapter->psAdapter,DBG_TYPE_OTHERS, INTF_INIT, DBG_LVL_ALL,"Cannot allocate interrupt urb");
ERROR: space required after that ',' (ctx:VxV)
+ BCM_DEBUG_PRINT(psIntfAdapter->psAdapter,DBG_TYPE_OTHERS, INTF_INIT, DBG_LVL_ALL,"Cannot allocate interrupt urb");
^
ERROR: space required after that ',' (ctx:VxV)
+ BCM_DEBUG_PRINT(psIntfAdapter->psAdapter,DBG_TYPE_OTHERS, INTF_INIT, DBG_LVL_ALL,"Cannot allocate interrupt urb");
^
WARNING: line over 80 characters
+ psIntfAdapter->ulInterruptData;
WARNING: line over 80 characters
+ sizeof(psIntfAdapter->ulInterruptData);
WARNING: line over 80 characters
+ psIntfAdapter->sIntrIn.int_in_endpointAddr);
WARNING: line over 80 characters
+ psIntfAdapter->psInterruptUrb->transfer_buffer,
WARNING: line over 80 characters
+ psIntfAdapter->psInterruptUrb->transfer_buffer_length,
WARNING: line over 80 characters
+ BCM_DEBUG_PRINT(psIntfAdapter->psAdapter,DBG_TYPE_OTHERS, INTF_INIT, DBG_LVL_ALL,"Interrupt Interval: %d\n",
ERROR: space required after that ',' (ctx:VxV)
+ BCM_DEBUG_PRINT(psIntfAdapter->psAdapter,DBG_TYPE_OTHERS, INTF_INIT, DBG_LVL_ALL,"Interrupt Interval: %d\n",
^
ERROR: space required after that ',' (ctx:VxV)
+ BCM_DEBUG_PRINT(psIntfAdapter->psAdapter,DBG_TYPE_OTHERS, INTF_INIT, DBG_LVL_ALL,"Interrupt Interval: %d\n",
^
ERROR: that open brace { should be on the previous line
+ if( false == psIntfAdapter->psAdapter->device_removed &&
+ false == psIntfAdapter->psAdapter->bEndPointHalted &&
+ false == psIntfAdapter->bSuspended &&
+ false == psIntfAdapter->bPreparingForBusSuspend &&
+ false == psIntfAdapter->psAdapter->StopAllXaction)
+ {
ERROR: space prohibited after that open parenthesis '('
+ if( false == psIntfAdapter->psAdapter->device_removed &&
ERROR: space required before the open parenthesis '('
+ if( false == psIntfAdapter->psAdapter->device_removed &&
WARNING: line over 80 characters
+ status = usb_submit_urb(psIntfAdapter->psInterruptUrb, GFP_ATOMIC);
ERROR: that open brace { should be on the previous line
+ if (status)
+ {
WARNING: line over 80 characters
+ BCM_DEBUG_PRINT(psIntfAdapter->psAdapter,DBG_TYPE_OTHERS, INTF_INIT, DBG_LVL_ALL,"Cannot send int urb %d\n", status);
ERROR: space required after that ',' (ctx:VxV)
+ BCM_DEBUG_PRINT(psIntfAdapter->psAdapter,DBG_TYPE_OTHERS, INTF_INIT, DBG_LVL_ALL,"Cannot send int urb %d\n", status);
^
ERROR: space required after that ',' (ctx:VxV)
+ BCM_DEBUG_PRINT(psIntfAdapter->psAdapter,DBG_TYPE_OTHERS, INTF_INIT, DBG_LVL_ALL,"Cannot send int urb %d\n", status);
^
ERROR: that open brace { should be on the previous line
+ if(status == -EPIPE)
+ {
ERROR: space required before the open parenthesis '('
+ if(status == -EPIPE)
WARNING: line over 80 characters
+ psIntfAdapter->psAdapter->bEndPointHalted = TRUE ;
WARNING: space prohibited before semicolon
+ psIntfAdapter->psAdapter->bEndPointHalted = TRUE ;
WARNING: line over 80 characters
+ wake_up(&psIntfAdapter->psAdapter->tx_packet_wait_queue);
Signed-off-by: Jade Bilkey <herself@thefumon.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Fixes checkpatch.pl warnings and errors:
ERROR: switch and case should be at the same indent
+ switch (status) {
[...]
+ case STATUS_SUCCESS:
[...]
+ case -ENOENT :
[...]
+ case -EINPROGRESS:
[...]
+ case -EPIPE:
[...]
+ case -ECONNRESET: //URB got unlinked.
+ case -ESHUTDOWN: // hardware gone. this is the serious problem.
[...]
+ case -ENODEV : //Device got removed
+ case -EINVAL : //Some thing very bad happened with the URB. No description is available.
[...]
+ default:
ERROR: that open brace { should be on the previous line
+ if ( urb->actual_length )
+ {
ERROR: space prohibited after that open parenthesis '('
+ if ( urb->actual_length )
ERROR: space prohibited before that close parenthesis ')'
+ if ( urb->actual_length )
ERROR: that open brace { should be on the previous line
+ if(psIntfAdapter->ulInterruptData[1] & 0xFF)
+ {
ERROR: space required before the open parenthesis '('
+ if(psIntfAdapter->ulInterruptData[1] & 0xFF)
WARNING: line over 80 characters
+ BCM_DEBUG_PRINT(Adapter,DBG_TYPE_OTHERS, INTF_INIT, DBG_LVL_ALL, "Got USIM interrupt");
ERROR: space required after that ',' (ctx:VxV)
+ BCM_DEBUG_PRINT(Adapter,DBG_TYPE_OTHERS, INTF_INIT, DBG_LVL_ALL, "Got USIM interrupt");
^
ERROR: that open brace { should be on the previous line
+ if(psIntfAdapter->ulInterruptData[1] & 0xFF00)
+ {
ERROR: space required before the open parenthesis '('
+ if(psIntfAdapter->ulInterruptData[1] & 0xFF00)
WARNING: line over 80 characters
+ (psIntfAdapter->ulInterruptData[1] & 0xFF00) >> 8);
WARNING: space prohibited between function name and open parenthesis '('
+ atomic_set (&Adapter->uiMBupdate, TRUE);
WARNING: line over 80 characters
+ BCM_DEBUG_PRINT(Adapter,DBG_TYPE_OTHERS, INTF_INIT, DBG_LVL_ALL, "TX mailbox contains %d",
ERROR: space required after that ',' (ctx:VxV)
+ BCM_DEBUG_PRINT(Adapter,DBG_TYPE_OTHERS, INTF_INIT, DBG_LVL_ALL, "TX mailbox contains %d",
^
+ atomic_read(&Adapter->CurrNumFreeTxDesc));
ERROR: that open brace { should be on the previous line
+ if(psIntfAdapter->ulInterruptData[1] >> 16)
+ {
ERROR: space required before the open parenthesis '('
+ if(psIntfAdapter->ulInterruptData[1] >> 16)
ERROR: spaces required around that '=' (ctx:VxE)
+ Adapter->CurrNumRecvDescs=
^
WARNING: line over 80 characters
+ (psIntfAdapter->ulInterruptData[1] >> 16);
+ BCM_DEBUG_PRINT(Adapter,DBG_TYPE_OTHERS, INTF_INIT, DBG_LVL_ALL,"RX mailbox contains %d",
ERROR: space required after that ',' (ctx:VxV)
+ BCM_DEBUG_PRINT(Adapter,DBG_TYPE_OTHERS, INTF_INIT, DBG_LVL_ALL,"RX mailbox contains %d",
^
ERROR: space required after that ',' (ctx:VxV)
+ BCM_DEBUG_PRINT(Adapter,DBG_TYPE_OTHERS, INTF_INIT, DBG_LVL_ALL,"RX mailbox contains %d",
^
ERROR: that open brace { should be on the previous line
+ if(Adapter->fw_download_done &&
+ !Adapter->downloadDDR &&
+ atomic_read(&Adapter->CurrNumFreeTxDesc))
+ {
ERROR: space required before the open parenthesis '('
+ if(Adapter->fw_download_done &&
ERROR: spaces required around that '+=' (ctx:WxV)
+ psIntfAdapter->psAdapter->downloadDDR +=1;
^
ERROR: that open brace { should be on the previous line
+ if(false == Adapter->waiting_to_fw_download_done)
+ {
ERROR: space required before the open parenthesis '('
+ if(false == Adapter->waiting_to_fw_download_done)
ERROR: that open brace { should be on the previous line
+ if(!atomic_read(&Adapter->TxPktAvail))
+ {
ERROR: space required before the open parenthesis '('
+ if(!atomic_read(&Adapter->TxPktAvail))
WARNING: line over 80 characters
+ BCM_DEBUG_PRINT(Adapter,DBG_TYPE_OTHERS, INTF_INIT, DBG_LVL_ALL,"Firing interrupt in URB");
ERROR: space required after that ',' (ctx:VxV)
+ BCM_DEBUG_PRINT(Adapter,DBG_TYPE_OTHERS, INTF_INIT, DBG_LVL_ALL,"Firing interrupt in URB");
^
ERROR: space required after that ',' (ctx:VxV)
+ BCM_DEBUG_PRINT(Adapter,DBG_TYPE_OTHERS, INTF_INIT, DBG_LVL_ALL,"Firing interrupt in URB");
^
ERROR: space prohibited before that ':' (ctx:WxE)
+ case -ENOENT :
^
WARNING: line over 80 characters
+ BCM_DEBUG_PRINT(Adapter,DBG_TYPE_OTHERS, INTF_INIT, DBG_LVL_ALL,"URB has got disconnected ....");
ERROR: space required after that ',' (ctx:VxV)
+ BCM_DEBUG_PRINT(Adapter,DBG_TYPE_OTHERS, INTF_INIT, DBG_LVL_ALL,"URB has got disconnected ....");
^
ERROR: space required after that ',' (ctx:VxV)
+ BCM_DEBUG_PRINT(Adapter,DBG_TYPE_OTHERS, INTF_INIT, DBG_LVL_ALL,"URB has got disconnected ....");
^
WARNING: space prohibited before semicolon
+ return ;
WARNING: line over 80 characters
+ //This situation may happened when URBunlink is used. for detail check usb_unlink_urb documentation.
ERROR: do not use C99 // comments
+ //This situation may happened when URBunlink is used. for detail check usb_unlink_urb documentation.
WARNING: line over 80 characters
+ BCM_DEBUG_PRINT(Adapter,DBG_TYPE_OTHERS, INTF_INIT, DBG_LVL_ALL,"Impossibe condition has occurred... something very bad is going on");
ERROR: space required after that ',' (ctx:VxV)
+ BCM_DEBUG_PRINT(Adapter,DBG_TYPE_OTHERS, INTF_INIT, DBG_LVL_ALL,"Impossibe condition has occurred... something very bad is going on");
^
ERROR: space required after that ',' (ctx:VxV)
+ BCM_DEBUG_PRINT(Adapter,DBG_TYPE_OTHERS, INTF_INIT, DBG_LVL_ALL,"Impossibe condition has occurred... something very bad is going on");
^
WARNING: space prohibited before semicolon
+ break ;
ERROR: do not use C99 // comments
+ //return;
WARNING: line over 80 characters
+ BCM_DEBUG_PRINT(Adapter,DBG_TYPE_OTHERS, INTF_INIT, DBG_LVL_ALL,"Interrupt IN endPoint has got halted/stalled...need to clear this");
ERROR: space required after that ',' (ctx:VxV)
+ BCM_DEBUG_PRINT(Adapter,DBG_TYPE_OTHERS, INTF_INIT, DBG_LVL_ALL,"Interrupt IN endPoint has got halted/stalled...need to clear this");
^
ERROR: space required after that ',' (ctx:VxV)
+ BCM_DEBUG_PRINT(Adapter,DBG_TYPE_OTHERS, INTF_INIT, DBG_LVL_ALL,"Interrupt IN endPoint has got halted/stalled...need to clear this");
^
WARNING: space prohibited before semicolon
+ Adapter->bEndPointHalted = TRUE ;
WARNING: space prohibited before semicolon
+ urb->status = STATUS_SUCCESS ;
ERROR: do not use C99 // comments
+ case -ECONNRESET: //URB got unlinked.
WARNING: line over 80 characters
+ case -ESHUTDOWN: // hardware gone. this is the serious problem.
ERROR: do not use C99 // comments
+ case -ESHUTDOWN: // hardware gone. this is the serious problem.
WARNING: line over 80 characters
+ //Occurs only when something happens with the host controller device
ERROR: code indent should use tabs where possible
+^I ^I^I^I^I^I^I//Occurs only when something happens with the host controller device$
WARNING: please, no space before tabs
+^I ^I^I^I^I^I^I//Occurs only when something happens with the host controller device$
ERROR: do not use C99 // comments
+ //Occurs only when something happens with the host controller device
ERROR: do not use C99 // comments
+ case -ENODEV : //Device got removed
ERROR: space prohibited before that ':' (ctx:WxW)
+ case -ENODEV : //Device got removed
^
WARNING: line over 80 characters
+ case -EINVAL : //Some thing very bad happened with the URB. No description is available.
ERROR: do not use C99 // comments
+ case -EINVAL : //Some thing very bad happened with the URB. No description is available.
ERROR: space prohibited before that ':' (ctx:WxW)
+ case -EINVAL : //Some thing very bad happened with the URB. No description is available.
^
WARNING: line over 80 characters
+ BCM_DEBUG_PRINT(Adapter,DBG_TYPE_OTHERS, INTF_INIT, DBG_LVL_ALL,"interrupt urb error %d", status);
ERROR: code indent should use tabs where possible
+^I ^IBCM_DEBUG_PRINT(Adapter,DBG_TYPE_OTHERS, INTF_INIT, DBG_LVL_ALL,"interrupt urb error %d", status);$
WARNING: please, no space before tabs
+^I ^IBCM_DEBUG_PRINT(Adapter,DBG_TYPE_OTHERS, INTF_INIT, DBG_LVL_ALL,"interrupt urb error %d", status);$
ERROR: space required after that ',' (ctx:VxV)
+ BCM_DEBUG_PRINT(Adapter,DBG_TYPE_OTHERS, INTF_INIT, DBG_LVL_ALL,"interrupt urb error %d", status);
^
ERROR: space required after that ',' (ctx:VxV)
+ BCM_DEBUG_PRINT(Adapter,DBG_TYPE_OTHERS, INTF_INIT, DBG_LVL_ALL,"interrupt urb error %d", status);
^
WARNING: space prohibited before semicolon
+ urb->status = STATUS_SUCCESS ;
WARNING: space prohibited before semicolon
+ break ;
ERROR: do not use C99 // comments
+ //return;
ERROR: spaces required around that ':' (ctx:VxE)
+ default:
^
WARNING: line over 80 characters
+ //This is required to check what is the defaults conditions when it occurs..
ERROR: do not use C99 // comments
+ //This is required to check what is the defaults conditions when it occurs..
WARNING: line over 80 characters
+ BCM_DEBUG_PRINT(Adapter,DBG_TYPE_TX, NEXT_SEND, DBG_LVL_ALL,"GOT DEFAULT INTERRUPT URB STATUS :%d..Please Analyze it...", status);
ERROR: space required after that ',' (ctx:VxV)
+ BCM_DEBUG_PRINT(Adapter,DBG_TYPE_TX, NEXT_SEND, DBG_LVL_ALL,"GOT DEFAULT INTERRUPT URB STATUS :%d..Please Analyze it...", status);
^
ERROR: space required after that ',' (ctx:VxV)
+ BCM_DEBUG_PRINT(Adapter,DBG_TYPE_TX, NEXT_SEND, DBG_LVL_ALL,"GOT DEFAULT INTERRUPT URB STATUS :%d..Please Analyze it...", status);
^
Signed-off-by: Jade Bilkey <herself@thefumon.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Peter Senna Tschudin