drm/i915/bxt: add revision id for A1 stepping and use it
Prefer inclusive ranges for revision checks rather than "below B0". Per specs A2 is not used, so revid <= A1 matches revid < B0. Acked-by: Ville Syrjälä <ville.syrjala@linux.intel.com> Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch> Link: http://patchwork.freedesktop.org/patch/msgid/1445343722-3312-2-git-send-email-jani.nikula@intel.com Signed-off-by: Jani Nikula <jani.nikula@intel.com>
This commit is contained in:
parent
ef712bb4b7
commit
fffda3f4fb
|
@ -2502,6 +2502,7 @@ struct drm_i915_cmd_table {
|
|||
#define SKL_REVID_F0 0x5
|
||||
|
||||
#define BXT_REVID_A0 0x0
|
||||
#define BXT_REVID_A1 0x1
|
||||
#define BXT_REVID_B0 0x3
|
||||
#define BXT_REVID_C0 0x9
|
||||
|
||||
|
|
|
@ -3826,7 +3826,7 @@ int i915_gem_set_caching_ioctl(struct drm_device *dev, void *data,
|
|||
* cacheline, whereas normally such cachelines would get
|
||||
* invalidated.
|
||||
*/
|
||||
if (IS_BROXTON(dev) && INTEL_REVID(dev) < BXT_REVID_B0)
|
||||
if (IS_BROXTON(dev) && INTEL_REVID(dev) <= BXT_REVID_A1)
|
||||
return -ENODEV;
|
||||
|
||||
level = I915_CACHE_LLC;
|
||||
|
|
|
@ -161,7 +161,7 @@ static int host2guc_sample_forcewake(struct intel_guc *guc,
|
|||
data[0] = HOST2GUC_ACTION_SAMPLE_FORCEWAKE;
|
||||
/* WaRsDisableCoarsePowerGating:skl,bxt */
|
||||
if (!intel_enable_rc6(dev_priv->dev) ||
|
||||
(IS_BROXTON(dev) && (INTEL_REVID(dev) < BXT_REVID_B0)) ||
|
||||
(IS_BROXTON(dev) && (INTEL_REVID(dev) <= BXT_REVID_A1)) ||
|
||||
(IS_SKL_GT3(dev) && (INTEL_REVID(dev) <= SKL_REVID_E0)) ||
|
||||
(IS_SKL_GT4(dev) && (INTEL_REVID(dev) <= SKL_REVID_E0)))
|
||||
data[1] = 0;
|
||||
|
|
|
@ -3247,7 +3247,7 @@ void intel_ddi_init(struct drm_device *dev, enum port port)
|
|||
* On BXT A0/A1, sw needs to activate DDIA HPD logic and
|
||||
* interrupts to check the external panel connection.
|
||||
*/
|
||||
if (IS_BROXTON(dev_priv) && (INTEL_REVID(dev) < BXT_REVID_B0)
|
||||
if (IS_BROXTON(dev_priv) && (INTEL_REVID(dev) <= BXT_REVID_A1)
|
||||
&& port == PORT_B)
|
||||
dev_priv->hotplug.irq_port[PORT_A] = intel_dig_port;
|
||||
else
|
||||
|
|
|
@ -6087,7 +6087,7 @@ intel_dp_init_connector(struct intel_digital_port *intel_dig_port,
|
|||
break;
|
||||
case PORT_B:
|
||||
intel_encoder->hpd_pin = HPD_PORT_B;
|
||||
if (IS_BROXTON(dev_priv) && (INTEL_REVID(dev) < BXT_REVID_B0))
|
||||
if (IS_BROXTON(dev_priv) && (INTEL_REVID(dev) <= BXT_REVID_A1))
|
||||
intel_encoder->hpd_pin = HPD_PORT_A;
|
||||
break;
|
||||
case PORT_C:
|
||||
|
|
|
@ -2039,7 +2039,7 @@ void intel_hdmi_init_connector(struct intel_digital_port *intel_dig_port,
|
|||
* On BXT A0/A1, sw needs to activate DDIA HPD logic and
|
||||
* interrupts to check the external panel connection.
|
||||
*/
|
||||
if (IS_BROXTON(dev_priv) && (INTEL_REVID(dev) < BXT_REVID_B0))
|
||||
if (IS_BROXTON(dev_priv) && (INTEL_REVID(dev) <= BXT_REVID_A1))
|
||||
intel_encoder->hpd_pin = HPD_PORT_A;
|
||||
else
|
||||
intel_encoder->hpd_pin = HPD_PORT_B;
|
||||
|
|
|
@ -1946,7 +1946,7 @@ static int logical_render_ring_init(struct drm_device *dev)
|
|||
ring->init_hw = gen8_init_render_ring;
|
||||
ring->init_context = gen8_init_rcs_context;
|
||||
ring->cleanup = intel_fini_pipe_control;
|
||||
if (IS_BROXTON(dev) && INTEL_REVID(dev) < BXT_REVID_B0) {
|
||||
if (IS_BROXTON(dev) && INTEL_REVID(dev) <= BXT_REVID_A1) {
|
||||
ring->get_seqno = bxt_a_get_seqno;
|
||||
ring->set_seqno = bxt_a_set_seqno;
|
||||
} else {
|
||||
|
@ -1998,7 +1998,7 @@ static int logical_bsd_ring_init(struct drm_device *dev)
|
|||
GT_CONTEXT_SWITCH_INTERRUPT << GEN8_VCS1_IRQ_SHIFT;
|
||||
|
||||
ring->init_hw = gen8_init_common_ring;
|
||||
if (IS_BROXTON(dev) && INTEL_REVID(dev) < BXT_REVID_B0) {
|
||||
if (IS_BROXTON(dev) && INTEL_REVID(dev) <= BXT_REVID_A1) {
|
||||
ring->get_seqno = bxt_a_get_seqno;
|
||||
ring->set_seqno = bxt_a_set_seqno;
|
||||
} else {
|
||||
|
@ -2053,7 +2053,7 @@ static int logical_blt_ring_init(struct drm_device *dev)
|
|||
GT_CONTEXT_SWITCH_INTERRUPT << GEN8_BCS_IRQ_SHIFT;
|
||||
|
||||
ring->init_hw = gen8_init_common_ring;
|
||||
if (IS_BROXTON(dev) && INTEL_REVID(dev) < BXT_REVID_B0) {
|
||||
if (IS_BROXTON(dev) && INTEL_REVID(dev) <= BXT_REVID_A1) {
|
||||
ring->get_seqno = bxt_a_get_seqno;
|
||||
ring->set_seqno = bxt_a_set_seqno;
|
||||
} else {
|
||||
|
@ -2083,7 +2083,7 @@ static int logical_vebox_ring_init(struct drm_device *dev)
|
|||
GT_CONTEXT_SWITCH_INTERRUPT << GEN8_VECS_IRQ_SHIFT;
|
||||
|
||||
ring->init_hw = gen8_init_common_ring;
|
||||
if (IS_BROXTON(dev) && INTEL_REVID(dev) < BXT_REVID_B0) {
|
||||
if (IS_BROXTON(dev) && INTEL_REVID(dev) <= BXT_REVID_A1) {
|
||||
ring->get_seqno = bxt_a_get_seqno;
|
||||
ring->set_seqno = bxt_a_set_seqno;
|
||||
} else {
|
||||
|
|
|
@ -4386,7 +4386,7 @@ static void gen6_set_rps(struct drm_device *dev, u8 val)
|
|||
struct drm_i915_private *dev_priv = dev->dev_private;
|
||||
|
||||
/* WaGsvDisableTurbo: Workaround to disable turbo on BXT A* */
|
||||
if (IS_BROXTON(dev) && (INTEL_REVID(dev) < BXT_REVID_B0))
|
||||
if (IS_BROXTON(dev) && (INTEL_REVID(dev) <= BXT_REVID_A1))
|
||||
return;
|
||||
|
||||
WARN_ON(!mutex_is_locked(&dev_priv->rps.hw_lock));
|
||||
|
@ -4710,7 +4710,7 @@ static void gen9_enable_rps(struct drm_device *dev)
|
|||
gen6_init_rps_frequencies(dev);
|
||||
|
||||
/* WaGsvDisableTurbo: Workaround to disable turbo on BXT A* */
|
||||
if (IS_BROXTON(dev) && (INTEL_REVID(dev) < BXT_REVID_B0)) {
|
||||
if (IS_BROXTON(dev) && (INTEL_REVID(dev) <= BXT_REVID_A1)) {
|
||||
intel_uncore_forcewake_put(dev_priv, FORCEWAKE_ALL);
|
||||
return;
|
||||
}
|
||||
|
@ -4796,7 +4796,7 @@ static void gen9_enable_rc6(struct drm_device *dev)
|
|||
* 3b: Enable Coarse Power Gating only when RC6 is enabled.
|
||||
* WaRsDisableCoarsePowerGating:skl,bxt - Render/Media PG need to be disabled with RC6.
|
||||
*/
|
||||
if ((IS_BROXTON(dev) && (INTEL_REVID(dev) < BXT_REVID_B0)) ||
|
||||
if ((IS_BROXTON(dev) && (INTEL_REVID(dev) <= BXT_REVID_A1)) ||
|
||||
((IS_SKL_GT3(dev) || IS_SKL_GT4(dev)) && (INTEL_REVID(dev) <= SKL_REVID_E0)))
|
||||
I915_WRITE(GEN9_PG_ENABLE, 0);
|
||||
else
|
||||
|
|
|
@ -924,14 +924,14 @@ static int gen9_init_workarounds(struct intel_engine_cs *ring)
|
|||
|
||||
if ((IS_SKYLAKE(dev) && (INTEL_REVID(dev) == SKL_REVID_A0 ||
|
||||
INTEL_REVID(dev) == SKL_REVID_B0)) ||
|
||||
(IS_BROXTON(dev) && INTEL_REVID(dev) < BXT_REVID_B0)) {
|
||||
(IS_BROXTON(dev) && INTEL_REVID(dev) <= BXT_REVID_A1)) {
|
||||
/* WaDisableDgMirrorFixInHalfSliceChicken5:skl,bxt */
|
||||
WA_CLR_BIT_MASKED(GEN9_HALF_SLICE_CHICKEN5,
|
||||
GEN9_DG_MIRROR_FIX_ENABLE);
|
||||
}
|
||||
|
||||
if ((IS_SKYLAKE(dev) && INTEL_REVID(dev) <= SKL_REVID_B0) ||
|
||||
(IS_BROXTON(dev) && INTEL_REVID(dev) < BXT_REVID_B0)) {
|
||||
(IS_BROXTON(dev) && INTEL_REVID(dev) <= BXT_REVID_A1)) {
|
||||
/* WaSetDisablePixMaskCammingAndRhwoInCommonSliceChicken:skl,bxt */
|
||||
WA_SET_BIT_MASKED(GEN7_COMMON_SLICE_CHICKEN1,
|
||||
GEN9_RHWO_OPTIMIZATION_DISABLE);
|
||||
|
@ -960,7 +960,7 @@ static int gen9_init_workarounds(struct intel_engine_cs *ring)
|
|||
|
||||
/* WaDisableMaskBasedCammingInRCC:skl,bxt */
|
||||
if ((IS_SKYLAKE(dev) && INTEL_REVID(dev) == SKL_REVID_C0) ||
|
||||
(IS_BROXTON(dev) && INTEL_REVID(dev) < BXT_REVID_B0))
|
||||
(IS_BROXTON(dev) && INTEL_REVID(dev) <= BXT_REVID_A1))
|
||||
WA_SET_BIT_MASKED(SLICE_ECO_CHICKEN0,
|
||||
PIXEL_MASK_CAMMING_DISABLE);
|
||||
|
||||
|
|
Loading…
Reference in New Issue