tools lib traceevent: Make add_left() return pevent_errno
So that it can propagate error properly. Signed-off-by: Namhyung Kim <namhyung@kernel.org> Cc: Frederic Weisbecker <fweisbec@gmail.com> Cc: Ingo Molnar <mingo@kernel.org> Cc: Jiri Olsa <jolsa@redhat.com> Cc: Peter Zijlstra <a.p.zijlstra@chello.nl> Cc: Steven Rostedt <rostedt@goodmis.org> Link: http://lkml.kernel.org/r/1386833777-3790-8-git-send-email-namhyung@kernel.org Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
This commit is contained in:
parent
02d62d6d17
commit
ff533fc058
|
@ -648,7 +648,7 @@ rotate_op_right(struct filter_arg *a, struct filter_arg *b)
|
|||
return arg;
|
||||
}
|
||||
|
||||
static int add_left(struct filter_arg *op, struct filter_arg *arg)
|
||||
static enum pevent_errno add_left(struct filter_arg *op, struct filter_arg *arg)
|
||||
{
|
||||
switch (op->type) {
|
||||
case FILTER_ARG_EXP:
|
||||
|
@ -667,11 +667,11 @@ static int add_left(struct filter_arg *op, struct filter_arg *arg)
|
|||
/* left arg of compares must be a field */
|
||||
if (arg->type != FILTER_ARG_FIELD &&
|
||||
arg->type != FILTER_ARG_BOOLEAN)
|
||||
return -1;
|
||||
return PEVENT_ERRNO__INVALID_ARG_TYPE;
|
||||
op->num.left = arg;
|
||||
break;
|
||||
default:
|
||||
return -1;
|
||||
return PEVENT_ERRNO__INVALID_ARG_TYPE;
|
||||
}
|
||||
return 0;
|
||||
}
|
||||
|
|
Loading…
Reference in New Issue