parse-maintainers: Use perl hash references and specific filenames

Instead of reading STDIN and writing STDOUT, use specific filenames of
MAINTAINERS and MAINTAINERS.new.

Use hash references instead of global hash %hash so future modifications
can read and write specific hashes to split up MAINTAINERS into multiple
files using a script.

Signed-off-by: Joe Perches <joe@perches.com>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
This commit is contained in:
Joe Perches 2017-08-05 18:45:48 -07:00 committed by Linus Torvalds
parent 61f741645a
commit fe9090301f
1 changed files with 35 additions and 24 deletions

View File

@ -2,7 +2,7 @@
use strict; use strict;
my %hash; my $P = $0;
# sort comparison functions # sort comparison functions
sub by_category($$) { sub by_category($$) {
@ -45,20 +45,6 @@ sub by_pattern($$) {
} }
} }
sub alpha_output {
foreach my $key (sort by_category keys %hash) {
if ($key eq " ") {
chomp $hash{$key};
print $hash{$key};
} else {
print "\n" . $key . "\n";
foreach my $pattern (sort by_pattern split('\n', $hash{$key})) {
print($pattern . "\n");
}
}
}
}
sub trim { sub trim {
my $s = shift; my $s = shift;
$s =~ s/\s+$//; $s =~ s/\s+$//;
@ -66,40 +52,65 @@ sub trim {
return $s; return $s;
} }
sub alpha_output {
my ($hashref, $filename) = (@_);
open(my $file, '>', "$filename") or die "$P: $filename: open failed - $!\n";
foreach my $key (sort by_category keys %$hashref) {
if ($key eq " ") {
chomp $$hashref{$key};
print $file $$hashref{$key};
} else {
print $file "\n" . $key . "\n";
foreach my $pattern (sort by_pattern split('\n', %$hashref{$key})) {
print $file ($pattern . "\n");
}
}
}
close($file);
}
sub file_input { sub file_input {
my ($hashref, $filename) = (@_);
my $lastline = ""; my $lastline = "";
my $case = " "; my $case = " ";
$hash{$case} = ""; $$hashref{$case} = "";
while (<>) { open(my $file, '<', "$filename") or die "$P: $filename: open failed - $!\n";
while (<$file>) {
my $line = $_; my $line = $_;
# Pattern line? # Pattern line?
if ($line =~ m/^([A-Z]):\s*(.*)/) { if ($line =~ m/^([A-Z]):\s*(.*)/) {
$line = $1 . ":\t" . trim($2) . "\n"; $line = $1 . ":\t" . trim($2) . "\n";
if ($lastline eq "") { if ($lastline eq "") {
$hash{$case} = $hash{$case} . $line; $$hashref{$case} = $$hashref{$case} . $line;
next; next;
} }
$case = trim($lastline); $case = trim($lastline);
exists $hash{$case} and die "Header '$case' already exists"; exists $$hashref{$case} and die "Header '$case' already exists";
$hash{$case} = $line; $$hashref{$case} = $line;
$lastline = ""; $lastline = "";
next; next;
} }
if ($case eq " ") { if ($case eq " ") {
$hash{$case} = $hash{$case} . $lastline; $$hashref{$case} = $$hashref{$case} . $lastline;
$lastline = $line; $lastline = $line;
next; next;
} }
trim($lastline) eq "" or die ("Odd non-pattern line '$lastline' for '$case'"); trim($lastline) eq "" or die ("Odd non-pattern line '$lastline' for '$case'");
$lastline = $line; $lastline = $line;
} }
$hash{$case} = $hash{$case} . $lastline; $$hashref{$case} = $$hashref{$case} . $lastline;
close($file);
} }
file_input(); my %hash;
alpha_output();
file_input(\%hash, "MAINTAINERS");
alpha_output(\%hash, "MAINTAINERS.new");
exit(0); exit(0);