UbiquitousOS
/
OpenCloudOS-Kernel
mirror of https://gitee.com/OpenCloudOS/OpenCloudOS-Kernel.git
11
0
Fork 0
Code Issues Projects Releases Wiki Activity

RDS: lock rds_conn_count decrement in rds_conn_destroy() 

rds_conn_destroy() can race with all other modifications of the
rds_conn_count but it was modifying the count without locking.

Signed-off-by: Zach Brown <zach.brown@oracle.com>
This commit is contained in:
Zach Brown 2010-07-23 10:30:45 -07:00 committed by Andy Grover
parent ea819867b7
commit fe8ff6b58f
1 changed files with 3 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
net/rds/connection.c
View File

@ -313,6 +313,7 @@ void rds_conn_shutdown(struct rds_connection *conn)
void rds_conn_destroy(struct rds_connection *conn) void rds_conn_destroy(struct rds_connection *conn)
{ {
struct rds_message *rm, *rtmp; struct rds_message *rm, *rtmp;
unsigned long flags;
rdsdebug("freeing conn %p for %pI4 -> " rdsdebug("freeing conn %p for %pI4 -> "
"%pI4\n", conn, &conn->c_laddr, "%pI4\n", conn, &conn->c_laddr,
@ -350,7 +351,9 @@ void rds_conn_destroy(struct rds_connection *conn)
BUG_ON(!list_empty(&conn->c_retrans)); BUG_ON(!list_empty(&conn->c_retrans));
kmem_cache_free(rds_conn_slab, conn); kmem_cache_free(rds_conn_slab, conn);
spin_lock_irqsave(&rds_conn_lock, flags);
rds_conn_count--; rds_conn_count--;
spin_unlock_irqrestore(&rds_conn_lock, flags);
} }
EXPORT_SYMBOL_GPL(rds_conn_destroy); EXPORT_SYMBOL_GPL(rds_conn_destroy);