rcu: Rename rcu_process_callbacks() to rcu_core() for Tree RCU

Although the name rcu_process_callbacks() still makes sense for Tiny
RCU, where most of what it does is invoke callbacks, it no longer makes
much sense for Tree RCU, especially given that the actually callback
invocation is relegated to rcu_do_batch(), or, for no-CBs CPUs, to the
rcuo kthreads.  Especially in the latter case, rcu_process_callbacks()
has very little to do with actual callbacks.  A better description of
this function is that it performs RCU's core processing.

This commit therefore changes the name of Tree RCU's rcu_process_callbacks()
function to rcu_core(), which also has the virtue of being consistent with
the existing invoke_rcu_core() function.

While in the area, the header comment is reworked.

Signed-off-by: Paul E. McKenney <paulmck@linux.ibm.com>
This commit is contained in:
Paul E. McKenney 2018-11-21 12:42:12 -08:00
parent c98cac603f
commit fb60e533be
4 changed files with 8 additions and 12 deletions

View File

@ -491,7 +491,7 @@ in a per-CPU variable.
<p>The next time an <tt>RCU_SOFTIRQ</tt> handler executes on <p>The next time an <tt>RCU_SOFTIRQ</tt> handler executes on
this CPU (for example, after the next scheduler-clock this CPU (for example, after the next scheduler-clock
interrupt), <tt>__rcu_process_callbacks()</tt> will invoke interrupt), <tt>rcu_core()</tt> will invoke
<tt>rcu_check_quiescent_state()</tt>, which will notice the <tt>rcu_check_quiescent_state()</tt>, which will notice the
recorded quiescent state, and invoke recorded quiescent state, and invoke
<tt>rcu_report_qs_rdp()</tt>. <tt>rcu_report_qs_rdp()</tt>.

View File

@ -3924,7 +3924,7 @@
font-style="normal" font-style="normal"
y="-4418.6582" y="-4418.6582"
x="3745.7725" x="3745.7725"
xml:space="preserve">rcu_process_callbacks()</text> xml:space="preserve">rcu_core()</text>
<text <text
style="font-size:192px;font-style:normal;font-weight:bold;text-anchor:start;fill:#000000;stroke-width:0.025in;font-family:Courier" style="font-size:192px;font-style:normal;font-weight:bold;text-anchor:start;fill:#000000;stroke-width:0.025in;font-family:Courier"
id="text202-7-5-3-27-0" id="text202-7-5-3-27-0"
@ -3933,7 +3933,7 @@
font-style="normal" font-style="normal"
y="-4165.7954" y="-4165.7954"
x="3745.7725" x="3745.7725"
xml:space="preserve">rcu_check_quiescent_state())</text> xml:space="preserve">rcu_check_quiescent_state()</text>
<text <text
style="font-size:192px;font-style:normal;font-weight:bold;text-anchor:start;fill:#000000;stroke-width:0.025in;font-family:Courier" style="font-size:192px;font-style:normal;font-weight:bold;text-anchor:start;fill:#000000;stroke-width:0.025in;font-family:Courier"
id="text202-7-5-3-27-0-9" id="text202-7-5-3-27-0-9"

Before

Width:  |  Height:  |  Size: 209 KiB

After

Width:  |  Height:  |  Size: 209 KiB

View File

@ -797,7 +797,7 @@
font-style="normal" font-style="normal"
y="-4418.6582" y="-4418.6582"
x="3745.7725" x="3745.7725"
xml:space="preserve">rcu_process_callbacks()</text> xml:space="preserve">rcu_core()</text>
<text <text
style="font-size:192px;font-style:normal;font-weight:bold;text-anchor:start;fill:#000000;stroke-width:0.025in;font-family:Courier" style="font-size:192px;font-style:normal;font-weight:bold;text-anchor:start;fill:#000000;stroke-width:0.025in;font-family:Courier"
id="text202-7-5-3-27-0" id="text202-7-5-3-27-0"
@ -806,7 +806,7 @@
font-style="normal" font-style="normal"
y="-4165.7954" y="-4165.7954"
x="3745.7725" x="3745.7725"
xml:space="preserve">rcu_check_quiescent_state())</text> xml:space="preserve">rcu_check_quiescent_state()</text>
<text <text
style="font-size:192px;font-style:normal;font-weight:bold;text-anchor:start;fill:#000000;stroke-width:0.025in;font-family:Courier" style="font-size:192px;font-style:normal;font-weight:bold;text-anchor:start;fill:#000000;stroke-width:0.025in;font-family:Courier"
id="text202-7-5-3-27-0-9" id="text202-7-5-3-27-0-9"

Before

Width:  |  Height:  |  Size: 43 KiB

After

Width:  |  Height:  |  Size: 43 KiB

View File

@ -2742,12 +2742,8 @@ void rcu_fwd_progress_check(unsigned long j)
} }
EXPORT_SYMBOL_GPL(rcu_fwd_progress_check); EXPORT_SYMBOL_GPL(rcu_fwd_progress_check);
/* /* Perform RCU core processing work for the current CPU. */
* This does the RCU core processing work for the specified rcu_data static __latent_entropy void rcu_core(struct softirq_action *unused)
* structures. This may be called only from the CPU to whom the rdp
* belongs.
*/
static __latent_entropy void rcu_process_callbacks(struct softirq_action *unused)
{ {
unsigned long flags; unsigned long flags;
struct rcu_data *rdp = raw_cpu_ptr(&rcu_data); struct rcu_data *rdp = raw_cpu_ptr(&rcu_data);
@ -3856,7 +3852,7 @@ void __init rcu_init(void)
rcu_init_one(); rcu_init_one();
if (dump_tree) if (dump_tree)
rcu_dump_rcu_node_tree(); rcu_dump_rcu_node_tree();
open_softirq(RCU_SOFTIRQ, rcu_process_callbacks); open_softirq(RCU_SOFTIRQ, rcu_core);
/* /*
* We don't need protection against CPU-hotplug here because * We don't need protection against CPU-hotplug here because