UbiquitousOS
/
OpenCloudOS-Kernel
mirror of https://gitee.com/OpenCloudOS/OpenCloudOS-Kernel.git
11
0
Fork 0
Code Issues Projects Releases Wiki Activity

e1000e: e1000e_cyclecounter_read(): incvalue is 32 bits, not 64 

"incvalue" variable holds a result of "er32(TIMINCA) &
E1000_TIMINCA_INCVALUE_MASK" and used in "do_div(temp, incvalue)"
as a divisor.

Thus, "u64 incvalue" declaration is probably a mistake.
Even though it seems to be a harmless one, let's fix it.

Signed-off-by: Denys Vlasenko <dvlasenk@redhat.com>
Tested-by: Aaron Brown <aaron.f.brown@intel.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
This commit is contained in:
Denys Vlasenko 2016-04-20 17:45:54 +02:00 committed by Jeff Kirsher
parent 8008f68cb8
commit fb5277f2c2
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
drivers/net/ethernet/intel/e1000e/netdev.c
View File

@ -4300,7 +4300,8 @@ static cycle_t e1000e_cyclecounter_read(const struct cyclecounter *cc)
} }
if ((hw->mac.type == e1000_82574) || (hw->mac.type == e1000_82583)) { if ((hw->mac.type == e1000_82574) || (hw->mac.type == e1000_82583)) {
u64 incvalue, time_delta, rem, temp; u64 time_delta, rem, temp;
u32 incvalue;
int i; int i;
/* errata for 82574/82583 possible bad bits read from SYSTIMH/L /* errata for 82574/82583 possible bad bits read from SYSTIMH/L