staging: speakup: i18n.c: Fix leak in msg_set()
If we end up returning -EINVAL from the function we will leak the memory allocated to 'newstr' which has been allocated but not yet assigned to anything. Fix the leak by properly freeing the memory again before we return. Signed-off-by: Jesper Juhl <jj@chaosbits.net> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
parent
935d59ff25
commit
fafbc202cd
|
@ -555,6 +555,7 @@ ssize_t msg_set(enum msg_index_t index, char *text, size_t length)
|
|||
&& index <= MSG_FORMATTED_END)
|
||||
&& !fmt_validate(speakup_default_msgs[index],
|
||||
newstr)) {
|
||||
kfree(newstr);
|
||||
return -EINVAL;
|
||||
}
|
||||
spk_lock(flags);
|
||||
|
|
Loading…
Reference in New Issue