UbiquitousOS
/
OpenCloudOS-Kernel
mirror of https://gitee.com/OpenCloudOS/OpenCloudOS-Kernel.git
11
0
Fork 0
Code Issues Projects Releases Wiki Activity

cfg80211: reg: remove warn_on for a normal case 

If there are simulatenous queries of regdb, then there might be a case
where multiple queries can trigger request_firmware_no_wait and can have
parallel callbacks being executed asynchronously. In this scenario we
might hit the WARN_ON.

So remove the warn_on, as the code already handles multiple callbacks
gracefully.

Signed-off-by: Chaitanya Tata <chaitanya.tata@bluwireless.co.uk>
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
This commit is contained in:
Chaitanya Tata 2019-01-24 16:13:02 +05:30 committed by Johannes Berg
parent 7c53eb5d87
commit faae54ad41
1 changed files with 7 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
net/wireless/reg.c
View File

@ -1024,8 +1024,13 @@ static void regdb_fw_cb(const struct firmware *fw, void *context)
} }
rtnl_lock(); rtnl_lock();
if (WARN_ON(regdb && !IS_ERR(regdb))) { if (regdb && !IS_ERR(regdb)) {
/* just restore and free new db */ /* negative case - a bug
* positive case - can happen due to race in case of multiple cb's in
* queue, due to usage of asynchronous callback
*
* Either case, just restore and free new db.
*/
} else if (set_error) { } else if (set_error) {
regdb = ERR_PTR(set_error); regdb = ERR_PTR(set_error);
} else if (fw) { } else if (fw) {