net: hns3: Add handle for default case
There are a few "switch-case" codes missed handle for default case. For some abnormal case, it should return error code instead of return 0. Signed-off-by: Jian Shen <shenjian15@huawei.com> Signed-off-by: Peng Li <lipeng321@huawei.com> Signed-off-by: Salil Mehta <salil.mehta@huawei.com> Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
parent
6cee6fc384
commit
fa7a4bd564
|
@ -2176,6 +2176,8 @@ static void hns3_rx_checksum(struct hns3_enet_ring *ring, struct sk_buff *skb,
|
||||||
l4_type == HNS3_L4_TYPE_SCTP))
|
l4_type == HNS3_L4_TYPE_SCTP))
|
||||||
skb->ip_summed = CHECKSUM_UNNECESSARY;
|
skb->ip_summed = CHECKSUM_UNNECESSARY;
|
||||||
break;
|
break;
|
||||||
|
default:
|
||||||
|
break;
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
|
|
|
@ -351,9 +351,10 @@ static int hns3_get_sset_count(struct net_device *netdev, int stringset)
|
||||||
|
|
||||||
case ETH_SS_TEST:
|
case ETH_SS_TEST:
|
||||||
return ops->get_sset_count(h, stringset);
|
return ops->get_sset_count(h, stringset);
|
||||||
}
|
|
||||||
|
|
||||||
return 0;
|
default:
|
||||||
|
return -EOPNOTSUPP;
|
||||||
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
static void *hns3_update_strings(u8 *data, const struct hns3_stats *stats,
|
static void *hns3_update_strings(u8 *data, const struct hns3_stats *stats,
|
||||||
|
@ -417,6 +418,8 @@ static void hns3_get_strings(struct net_device *netdev, u32 stringset, u8 *data)
|
||||||
case ETH_SS_TEST:
|
case ETH_SS_TEST:
|
||||||
ops->get_strings(h, stringset, data);
|
ops->get_strings(h, stringset, data);
|
||||||
break;
|
break;
|
||||||
|
default:
|
||||||
|
break;
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
|
|
|
@ -2224,6 +2224,8 @@ static void hclge_clear_event_cause(struct hclge_dev *hdev, u32 event_type,
|
||||||
case HCLGE_VECTOR0_EVENT_MBX:
|
case HCLGE_VECTOR0_EVENT_MBX:
|
||||||
hclge_write_dev(&hdev->hw, HCLGE_VECTOR0_CMDQ_SRC_REG, regclr);
|
hclge_write_dev(&hdev->hw, HCLGE_VECTOR0_CMDQ_SRC_REG, regclr);
|
||||||
break;
|
break;
|
||||||
|
default:
|
||||||
|
break;
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
|
@ -5218,6 +5220,10 @@ static int hclge_init_client_instance(struct hnae3_client *client,
|
||||||
|
|
||||||
hnae3_set_client_init_flag(client, ae_dev, 1);
|
hnae3_set_client_init_flag(client, ae_dev, 1);
|
||||||
}
|
}
|
||||||
|
|
||||||
|
break;
|
||||||
|
default:
|
||||||
|
return -EINVAL;
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
|
|
|
@ -134,7 +134,7 @@ static int hclgevf_init_cmd_queue(struct hclgevf_dev *hdev,
|
||||||
|
|
||||||
hclgevf_write_dev(hw, HCLGEVF_NIC_CSQ_HEAD_REG, 0);
|
hclgevf_write_dev(hw, HCLGEVF_NIC_CSQ_HEAD_REG, 0);
|
||||||
hclgevf_write_dev(hw, HCLGEVF_NIC_CSQ_TAIL_REG, 0);
|
hclgevf_write_dev(hw, HCLGEVF_NIC_CSQ_TAIL_REG, 0);
|
||||||
break;
|
return 0;
|
||||||
case HCLGEVF_TYPE_CRQ:
|
case HCLGEVF_TYPE_CRQ:
|
||||||
reg_val = (u32)ring->desc_dma_addr;
|
reg_val = (u32)ring->desc_dma_addr;
|
||||||
hclgevf_write_dev(hw, HCLGEVF_NIC_CRQ_BASEADDR_L_REG, reg_val);
|
hclgevf_write_dev(hw, HCLGEVF_NIC_CRQ_BASEADDR_L_REG, reg_val);
|
||||||
|
@ -147,10 +147,10 @@ static int hclgevf_init_cmd_queue(struct hclgevf_dev *hdev,
|
||||||
|
|
||||||
hclgevf_write_dev(hw, HCLGEVF_NIC_CRQ_HEAD_REG, 0);
|
hclgevf_write_dev(hw, HCLGEVF_NIC_CRQ_HEAD_REG, 0);
|
||||||
hclgevf_write_dev(hw, HCLGEVF_NIC_CRQ_TAIL_REG, 0);
|
hclgevf_write_dev(hw, HCLGEVF_NIC_CRQ_TAIL_REG, 0);
|
||||||
break;
|
return 0;
|
||||||
|
default:
|
||||||
|
return -EINVAL;
|
||||||
}
|
}
|
||||||
|
|
||||||
return 0;
|
|
||||||
}
|
}
|
||||||
|
|
||||||
void hclgevf_cmd_setup_basic_desc(struct hclgevf_desc *desc,
|
void hclgevf_cmd_setup_basic_desc(struct hclgevf_desc *desc,
|
||||||
|
|
|
@ -1667,6 +1667,9 @@ static int hclgevf_init_client_instance(struct hnae3_client *client,
|
||||||
}
|
}
|
||||||
|
|
||||||
hnae3_set_client_init_flag(client, ae_dev, 1);
|
hnae3_set_client_init_flag(client, ae_dev, 1);
|
||||||
|
break;
|
||||||
|
default:
|
||||||
|
return -EINVAL;
|
||||||
}
|
}
|
||||||
|
|
||||||
return 0;
|
return 0;
|
||||||
|
|
Loading…
Reference in New Issue