UbiquitousOS
/
OpenCloudOS-Kernel
mirror of https://gitee.com/OpenCloudOS/OpenCloudOS-Kernel.git
11
0
Fork 0
Code Issues Projects Releases Wiki Activity

scsi: mpi3mr: Fix missing unlock on error 

Goto unlock path before return from function in the error handling case.

Link: https://lore.kernel.org/r/20210603152803.717505-1-yangyingliang@huawei.com
Fixes: c9566231cf ("scsi: mpi3mr: Create operational request and reply queue pair")
Reported-by: Hulk Robot <hulkci@huawei.com>
Acked-by: Kashyap Desai <kashyap.desai@broadcom.com>
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
This commit is contained in:
Yang Yingliang 2021-06-03 23:28:03 +08:00 committed by Martin K. Petersen
parent ebc076b3ed
commit f9dc034d04
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
drivers/scsi/mpi3mr/mpi3mr_fw.c
View File

@ -1585,7 +1585,7 @@ static int mpi3mr_create_op_reply_q(struct mpi3mr_ioc *mrioc, u16 qidx)
if (mrioc->init_cmds.state & MPI3MR_CMD_PENDING) { if (mrioc->init_cmds.state & MPI3MR_CMD_PENDING) {
retval = -1; retval = -1;
ioc_err(mrioc, "CreateRepQ: Init command is in use\n"); ioc_err(mrioc, "CreateRepQ: Init command is in use\n");
goto out; goto out_unlock;
} }
mrioc->init_cmds.state = MPI3MR_CMD_PENDING; mrioc->init_cmds.state = MPI3MR_CMD_PENDING;
mrioc->init_cmds.is_waiting = 1; mrioc->init_cmds.is_waiting = 1;
@ -1694,7 +1694,7 @@ static int mpi3mr_create_op_req_q(struct mpi3mr_ioc *mrioc, u16 idx,
if (mrioc->init_cmds.state & MPI3MR_CMD_PENDING) { if (mrioc->init_cmds.state & MPI3MR_CMD_PENDING) {
retval = -1; retval = -1;
ioc_err(mrioc, "CreateReqQ: Init command is in use\n"); ioc_err(mrioc, "CreateReqQ: Init command is in use\n");
goto out; goto out_unlock;
} }
mrioc->init_cmds.state = MPI3MR_CMD_PENDING; mrioc->init_cmds.state = MPI3MR_CMD_PENDING;
mrioc->init_cmds.is_waiting = 1; mrioc->init_cmds.is_waiting = 1;