drm/bridge: ti-sn65dsi86: Cleanup managing of drvdata
Let's: - Set the drvdata as soon as it's allocated. This just sets up a pointer so there's no downside here. - Remove the useless call to i2c_set_clientdata() which is literally the same thing as dev_set_drvdata(). No functional changes intended. Signed-off-by: Douglas Anderson <dianders@chromium.org> Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org> Acked-by: Linus Walleij <linus.walleij@linaro.org> Link: https://patchwork.freedesktop.org/patch/msgid/20210423095743.v5.7.If5d4d4e22e97bebcd493b76765c1759527705620@changeid
This commit is contained in:
parent
3636fc25f7
commit
f94eb8a328
|
@ -1245,6 +1245,8 @@ static int ti_sn65dsi86_probe(struct i2c_client *client,
|
|||
pdata = devm_kzalloc(dev, sizeof(struct ti_sn65dsi86), GFP_KERNEL);
|
||||
if (!pdata)
|
||||
return -ENOMEM;
|
||||
dev_set_drvdata(dev, pdata);
|
||||
pdata->dev = dev;
|
||||
|
||||
pdata->regmap = devm_regmap_init_i2c(client,
|
||||
&ti_sn65dsi86_regmap_config);
|
||||
|
@ -1253,16 +1255,12 @@ static int ti_sn65dsi86_probe(struct i2c_client *client,
|
|||
return PTR_ERR(pdata->regmap);
|
||||
}
|
||||
|
||||
pdata->dev = dev;
|
||||
|
||||
ret = drm_of_find_panel_or_bridge(dev->of_node, 1, 0, &pdata->panel, NULL);
|
||||
if (ret) {
|
||||
DRM_ERROR("could not find any panel node\n");
|
||||
return ret;
|
||||
}
|
||||
|
||||
dev_set_drvdata(dev, pdata);
|
||||
|
||||
pdata->enable_gpio = devm_gpiod_get(dev, "enable", GPIOD_OUT_LOW);
|
||||
if (IS_ERR(pdata->enable_gpio)) {
|
||||
DRM_ERROR("failed to get enable gpio from DT\n");
|
||||
|
@ -1295,8 +1293,6 @@ static int ti_sn65dsi86_probe(struct i2c_client *client,
|
|||
if (ret)
|
||||
return ret;
|
||||
|
||||
i2c_set_clientdata(client, pdata);
|
||||
|
||||
pdata->aux.name = "ti-sn65dsi86-aux";
|
||||
pdata->aux.dev = dev;
|
||||
pdata->aux.transfer = ti_sn_aux_transfer;
|
||||
|
|
Loading…
Reference in New Issue