UbiquitousOS
/
OpenCloudOS-Kernel
mirror of https://gitee.com/OpenCloudOS/OpenCloudOS-Kernel.git
11
0
Fork 0
Code Issues Projects Releases Wiki Activity

USB: PCI-quirks: Deletion of unnecessary checks before the function call "pci_dev_put" 

The pci_dev_put() function tests whether its argument is NULL and then
returns immediately. Thus the test around the call is not needed.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Markus Elfring 2014-11-21 15:20:12 +01:00 committed by Greg Kroah-Hartman
parent bb2d43e091
commit f910b6cba2
1 changed files with 4 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
drivers/usb/host/pci-quirks.c
View File

@ -233,10 +233,8 @@ commit:
spin_unlock_irqrestore(&amd_lock, flags); spin_unlock_irqrestore(&amd_lock, flags);
if (info.nb_dev) pci_dev_put(info.nb_dev);
pci_dev_put(info.nb_dev); pci_dev_put(info.smbus_dev);
if (info.smbus_dev)
pci_dev_put(info.smbus_dev);
} else { } else {
/* no race - commit the result */ /* no race - commit the result */
@ -447,10 +445,8 @@ void usb_amd_dev_put(void)
spin_unlock_irqrestore(&amd_lock, flags); spin_unlock_irqrestore(&amd_lock, flags);
if (nb) pci_dev_put(nb);
pci_dev_put(nb); pci_dev_put(smbus);
if (smbus)
pci_dev_put(smbus);
} }
EXPORT_SYMBOL_GPL(usb_amd_dev_put); EXPORT_SYMBOL_GPL(usb_amd_dev_put);