USB: EHCI: move del_timer_sync calls outside spinlocked region
This patch (as1030b) moves a del_timer_sync() call outside the scope of a spinlock, where it could cause a deadlock, and adds a new del_timer_sync() call for the new IAA watchdog timer (it was omitted by mistake). Signed-off-by: Alan Stern <stern@rowland.harvard.edu> Acked-by: David Brownell <dbrownell@users.sourceforge.net> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
This commit is contained in:
parent
dd95b81411
commit
f8fa7571a9
|
@ -123,6 +123,8 @@ static int ehci_bus_suspend (struct usb_hcd *hcd)
|
||||||
|
|
||||||
if (time_before (jiffies, ehci->next_statechange))
|
if (time_before (jiffies, ehci->next_statechange))
|
||||||
msleep(5);
|
msleep(5);
|
||||||
|
del_timer_sync(&ehci->watchdog);
|
||||||
|
del_timer_sync(&ehci->iaa_watchdog);
|
||||||
|
|
||||||
port = HCS_N_PORTS (ehci->hcs_params);
|
port = HCS_N_PORTS (ehci->hcs_params);
|
||||||
spin_lock_irq (&ehci->lock);
|
spin_lock_irq (&ehci->lock);
|
||||||
|
@ -171,7 +173,6 @@ static int ehci_bus_suspend (struct usb_hcd *hcd)
|
||||||
}
|
}
|
||||||
|
|
||||||
/* turn off now-idle HC */
|
/* turn off now-idle HC */
|
||||||
del_timer_sync (&ehci->watchdog);
|
|
||||||
ehci_halt (ehci);
|
ehci_halt (ehci);
|
||||||
hcd->state = HC_STATE_SUSPENDED;
|
hcd->state = HC_STATE_SUSPENDED;
|
||||||
|
|
||||||
|
|
Loading…
Reference in New Issue