UbiquitousOS
/
OpenCloudOS-Kernel
mirror of https://gitee.com/OpenCloudOS/OpenCloudOS-Kernel.git
11
0
Fork 0
Code Issues Projects Releases Wiki Activity

regulator: s2mps11: Fix setting ramp_delay 

Current code has wrong mask and val arguments for updating ramp_delay. Fix it.
Also ensure the return value of get_ramp_delay() won't greater than 3 because
the mask field for ramp_val only takes 2 bits.

Signed-off-by: Axel Lin <axel.lin@ingics.com>
Signed-off-by: Mark Brown <broonie@linaro.org>
This commit is contained in:
Axel Lin 2013-08-05 14:08:37 +08:00 committed by Mark Brown
parent 80853304cd
commit f8f1d48be3
1 changed files with 6 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
drivers/regulator/s2mps11.c
View File

@ -50,6 +50,10 @@ static int get_ramp_delay(int ramp_delay)
break; break;
cnt++; cnt++;
} }
if (cnt > 3)
cnt = 3;
return cnt; return cnt;
} }
@ -203,8 +207,8 @@ static int s2mps11_set_ramp_delay(struct regulator_dev *rdev, int ramp_delay)
ramp_val = get_ramp_delay(ramp_delay); ramp_val = get_ramp_delay(ramp_delay);
return regmap_update_bits(rdev->regmap, ramp_reg, return regmap_update_bits(rdev->regmap, ramp_reg, 0x3 << ramp_shift,
ramp_val << ramp_shift, 1 << ramp_shift); ramp_val << ramp_shift);
ramp_disable: ramp_disable:
return regmap_update_bits(rdev->regmap, S2MPS11_REG_RAMP, return regmap_update_bits(rdev->regmap, S2MPS11_REG_RAMP,