From f7908a007e20fff3d666e0b98eae3b10afb7d533 Mon Sep 17 00:00:00 2001 From: Paul Burton Date: Sat, 2 Feb 2019 01:43:21 +0000 Subject: [PATCH] MIPS: mm: Remove redundant preempt_disable in local_flush_tlb_mm() The r4k variant of local_flush_tlb_mm() wraps its call to drop_mmu_context() with a preempt_disable() & preempt_enable() pair, but this is redundant since drop_mmu_context() disables interrupts and from Documentation/preempt-locking.txt: Note that you do not need to explicitly prevent preemption if you are holding any locks or interrupts are disabled, since preemption is implicitly disabled in those cases. Remove the redundant preempt_disable() & preempt_enable() calls. Signed-off-by: Paul Burton Cc: linux-mips@vger.kernel.org --- arch/mips/mm/tlb-r4k.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/arch/mips/mm/tlb-r4k.c b/arch/mips/mm/tlb-r4k.c index ba76b0c11d38..9fff08eabe8f 100644 --- a/arch/mips/mm/tlb-r4k.c +++ b/arch/mips/mm/tlb-r4k.c @@ -108,9 +108,7 @@ EXPORT_SYMBOL(local_flush_tlb_all); these entries, we just bump the asid. */ void local_flush_tlb_mm(struct mm_struct *mm) { - preempt_disable(); drop_mmu_context(mm); - preempt_enable(); } void local_flush_tlb_range(struct vm_area_struct *vma, unsigned long start,