UbiquitousOS
/
OpenCloudOS-Kernel
mirror of https://gitee.com/OpenCloudOS/OpenCloudOS-Kernel.git
11
0
Fork 0
Code Issues Projects Releases Wiki Activity

platform/x86: dell-wmi-sysman: Fix release_attributes_data() getting called twice on init_bios_attributes() failure 

All calls of init_bios_attributes() will result in a
goto fail_create_group if they fail, which calls
release_attributes_data().

So there is no need to call release_attributes_data() from
init_bios_attributes() on failure itself.

Fixes: e8a60aa740 ("platform/x86: Introduce support for Systems Management Driver over WMI for Dell Systems")
Cc: Divya Bharathi <Divya_Bharathi@dell.com>
Cc: Mario Limonciello <mario.limonciello@dell.com>
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Link: https://lore.kernel.org/r/20210321115901.35072-5-hdegoede@redhat.com
This commit is contained in:
Hans de Goede 2021-03-21 12:58:58 +01:00
parent cb1e50f2f0
commit f4c4e9ad15
1 changed files with 0 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
drivers/platform/x86/dell/dell-wmi-sysman/sysman.c
View File

@ -491,7 +491,6 @@ nextobj:
err_attr_init: err_attr_init:
mutex_unlock(&wmi_priv.mutex); mutex_unlock(&wmi_priv.mutex);
release_attributes_data();
kfree(obj); kfree(obj);
return retval; return retval;
} }