drm/modes: Make width-mm/height-mm check in of_get_drm_panel_display_mode() mandatory
All users of this function require width-mm/height-mm DT property to be present per their DT bindings, make width-mm/height-mm check mandatory. It is generally a good idea to specify panel dimensions, so userspace can configure e.g. scaling accordingly. Signed-off-by: Marek Vasut <marex@denx.de> Cc: Christoph Niedermaier <cniedermaier@dh-electronics.com> Cc: Daniel Vetter <daniel.vetter@ffwll.ch> Cc: Dmitry Osipenko <digetx@gmail.com> Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com> Cc: Noralf Trønnes <noralf@tronnes.org> Cc: Rob Herring <robh+dt@kernel.org> Cc: Robert Foss <robert.foss@linaro.org> Cc: Sam Ravnborg <sam@ravnborg.org> Cc: Thomas Zimmermann <tzimmermann@suse.de> To: dri-devel@lists.freedesktop.org Reviewed-by: Noralf Trønnes <noralf@tronnes.org> Link: https://patchwork.freedesktop.org/patch/msgid/20220411004728.68203-1-marex@denx.de
This commit is contained in:
parent
4dd024d4ad
commit
f470cfe40b
|
@ -735,8 +735,8 @@ EXPORT_SYMBOL_GPL(of_get_drm_display_mode);
|
|||
* @dmode: will be set to the return value
|
||||
* @bus_flags: information about pixelclk, sync and DE polarity
|
||||
*
|
||||
* The Device Tree properties width-mm and height-mm will be read and set on
|
||||
* the display mode if they are present.
|
||||
* The mandatory Device Tree properties width-mm and height-mm
|
||||
* are read and set on the display mode.
|
||||
*
|
||||
* Returns:
|
||||
* Zero on success, negative error code on failure.
|
||||
|
@ -761,11 +761,11 @@ int of_get_drm_panel_display_mode(struct device_node *np,
|
|||
drm_bus_flags_from_videomode(&vm, bus_flags);
|
||||
|
||||
ret = of_property_read_u32(np, "width-mm", &width_mm);
|
||||
if (ret && ret != -EINVAL)
|
||||
if (ret)
|
||||
return ret;
|
||||
|
||||
ret = of_property_read_u32(np, "height-mm", &height_mm);
|
||||
if (ret && ret != -EINVAL)
|
||||
if (ret)
|
||||
return ret;
|
||||
|
||||
dmode->width_mm = width_mm;
|
||||
|
|
Loading…
Reference in New Issue