UbiquitousOS
/
OpenCloudOS-Kernel
mirror of https://gitee.com/OpenCloudOS/OpenCloudOS-Kernel.git
11
0
Fork 0
Code Issues Projects Releases Wiki Activity

staging: most: usb: use correct error codes 

This patch uses the -EINVAL return code where -EFAULT is wrongly being
used.

Signed-off-by: Christian Gromm <christian.gromm@microchip.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Link: https://lore.kernel.org/r/1590570387-27069-9-git-send-email-christian.gromm@microchip.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Christian Gromm 2020-05-27 11:06:25 +02:00 committed by Greg Kroah-Hartman
parent 1fd4fb8c62
commit f470a5b01b
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
drivers/staging/most/usb/usb.c
View File

@ -813,7 +813,7 @@ static int get_stat_reg_addr(const struct regs *regs, int size,
return 0;
}
}
return -EFAULT;
return -EINVAL;
}
#define get_static_reg_addr(regs, name, reg_addr) \
@ -835,7 +835,7 @@ static ssize_t value_show(struct device *dev, struct device_attribute *attr,
reg_addr = dci_obj->reg_addr;
else if (get_static_reg_addr(ro_regs, name, &reg_addr) &&
get_static_reg_addr(rw_regs, name, &reg_addr))
return -EFAULT;
return -EINVAL;
err = drci_rd_reg(dci_obj->usb_device, reg_addr, &val);
if (err < 0)
@ -870,7 +870,7 @@ static ssize_t value_store(struct device *dev, struct device_attribute *attr,
else if (!get_static_reg_addr(rw_regs, name, &reg_addr))
err = drci_wr_reg(usb_dev, reg_addr, val);
else
return -EFAULT;
return -EINVAL;
if (err < 0)
return err;