drm/atomic: Return commit in drm_crtc_commit_get for better annotation

This will allow code to do x->commit = drm_crtc_commit_get(commit),
making it clearer where references are used.

Signed-off-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20170904104838.23822-5-maarten.lankhorst@linux.intel.com
Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>
This commit is contained in:
Maarten Lankhorst 2017-09-04 12:48:36 +02:00
parent b44d5c0c10
commit f46640b931
2 changed files with 6 additions and 3 deletions

View File

@ -1633,8 +1633,7 @@ static int stall_checks(struct drm_crtc *crtc, bool nonblock)
return -EBUSY; return -EBUSY;
} }
} else if (i == 1) { } else if (i == 1) {
stall_commit = commit; stall_commit = drm_crtc_commit_get(commit);
drm_crtc_commit_get(stall_commit);
break; break;
} }

View File

@ -252,10 +252,14 @@ void __drm_crtc_commit_free(struct kref *kref);
* @commit: CRTC commit * @commit: CRTC commit
* *
* Increases the reference of @commit. * Increases the reference of @commit.
*
* Returns:
* The pointer to @commit, with reference increased.
*/ */
static inline void drm_crtc_commit_get(struct drm_crtc_commit *commit) static inline struct drm_crtc_commit *drm_crtc_commit_get(struct drm_crtc_commit *commit)
{ {
kref_get(&commit->ref); kref_get(&commit->ref);
return commit;
} }
/** /**