checkpatch: improve return negative errno check
Add a few conditions to the test to find return (ERRNO); Make the output message a bit less cryptic too. Signed-off-by: Joe Perches <joe@perches.com> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
This commit is contained in:
parent
b392c64f59
commit
f34e4a4f97
|
@ -4009,12 +4009,12 @@ sub process {
|
|||
}
|
||||
}
|
||||
|
||||
# Return of what appears to be an errno should normally be -'ve
|
||||
if ($line =~ /^.\s*return\s*(E[A-Z]*)\s*;/) {
|
||||
# Return of what appears to be an errno should normally be negative
|
||||
if ($sline =~ /\breturn(?:\s*\(+\s*|\s+)(E[A-Z]+)(?:\s*\)+\s*|\s*)[;:,]/) {
|
||||
my $name = $1;
|
||||
if ($name ne 'EOF' && $name ne 'ERROR') {
|
||||
WARN("USE_NEGATIVE_ERRNO",
|
||||
"return of an errno should typically be -ve (return -$1)\n" . $herecurr);
|
||||
"return of an errno should typically be negative (ie: return -$1)\n" . $herecurr);
|
||||
}
|
||||
}
|
||||
|
||||
|
|
Loading…
Reference in New Issue