drm/i915: Fix the interlace mode selection for gmch platforms
PIPECONF_INTERLACE_W_FIELD_INDICATION is only meant to be used for sdvo since it implies a slightly weird vsync shift of htotal/2. For everything else we should use PIPECONF_INTERLACE_W_SYNC_SHIFT and let the value in the VSYNCSHIFT register take effect. The only exception is gen3 simply because VSYNCSHIFT didn't exist yet. Gen2 doesn't support interlaced modes at all, so we can drop the explicit gen2 checks. Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com> Reviewed-by: Jesse Barnes <jbarnes@virtuousgeek.org> Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
This commit is contained in:
parent
609aeacaac
commit
efc2cfff28
|
@ -5535,13 +5535,13 @@ static void i9xx_set_pipeconf(struct intel_crtc *intel_crtc)
|
|||
}
|
||||
}
|
||||
|
||||
if (IS_VALLEYVIEW(dev) &&
|
||||
intel_crtc->config.adjusted_mode.flags & DRM_MODE_FLAG_INTERLACE)
|
||||
pipeconf |= PIPECONF_INTERLACE_W_SYNC_SHIFT;
|
||||
else if (!IS_GEN2(dev) &&
|
||||
intel_crtc->config.adjusted_mode.flags & DRM_MODE_FLAG_INTERLACE)
|
||||
pipeconf |= PIPECONF_INTERLACE_W_FIELD_INDICATION;
|
||||
else
|
||||
if (intel_crtc->config.adjusted_mode.flags & DRM_MODE_FLAG_INTERLACE) {
|
||||
if (INTEL_INFO(dev)->gen < 4 ||
|
||||
intel_pipe_has_type(&intel_crtc->base, INTEL_OUTPUT_SDVO))
|
||||
pipeconf |= PIPECONF_INTERLACE_W_FIELD_INDICATION;
|
||||
else
|
||||
pipeconf |= PIPECONF_INTERLACE_W_SYNC_SHIFT;
|
||||
} else
|
||||
pipeconf |= PIPECONF_PROGRESSIVE;
|
||||
|
||||
if (IS_VALLEYVIEW(dev) && intel_crtc->config.limited_color_range)
|
||||
|
|
Loading…
Reference in New Issue