From ef65d45cbfbb438a5fbe8ef3fc424314ff1e8b7c Mon Sep 17 00:00:00 2001 From: Thomas Gleixner Date: Fri, 4 Nov 2016 15:41:41 +0100 Subject: [PATCH] s390/smp: Make cpu notifier symetric There is no reason to remove the sysfs cpu files when the CPU is dead, they can be removed when the cpu is prepared to go down. Doing it at DOWN_PREPARE allows us to convert it to a symetric hotplug state in the next step. Signed-off-by: Thomas Gleixner Signed-off-by: Sebastian Andrzej Siewior Acked-by: Heiko Carstens Cc: Martin Schwidefsky Cc: linux-s390@vger.kernel.org Cc: rt@linutronix.de Link: http://lkml.kernel.org/r/20161104144140.lcee6kwmwlx37m7g@linutronix.de Signed-off-by: Thomas Gleixner --- arch/s390/kernel/smp.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/arch/s390/kernel/smp.c b/arch/s390/kernel/smp.c index 35531fe1c5ea..2a9c03df95e9 100644 --- a/arch/s390/kernel/smp.c +++ b/arch/s390/kernel/smp.c @@ -1056,9 +1056,10 @@ static int smp_cpu_notify(struct notifier_block *self, unsigned long action, switch (action & ~CPU_TASKS_FROZEN) { case CPU_ONLINE: + case CPU_DOWN_FAILED: err = sysfs_create_group(&s->kobj, &cpu_online_attr_group); break; - case CPU_DEAD: + case CPU_DOWN_PREPARE: sysfs_remove_group(&s->kobj, &cpu_online_attr_group); break; }