net: hsr: validate address B before copying to skb

Validate MAC address before copying the same to outgoing frame
skb destination address. Since a node can have zero mac
address for Link B until a valid frame is received over
that link, this fix address the issue of a zero MAC address
being in the packet.

Signed-off-by: Murali Karicheri <m-karicheri2@ti.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
Murali Karicheri 2020-07-17 10:55:10 -04:00 committed by David S. Miller
parent 6d6148bc78
commit eea9f73e1f
1 changed files with 2 additions and 1 deletions

View File

@ -325,7 +325,8 @@ void hsr_addr_subst_dest(struct hsr_node *node_src, struct sk_buff *skb,
if (port->type != node_dst->addr_B_port) if (port->type != node_dst->addr_B_port)
return; return;
ether_addr_copy(eth_hdr(skb)->h_dest, node_dst->macaddress_B); if (is_valid_ether_addr(node_dst->macaddress_B))
ether_addr_copy(eth_hdr(skb)->h_dest, node_dst->macaddress_B);
} }
void hsr_register_frame_in(struct hsr_node *node, struct hsr_port *port, void hsr_register_frame_in(struct hsr_node *node, struct hsr_port *port,