UbiquitousOS
/
OpenCloudOS-Kernel
mirror of https://gitee.com/OpenCloudOS/OpenCloudOS-Kernel.git
11
0
Fork 0
Code Issues Projects Releases Wiki Activity

drm/panfrost: Fix regulator_get_optional() misuse 

The panfrost driver requests a supply using regulator_get_optional()
but both the name of the supply and the usage pattern suggest that it is
being used for the main power for the device and is not at all optional
for the device for function, there is no meaningful handling for absent
supplies.  Such regulators should use the vanilla regulator_get()
interface, it will ensure that even if a supply is not described in the
system integration one will be provided in software.

Signed-off-by: Mark Brown <broonie@kernel.org>
Signed-off-by: Rob Herring <robh@kernel.org>
Link: https://patchwork.freedesktop.org/patch/msgid/20190904123032.23263-1-broonie@kernel.org
This commit is contained in:
Mark Brown 2019-09-04 13:30:32 +01:00 committed by Rob Herring
parent d4da4e3334
commit edfa07504c
1 changed files with 2 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
drivers/gpu/drm/panfrost/panfrost_device.c
View File

@ -89,12 +89,9 @@ static int panfrost_regulator_init(struct panfrost_device *pfdev)
{ {
int ret; int ret;
pfdev->regulator = devm_regulator_get_optional(pfdev->dev, "mali"); pfdev->regulator = devm_regulator_get(pfdev->dev, "mali");
if (IS_ERR(pfdev->regulator)) { if (IS_ERR(pfdev->regulator)) {
ret = PTR_ERR(pfdev->regulator); ret = PTR_ERR(pfdev->regulator);
pfdev->regulator = NULL;
if (ret == -ENODEV)
return 0;
dev_err(pfdev->dev, "failed to get regulator: %d\n", ret); dev_err(pfdev->dev, "failed to get regulator: %d\n", ret);
return ret; return ret;
} }
@ -110,8 +107,7 @@ static int panfrost_regulator_init(struct panfrost_device *pfdev)
static void panfrost_regulator_fini(struct panfrost_device *pfdev) static void panfrost_regulator_fini(struct panfrost_device *pfdev)
{ {
if (pfdev->regulator) regulator_disable(pfdev->regulator);
regulator_disable(pfdev->regulator);
} }
int panfrost_device_init(struct panfrost_device *pfdev) int panfrost_device_init(struct panfrost_device *pfdev)