UbiquitousOS
/
OpenCloudOS-Kernel
mirror of https://gitee.com/OpenCloudOS/OpenCloudOS-Kernel.git
11
0
Fork 0
Code Issues Projects Releases Wiki Activity

dmaengine: dmatest: timeout value of -1 should specify infinite wait 

The dmatest module parameter 'timeout' is documented as accepting a
-1 to mean "infinite timeout". However, an infinite timeout is not
advised, nor possible since the module parameter is an unsigned int,
which won't accept a negative value. Change the parameter
comment to reflect current behavior, which allows values from 0 up to
4294967295 (0xFFFFFFFF).

Signed-off-by: Gary R Hook <gary.hook@amd.com>
Signed-off-by: Vinod Koul <vkoul@kernel.org>
This commit is contained in:
Hook, Gary 2019-06-18 22:03:04 +00:00 committed by Vinod Koul
parent a183ec708b
commit ed04b7c57c
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
drivers/dma/dmatest.c
View File

@ -65,7 +65,7 @@ MODULE_PARM_DESC(pq_sources,
static int timeout = 3000; static int timeout = 3000;
module_param(timeout, uint, S_IRUGO | S_IWUSR); module_param(timeout, uint, S_IRUGO | S_IWUSR);
MODULE_PARM_DESC(timeout, "Transfer Timeout in msec (default: 3000), " MODULE_PARM_DESC(timeout, "Transfer Timeout in msec (default: 3000), "
"Pass -1 for infinite timeout"); "Pass 0xFFFFFFFF (4294967295) for maximum timeout");
static bool noverify; static bool noverify;
module_param(noverify, bool, S_IRUGO | S_IWUSR); module_param(noverify, bool, S_IRUGO | S_IWUSR);
@ -97,7 +97,7 @@ MODULE_PARM_DESC(transfer_size, "Optional custom transfer size in bytes (default
* @iterations: iterations before stopping test * @iterations: iterations before stopping test
* @xor_sources: number of xor source buffers * @xor_sources: number of xor source buffers
* @pq_sources: number of p+q source buffers * @pq_sources: number of p+q source buffers
* @timeout: transfer timeout in msec, -1 for infinite timeout * @timeout: transfer timeout in msec, 0 - 0xFFFFFFFF (4294967295)
*/ */
struct dmatest_params { struct dmatest_params {
unsigned int buf_size; unsigned int buf_size;
@ -108,7 +108,7 @@ struct dmatest_params {
unsigned int iterations; unsigned int iterations;
unsigned int xor_sources; unsigned int xor_sources;
unsigned int pq_sources; unsigned int pq_sources;
int timeout; unsigned int timeout;
bool noverify; bool noverify;
bool norandom; bool norandom;
int alignment; int alignment;