UbiquitousOS
/
OpenCloudOS-Kernel
mirror of https://gitee.com/OpenCloudOS/OpenCloudOS-Kernel.git
11
0
Fork 0
Code Issues Projects Releases Wiki Activity

PCI: Constify sysfs attribute_group structures 

attribute_groups are not supposed to change at runtime.  All functions
working with attribute_groups provided by <linux/sysfs.h> work with const
attribute_group.  So mark the non-const structs as const.

File size before:
   text	   data	    bss	    dec	    hex	filename
   8480	   2024	      4	  10508	   290c	drivers/pci/pci-sysfs.o

File size After adding 'const':
   text	   data	    bss	    dec	    hex	filename
   8736	   1768	      4	  10508	   290c	drivers/pci/pci-sysfs.o

Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
This commit is contained in:
Arvind Yadav 2017-07-11 14:57:07 +05:30 committed by Bjorn Helgaas
parent 16f73eb02d
commit e7ea9825fa
1 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
drivers/pci/pci-sysfs.c
View File

@ -1735,7 +1735,7 @@ const struct attribute_group *pcie_dev_groups[] = {
NULL, NULL,
}; };
static struct attribute_group pci_dev_hp_attr_group = { static const struct attribute_group pci_dev_hp_attr_group = {
.attrs = pci_dev_hp_attrs, .attrs = pci_dev_hp_attrs,
.is_visible = pci_dev_hp_attrs_are_visible, .is_visible = pci_dev_hp_attrs_are_visible,
}; };
@ -1759,23 +1759,23 @@ static umode_t sriov_attrs_are_visible(struct kobject *kobj,
return a->mode; return a->mode;
} }
static struct attribute_group sriov_dev_attr_group = { static const struct attribute_group sriov_dev_attr_group = {
.attrs = sriov_dev_attrs, .attrs = sriov_dev_attrs,
.is_visible = sriov_attrs_are_visible, .is_visible = sriov_attrs_are_visible,
}; };
#endif /* CONFIG_PCI_IOV */ #endif /* CONFIG_PCI_IOV */
static struct attribute_group pci_dev_attr_group = { static const struct attribute_group pci_dev_attr_group = {
.attrs = pci_dev_dev_attrs, .attrs = pci_dev_dev_attrs,
.is_visible = pci_dev_attrs_are_visible, .is_visible = pci_dev_attrs_are_visible,
}; };
static struct attribute_group pci_bridge_attr_group = { static const struct attribute_group pci_bridge_attr_group = {
.attrs = pci_bridge_attrs, .attrs = pci_bridge_attrs,
.is_visible = pci_bridge_attrs_are_visible, .is_visible = pci_bridge_attrs_are_visible,
}; };
static struct attribute_group pcie_dev_attr_group = { static const struct attribute_group pcie_dev_attr_group = {
.attrs = pcie_dev_attrs, .attrs = pcie_dev_attrs,
.is_visible = pcie_dev_attrs_are_visible, .is_visible = pcie_dev_attrs_are_visible,
}; };