UbiquitousOS
/
OpenCloudOS-Kernel
mirror of https://gitee.com/OpenCloudOS/OpenCloudOS-Kernel.git
11
0
Fork 0
Code Issues Projects Releases Wiki Activity

net: phy: marvell: fix m88e1111_set_downshift 

Changing downshift params without software reset has no effect,
so call genphy_soft_reset() after change downshift params.

As the datasheet says:
Changes to these bits are disruptive to the normal operation therefore,
any changes to these registers must be followed by software reset
to take effect.

Fixes: 5c6bc5199b ("net: phy: marvell: add downshift support for M88E1111")
Signed-off-by: Maxim Kochetkov <fido_max@inbox.ru>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
Maxim Kochetkov 2021-04-22 13:46:44 +03:00 committed by David S. Miller
parent 990875b299
commit e7679c55a7
1 changed files with 16 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

26
drivers/net/phy/marvell.c
View File

@ -967,22 +967,28 @@ static int m88e1111_get_downshift(struct phy_device *phydev, u8 *data)
static int m88e1111_set_downshift(struct phy_device *phydev, u8 cnt) static int m88e1111_set_downshift(struct phy_device *phydev, u8 cnt)
{ {
int val; int val, err;
if (cnt > MII_M1111_PHY_EXT_CR_DOWNSHIFT_MAX) if (cnt > MII_M1111_PHY_EXT_CR_DOWNSHIFT_MAX)
return -E2BIG; return -E2BIG;
if (!cnt) if (!cnt) {
return phy_clear_bits(phydev, MII_M1111_PHY_EXT_CR, err = phy_clear_bits(phydev, MII_M1111_PHY_EXT_CR,
MII_M1111_PHY_EXT_CR_DOWNSHIFT_EN); MII_M1111_PHY_EXT_CR_DOWNSHIFT_EN);
} else {
val = MII_M1111_PHY_EXT_CR_DOWNSHIFT_EN;
val |= FIELD_PREP(MII_M1111_PHY_EXT_CR_DOWNSHIFT_MASK, cnt - 1);
val = MII_M1111_PHY_EXT_CR_DOWNSHIFT_EN; err = phy_modify(phydev, MII_M1111_PHY_EXT_CR,
val |= FIELD_PREP(MII_M1111_PHY_EXT_CR_DOWNSHIFT_MASK, cnt - 1); MII_M1111_PHY_EXT_CR_DOWNSHIFT_EN |
MII_M1111_PHY_EXT_CR_DOWNSHIFT_MASK,
val);
}
return phy_modify(phydev, MII_M1111_PHY_EXT_CR, if (err < 0)
MII_M1111_PHY_EXT_CR_DOWNSHIFT_EN | return err;
MII_M1111_PHY_EXT_CR_DOWNSHIFT_MASK,
val); return genphy_soft_reset(phydev);
} }
static int m88e1111_get_tunable(struct phy_device *phydev, static int m88e1111_get_tunable(struct phy_device *phydev,