UbiquitousOS
/
OpenCloudOS-Kernel
mirror of https://gitee.com/OpenCloudOS/OpenCloudOS-Kernel.git
11
0
Fork 0
Code Issues Projects Releases Wiki Activity

drm/amdkfd: Compress unnecessary function parameters 

Signed-off-by: Yong Zhao <yong.zhao@amd.com>
Reviewed-by: Oded Gabbay <oded.gabbay@gmail.com>
Signed-off-by: Oded Gabbay <oded.gabbay@gmail.com>
This commit is contained in:
Yong Zhao 2017-09-27 00:09:53 -04:00 committed by Oded Gabbay
parent 9fd3f1bfae
commit e6f791b1b0
4 changed files with 7 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
drivers/gpu/drm/amd/amdkfd/kfd_chardev.c
View File

@ -282,8 +282,7 @@ static int kfd_ioctl_create_queue(struct file *filep, struct kfd_process *p,
p->pasid, p->pasid,
dev->id); dev->id);
err = pqm_create_queue(&p->pqm, dev, filep, &q_properties, err = pqm_create_queue(&p->pqm, dev, filep, &q_properties, &queue_id);
0, q_properties.type, &queue_id);
if (err != 0) if (err != 0)
goto err_create_queue; goto err_create_queue;

5
drivers/gpu/drm/amd/amdkfd/kfd_dbgdev.c
View File

@ -184,9 +184,10 @@ static int dbgdev_register_diq(struct kfd_dbgdev *dbgdev)
struct kernel_queue *kq = NULL; struct kernel_queue *kq = NULL;
int status; int status;
properties.type = KFD_QUEUE_TYPE_DIQ;
status = pqm_create_queue(dbgdev->pqm, dbgdev->dev, NULL, status = pqm_create_queue(dbgdev->pqm, dbgdev->dev, NULL,
&properties, 0, KFD_QUEUE_TYPE_DIQ, &properties, &qid);
&qid);
if (status) { if (status) {
pr_err("Failed to create DIQ\n"); pr_err("Failed to create DIQ\n");

2
drivers/gpu/drm/amd/amdkfd/kfd_priv.h
View File

@ -677,8 +677,6 @@ int pqm_create_queue(struct process_queue_manager *pqm,
struct kfd_dev *dev, struct kfd_dev *dev,
struct file *f, struct file *f,
struct queue_properties *properties, struct queue_properties *properties,
unsigned int flags,
enum kfd_queue_type type,
unsigned int *qid); unsigned int *qid);
int pqm_destroy_queue(struct process_queue_manager *pqm, unsigned int qid); int pqm_destroy_queue(struct process_queue_manager *pqm, unsigned int qid);
int pqm_update_queue(struct process_queue_manager *pqm, unsigned int qid, int pqm_update_queue(struct process_queue_manager *pqm, unsigned int qid,

10
drivers/gpu/drm/amd/amdkfd/kfd_process_queue_manager.c
View File

@ -142,20 +142,17 @@ int pqm_create_queue(struct process_queue_manager *pqm,
struct kfd_dev *dev, struct kfd_dev *dev,
struct file *f, struct file *f,
struct queue_properties *properties, struct queue_properties *properties,
unsigned int flags,
enum kfd_queue_type type,
unsigned int *qid) unsigned int *qid)
{ {
int retval; int retval;
struct kfd_process_device *pdd; struct kfd_process_device *pdd;
struct queue_properties q_properties;
struct queue *q; struct queue *q;
struct process_queue_node *pqn; struct process_queue_node *pqn;
struct kernel_queue *kq; struct kernel_queue *kq;
int num_queues = 0; int num_queues = 0;
struct queue *cur; struct queue *cur;
enum kfd_queue_type type = properties->type;
memcpy(&q_properties, properties, sizeof(struct queue_properties));
q = NULL; q = NULL;
kq = NULL; kq = NULL;
@ -206,7 +203,7 @@ int pqm_create_queue(struct process_queue_manager *pqm,
goto err_create_queue; goto err_create_queue;
} }
retval = create_cp_queue(pqm, dev, &q, &q_properties, f, *qid); retval = create_cp_queue(pqm, dev, &q, properties, f, *qid);
if (retval != 0) if (retval != 0)
goto err_create_queue; goto err_create_queue;
pqn->q = q; pqn->q = q;
@ -243,9 +240,8 @@ int pqm_create_queue(struct process_queue_manager *pqm,
list_add(&pqn->process_queue_list, &pqm->queues); list_add(&pqn->process_queue_list, &pqm->queues);
if (q) { if (q) {
*properties = q->properties;
pr_debug("PQM done creating queue\n"); pr_debug("PQM done creating queue\n");
print_queue_properties(properties); print_queue_properties(&q->properties);
} }
return retval; return retval;