V4L/DVB (13166): remove duplicate structure field initialization
The definition of tvaudio_tuner_ops initializes the s_tuner field twice. It appears that the second case should initialize the g_tuner field. The semantic match that finds this problem is as follows: (http://coccinelle.lip6.fr/) // <smpl> @r@ identifier I, s, fld; position p0,p; expression E; @@ struct I s =@p0 { ... .fld@p = E, ...}; @s@ identifier I, s, r.fld; position r.p0,p; expression E; @@ struct I s =@p0 { ... .fld@p = E, ...}; @script:python@ p0 << r.p0; fld << r.fld; ps << s.p; pr << r.p; @@ if int(ps[0].line)!=int(pr[0].line) or int(ps[0].column)!=int(pr[0].column): cocci.print_main(fld,p0) // </smpl> Signed-off-by: Julia Lawall <julia@diku.dk> Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
This commit is contained in:
parent
7cbefad085
commit
e6a1a08f00
|
@ -1919,7 +1919,7 @@ static const struct v4l2_subdev_tuner_ops tvaudio_tuner_ops = {
|
|||
.s_radio = tvaudio_s_radio,
|
||||
.s_frequency = tvaudio_s_frequency,
|
||||
.s_tuner = tvaudio_s_tuner,
|
||||
.s_tuner = tvaudio_g_tuner,
|
||||
.g_tuner = tvaudio_g_tuner,
|
||||
};
|
||||
|
||||
static const struct v4l2_subdev_audio_ops tvaudio_audio_ops = {
|
||||
|
|
Loading…
Reference in New Issue